From: Marc Zyngier <maz@kernel.org>
To: Marek Vasut <marex@denx.de>
Cc: linux-gpio@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Linus Walleij <linus.walleij@linaro.org>,
Loic Poulain <loic.poulain@linaro.org>,
NXP Linux Team <linux-imx@nxp.com>, Peng Fan <peng.fan@nxp.com>,
Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH v5 0/2] gpio: mxc: Locking and direction input fix
Date: Mon, 25 Jul 2022 16:50:33 +0100 [thread overview]
Message-ID: <87bktdxkc6.wl-maz@kernel.org> (raw)
In-Reply-To: <20220725103445.88674-1-marex@denx.de>
On Mon, 25 Jul 2022 11:34:43 +0100,
Marek Vasut <marex@denx.de> wrote:
>
> The irqchip callbacks in gpio-mxc perform register read-modify-write operations
> without locking, which may lead to a race condition. Add the missing locking.
>
> In case the GPIO is used as IRQ, make sure it is configured as input.
>
> Marek Vasut (2):
> gpio: mxc: Protect GPIO irqchip RMW with bgpio spinlock
> gpio: mxc: Always set GPIOs used as interrupt source to INPUT mode
>
> drivers/gpio/gpio-mxc.c | 17 ++++++++++++++++-
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Loic Poulain <loic.poulain@linaro.org>
> Cc: Marc Zyngier <maz@kernel.org>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
Reviewed-by: Marc Zyngier <maz@kernel.org>
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2022-07-25 15:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 10:34 [PATCH v5 0/2] gpio: mxc: Locking and direction input fix Marek Vasut
2022-07-25 10:34 ` [PATCH v5 1/2] gpio: mxc: Protect GPIO irqchip RMW with bgpio spinlock Marek Vasut
2022-07-25 22:36 ` Linus Walleij
2022-07-25 10:34 ` [PATCH v5 2/2] gpio: mxc: Always set GPIOs used as interrupt source to INPUT mode Marek Vasut
2022-07-25 20:40 ` Andy Shevchenko
2022-07-25 15:50 ` Marc Zyngier [this message]
2022-08-23 10:41 ` [PATCH v5 0/2] gpio: mxc: Locking and direction input fix Marek Vasut
2022-08-23 14:20 ` Marc Zyngier
2022-09-29 17:35 ` Marek Vasut
2022-08-26 8:40 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bktdxkc6.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=loic.poulain@linaro.org \
--cc=marex@denx.de \
--cc=peng.fan@nxp.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).