From: Marc Zyngier <maz@kernel.org>
To: Marek Vasut <marex@denx.de>
Cc: linux-gpio@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Linus Walleij <linus.walleij@linaro.org>,
Loic Poulain <loic.poulain@linaro.org>,
NXP Linux Team <linux-imx@nxp.com>, Peng Fan <peng.fan@nxp.com>,
Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH v3 1/2] gpio: mxc: Protect GPIO irqchip RMW with bgpio spinlock
Date: Mon, 25 Jul 2022 11:06:26 +0100 [thread overview]
Message-ID: <87edy9y09p.wl-maz@kernel.org> (raw)
In-Reply-To: <233aebcf-71a0-9738-2100-741ed602f075@denx.de>
On Mon, 25 Jul 2022 10:57:32 +0100,
Marek Vasut <marex@denx.de> wrote:
>
> On 7/25/22 08:53, Marc Zyngier wrote:
> > However, you have totally ignored my earlier comments in your v4:
> >
> > - This doesn't compile, as bgpio_lock has been changed to a *raw*
> > spinlock. You obviously haven't even bothered testing your patch.
>
> Yes indeed, I tested every single one on 5.18.y . I noticed the raw
> spinlock change is only in next.
$ git describe --contains 3c938cc5cebcb --match=v*
v5.19-rc1~134^2~25
Only in -next? Not quite.
>
> > - I asked for a cover letter for any series with multiple patch.
> > That's not exactly a new requirement.
> >
> > So we got 4 versions in just over 24 hours, none of which actually
> > work. Do you see the overarching problem?
>
> Lemme rebase this on next and send v5.
Rebasing on -rc1 is the right thing to do. You should never base
something on -next, as this is a moving target.
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2022-07-25 10:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-24 17:10 [PATCH v3 1/2] gpio: mxc: Protect GPIO irqchip RMW with bgpio spinlock Marek Vasut
2022-07-24 17:10 ` [PATCH v3 2/2] gpio: mxc: Always set GPIOs used as interrupt source to INPUT mode Marek Vasut
2022-07-25 20:36 ` Andy Shevchenko
2022-07-25 21:26 ` Marek Vasut
2022-07-26 8:22 ` Linus Walleij
2022-07-24 17:50 ` [PATCH v3 1/2] gpio: mxc: Protect GPIO irqchip RMW with bgpio spinlock Marc Zyngier
2022-07-24 18:15 ` Marek Vasut
2022-07-25 6:53 ` Marc Zyngier
2022-07-25 9:57 ` Marek Vasut
2022-07-25 10:06 ` Marc Zyngier [this message]
2022-07-24 18:32 ` kernel test robot
2022-07-24 18:42 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edy9y09p.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=loic.poulain@linaro.org \
--cc=marex@denx.de \
--cc=peng.fan@nxp.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).