From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9298C433EF for ; Mon, 25 Jul 2022 10:06:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232179AbiGYKGb (ORCPT ); Mon, 25 Jul 2022 06:06:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233423AbiGYKGb (ORCPT ); Mon, 25 Jul 2022 06:06:31 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD7C1EE05 for ; Mon, 25 Jul 2022 03:06:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1BCE1612D5 for ; Mon, 25 Jul 2022 10:06:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C9C2C341C6; Mon, 25 Jul 2022 10:06:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658743589; bh=7JuMGMjeZuUeMXBmbpPBTPHTabt1zz6VmQpAurLLT3M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DZHq37U2XxvDL7T7WzmfwlBSX6pd7Vc7W17/pcS50AebSK+alHud+0hcoayLbuyn1 qkxEsFKeq3GaeDSpUocu/MvFVfs0G3WV2teFJdCD+Gjg9ytLvwyJ0ee2OYUNH6eCKg uX4jOqNC96SFQKuVePg/j0soaUUCsFbHYRkeSLc8fNruAsLvd8s8cDhcsz6lsXlWRr 9Pvoyt0Lw83o+cmPob1BuJSOo7la1gMMJemUTeHry3hlIlrksyFV/mfEJZ5fqPdZHL 0Fic97SCESXEqddRc0dzSacoNERCT+KfB8f3DoyZ8vviMAAPP8wrNx0YrZ14RhMlYk Jw1Pu47F976vA== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oFuyp-009oTI-2E; Mon, 25 Jul 2022 11:06:27 +0100 Date: Mon, 25 Jul 2022 11:06:26 +0100 Message-ID: <87edy9y09p.wl-maz@kernel.org> From: Marc Zyngier To: Marek Vasut Cc: linux-gpio@vger.kernel.org, Bartosz Golaszewski , Linus Walleij , Loic Poulain , NXP Linux Team , Peng Fan , Shawn Guo Subject: Re: [PATCH v3 1/2] gpio: mxc: Protect GPIO irqchip RMW with bgpio spinlock In-Reply-To: <233aebcf-71a0-9738-2100-741ed602f075@denx.de> References: <20220724171057.18549-1-marex@denx.de> <87fsiqxuvd.wl-maz@kernel.org> <871qu9d6ns.wl-maz@kernel.org> <233aebcf-71a0-9738-2100-741ed602f075@denx.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: marex@denx.de, linux-gpio@vger.kernel.org, bgolaszewski@baylibre.com, linus.walleij@linaro.org, loic.poulain@linaro.org, linux-imx@nxp.com, peng.fan@nxp.com, shawnguo@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, 25 Jul 2022 10:57:32 +0100, Marek Vasut wrote: > > On 7/25/22 08:53, Marc Zyngier wrote: > > However, you have totally ignored my earlier comments in your v4: > > > > - This doesn't compile, as bgpio_lock has been changed to a *raw* > > spinlock. You obviously haven't even bothered testing your patch. > > Yes indeed, I tested every single one on 5.18.y . I noticed the raw > spinlock change is only in next. $ git describe --contains 3c938cc5cebcb --match=v* v5.19-rc1~134^2~25 Only in -next? Not quite. > > > - I asked for a cover letter for any series with multiple patch. > > That's not exactly a new requirement. > > > > So we got 4 versions in just over 24 hours, none of which actually > > work. Do you see the overarching problem? > > Lemme rebase this on next and send v5. Rebasing on -rc1 is the right thing to do. You should never base something on -next, as this is a moving target. M. -- Without deviation from the norm, progress is not possible.