From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Marek Behun <marek.behun@nic.cz>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Jason Cooper" <jason@lakedaemon.net>,
"Andrew Lunn" <andrew@lunn.ch>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
linux-arm-kernel@lists.infradead.org,
"Antoine Tenart" <antoine.tenart@bootlin.com>,
"Miquèl Raynal" <miquel.raynal@bootlin.com>,
"Maxime Chevallier" <maxime.chevallier@bootlin.com>,
"Nadav Haklai" <nadavh@marvell.com>,
"Marcin Wojtas" <mw@semihalf.com>
Subject: Re: [PATCH 1/3] pinctrl: armada-37xx: Correct mpp definitions
Date: Mon, 24 Dec 2018 18:05:15 +0100 [thread overview]
Message-ID: <87efa6c0tw.fsf@bootlin.com> (raw)
In-Reply-To: <20181222033213.43642e0f@nic.cz> (Marek Behun's message of "Sat, 22 Dec 2018 03:32:13 +0100")
Hi Marek,
On sam., déc. 22 2018, Marek Behun <marek.behun@nic.cz> wrote:
> On Fri, 21 Dec 2018 18:32:57 +0100
> Gregory CLEMENT <gregory.clement@bootlin.com> wrote:
>
>> + PIN_GRP_GPIO("pcie1", 3, 1, BIT(5), "pcie"),
>> + PIN_GRP_GPIO("pcie1_clkreq", 4, 1, BIT(9), "pcie"),
>
> If the pair is split to clkreq and reset, shouldn't the first be called
> pcie1_reset?
I considered this but chose to keep pcie1 in order to preserve backward
compatibility.
I agree that it is debatable, because without the fix the old device
tree can't work. However I find it better preserving the initial intent
of an existing device tree.
By talking about it, I think about an other option, keeping pcie1 name
to setup the pins 39 and 40 how it was documented. And introducing
pcie1_reset and pcie1_clkreq for new binding. however I don't know how
it could be handle by the pinctrl framework.
Gregory
> Marek
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
next prev parent reply other threads:[~2018-12-24 17:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-21 17:32 [PATCH 0/3] Few fix for pins configuration on Armada 37xx Gregory CLEMENT
2018-12-21 17:32 ` [PATCH 1/3] pinctrl: armada-37xx: Correct mpp definitions Gregory CLEMENT
2018-12-22 2:32 ` Marek Behun
2018-12-24 17:05 ` Gregory CLEMENT [this message]
2018-12-21 17:32 ` [PATCH 2/3] pinctrl: armada-37xx: add missing pin: PCIe1 Wakeup Gregory CLEMENT
2018-12-21 17:32 ` [PATCH 3/3] pinctrl: dt-bindings: Fix the armada-37xx documentation Gregory CLEMENT
2019-01-03 14:38 ` [PATCH 0/3] Few fix for pins configuration on Armada 37xx Miquel Raynal
2019-01-11 8:54 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efa6c0tw.fsf@bootlin.com \
--to=gregory.clement@bootlin.com \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=jason@lakedaemon.net \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.behun@nic.cz \
--cc=maxime.chevallier@bootlin.com \
--cc=miquel.raynal@bootlin.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).