linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: NeilBrown <neil@brown.name>
To: Sergio Paracuellos <sergio.paracuellos@gmail.com>,
	Greg KH <gregkh@linuxfoundation.org>
Cc: linux-gpio@vger.kernel.org, linus.walleij@linaro.org,
	driverdev-devel@linuxdriverproject.org
Subject: Re: [PATCH] staging: mt7621-gpio: move out of staging
Date: Sat, 02 Jun 2018 09:30:03 +1000	[thread overview]
Message-ID: <87efhqrsp0.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <CAMhs-H_u1q7pfTRrU34p0HjxQeAMGPv54EnFBLFbKQLajDw21g@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1071 bytes --]

On Fri, Jun 01 2018, Sergio Paracuellos wrote:

>> I suggest you submit this as a new driver to the gpio maintainer and
>> developers and then if/when it is merged into that tree, we can then
>> delete the staging tree version.  That makes it easier for the gpio
>> developers to review it and makes any cross-tree merge issues go away.
>
> I see. Ok, I'll send this in the way you are pointing out here
> hopefully tomorrow morning :-)

When you do, please also Cc maintainers for
  OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
to get review for the new .dts file, though get-maintainers will
probably recommend that once you have a proper patch.
Also it would be good to highlight any uncertainties we might have
to get review comments specifically on those.
Specifically we should mention that

  The functionality is presented as a single irq-chip but 3 separate
  gpio-chips, as this seemed simplest.  Is this acceptable, or does it
  need to be changed?

Please add my Reviewed-by: NeilBrown <neil@brown.name> to the patch when
you send it.

Thanks,
NeilBrown


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 169 bytes --]

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2018-06-01 23:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-01 12:02 [PATCH] staging: mt7621-gpio: move out of staging Sergio Paracuellos
2018-06-01 18:13 ` Greg KH
2018-06-01 19:02   ` Sergio Paracuellos
2018-06-01 23:30     ` NeilBrown [this message]
2018-06-02  7:33       ` Sergio Paracuellos
2018-06-04  9:09 ` Dan Carpenter
2018-06-05 11:19   ` Sergio Paracuellos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87efhqrsp0.fsf@notabene.neil.brown.name \
    --to=neil@brown.name \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=sergio.paracuellos@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).