* [PATCH] pinctrl: tegra: fix missing __iomem in suspend/resume
@ 2019-12-18 11:04 Ben Dooks (Codethink)
2019-12-18 13:05 ` Dmitry Osipenko
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Ben Dooks (Codethink) @ 2019-12-18 11:04 UTC (permalink / raw)
To: ben.dooks
Cc: Linus Walleij, Thierry Reding, Jonathan Hunter, Dmitry Osipenko,
linux-gpio, linux-tegra
The functions should have __iomem on the register pointer
so add that to silence the following sparse warnings:
drivers/pinctrl/tegra/pinctrl-tegra.c:657:22: warning: incorrect type in assignment (different address spaces)
drivers/pinctrl/tegra/pinctrl-tegra.c:657:22: expected unsigned int [usertype] *regs
drivers/pinctrl/tegra/pinctrl-tegra.c:657:22: got void [noderef] <asn:2> *
drivers/pinctrl/tegra/pinctrl-tegra.c:659:42: warning: incorrect type in argument 1 (different address spaces)
drivers/pinctrl/tegra/pinctrl-tegra.c:659:42: expected void const volatile [noderef] <asn:2> *addr
drivers/pinctrl/tegra/pinctrl-tegra.c:659:42: got unsigned int [usertype] *
drivers/pinctrl/tegra/pinctrl-tegra.c:675:22: warning: incorrect type in assignment (different address spaces)
drivers/pinctrl/tegra/pinctrl-tegra.c:675:22: expected unsigned int [usertype] *regs
drivers/pinctrl/tegra/pinctrl-tegra.c:675:22: got void [noderef] <asn:2> *
drivers/pinctrl/tegra/pinctrl-tegra.c:677:25: warning: incorrect type in argument 2 (different address spaces)
drivers/pinctrl/tegra/pinctrl-tegra.c:677:25: expected void volatile [noderef] <asn:2> *addr
drivers/pinctrl/tegra/pinctrl-tegra.c:677:25: got unsigned int [usertype] *
Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
---
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: Dmitry Osipenko <digetx@gmail.com>
Cc: linux-gpio@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
---
drivers/pinctrl/tegra/pinctrl-tegra.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegra/pinctrl-tegra.c
index 692d8b3e2a20..cefbbb8d1a68 100644
--- a/drivers/pinctrl/tegra/pinctrl-tegra.c
+++ b/drivers/pinctrl/tegra/pinctrl-tegra.c
@@ -648,7 +648,7 @@ static int tegra_pinctrl_suspend(struct device *dev)
{
struct tegra_pmx *pmx = dev_get_drvdata(dev);
u32 *backup_regs = pmx->backup_regs;
- u32 *regs;
+ u32 __iomem *regs;
size_t bank_size;
unsigned int i, k;
@@ -666,7 +666,7 @@ static int tegra_pinctrl_resume(struct device *dev)
{
struct tegra_pmx *pmx = dev_get_drvdata(dev);
u32 *backup_regs = pmx->backup_regs;
- u32 *regs;
+ u32 __iomem *regs;
size_t bank_size;
unsigned int i, k;
--
2.24.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] pinctrl: tegra: fix missing __iomem in suspend/resume
2019-12-18 11:04 [PATCH] pinctrl: tegra: fix missing __iomem in suspend/resume Ben Dooks (Codethink)
@ 2019-12-18 13:05 ` Dmitry Osipenko
2019-12-19 13:02 ` Thierry Reding
2020-01-06 23:00 ` Linus Walleij
2 siblings, 0 replies; 5+ messages in thread
From: Dmitry Osipenko @ 2019-12-18 13:05 UTC (permalink / raw)
To: Ben Dooks (Codethink), Linus Walleij
Cc: Thierry Reding, Jonathan Hunter, linux-gpio, linux-tegra
18.12.2019 14:04, Ben Dooks (Codethink) пишет:
> The functions should have __iomem on the register pointer
> so add that to silence the following sparse warnings:
>
> drivers/pinctrl/tegra/pinctrl-tegra.c:657:22: warning: incorrect type in assignment (different address spaces)
> drivers/pinctrl/tegra/pinctrl-tegra.c:657:22: expected unsigned int [usertype] *regs
> drivers/pinctrl/tegra/pinctrl-tegra.c:657:22: got void [noderef] <asn:2> *
> drivers/pinctrl/tegra/pinctrl-tegra.c:659:42: warning: incorrect type in argument 1 (different address spaces)
> drivers/pinctrl/tegra/pinctrl-tegra.c:659:42: expected void const volatile [noderef] <asn:2> *addr
> drivers/pinctrl/tegra/pinctrl-tegra.c:659:42: got unsigned int [usertype] *
> drivers/pinctrl/tegra/pinctrl-tegra.c:675:22: warning: incorrect type in assignment (different address spaces)
> drivers/pinctrl/tegra/pinctrl-tegra.c:675:22: expected unsigned int [usertype] *regs
> drivers/pinctrl/tegra/pinctrl-tegra.c:675:22: got void [noderef] <asn:2> *
> drivers/pinctrl/tegra/pinctrl-tegra.c:677:25: warning: incorrect type in argument 2 (different address spaces)
> drivers/pinctrl/tegra/pinctrl-tegra.c:677:25: expected void volatile [noderef] <asn:2> *addr
> drivers/pinctrl/tegra/pinctrl-tegra.c:677:25: got unsigned int [usertype] *
>
> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
> ---
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Jonathan Hunter <jonathanh@nvidia.com>
> Cc: Dmitry Osipenko <digetx@gmail.com>
> Cc: linux-gpio@vger.kernel.org
> Cc: linux-tegra@vger.kernel.org
> ---
> drivers/pinctrl/tegra/pinctrl-tegra.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegra/pinctrl-tegra.c
> index 692d8b3e2a20..cefbbb8d1a68 100644
> --- a/drivers/pinctrl/tegra/pinctrl-tegra.c
> +++ b/drivers/pinctrl/tegra/pinctrl-tegra.c
> @@ -648,7 +648,7 @@ static int tegra_pinctrl_suspend(struct device *dev)
> {
> struct tegra_pmx *pmx = dev_get_drvdata(dev);
> u32 *backup_regs = pmx->backup_regs;
> - u32 *regs;
> + u32 __iomem *regs;
> size_t bank_size;
> unsigned int i, k;
>
> @@ -666,7 +666,7 @@ static int tegra_pinctrl_resume(struct device *dev)
> {
> struct tegra_pmx *pmx = dev_get_drvdata(dev);
> u32 *backup_regs = pmx->backup_regs;
> - u32 *regs;
> + u32 __iomem *regs;
> size_t bank_size;
> unsigned int i, k;
>
>
Looks good!
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] pinctrl: tegra: fix missing __iomem in suspend/resume
2019-12-18 11:04 [PATCH] pinctrl: tegra: fix missing __iomem in suspend/resume Ben Dooks (Codethink)
2019-12-18 13:05 ` Dmitry Osipenko
@ 2019-12-19 13:02 ` Thierry Reding
2020-01-06 23:00 ` Linus Walleij
2 siblings, 0 replies; 5+ messages in thread
From: Thierry Reding @ 2019-12-19 13:02 UTC (permalink / raw)
To: Ben Dooks (Codethink)
Cc: Linus Walleij, Jonathan Hunter, Dmitry Osipenko, linux-gpio,
linux-tegra
[-- Attachment #1: Type: text/plain, Size: 1854 bytes --]
On Wed, Dec 18, 2019 at 11:04:56AM +0000, Ben Dooks (Codethink) wrote:
> The functions should have __iomem on the register pointer
> so add that to silence the following sparse warnings:
>
> drivers/pinctrl/tegra/pinctrl-tegra.c:657:22: warning: incorrect type in assignment (different address spaces)
> drivers/pinctrl/tegra/pinctrl-tegra.c:657:22: expected unsigned int [usertype] *regs
> drivers/pinctrl/tegra/pinctrl-tegra.c:657:22: got void [noderef] <asn:2> *
> drivers/pinctrl/tegra/pinctrl-tegra.c:659:42: warning: incorrect type in argument 1 (different address spaces)
> drivers/pinctrl/tegra/pinctrl-tegra.c:659:42: expected void const volatile [noderef] <asn:2> *addr
> drivers/pinctrl/tegra/pinctrl-tegra.c:659:42: got unsigned int [usertype] *
> drivers/pinctrl/tegra/pinctrl-tegra.c:675:22: warning: incorrect type in assignment (different address spaces)
> drivers/pinctrl/tegra/pinctrl-tegra.c:675:22: expected unsigned int [usertype] *regs
> drivers/pinctrl/tegra/pinctrl-tegra.c:675:22: got void [noderef] <asn:2> *
> drivers/pinctrl/tegra/pinctrl-tegra.c:677:25: warning: incorrect type in argument 2 (different address spaces)
> drivers/pinctrl/tegra/pinctrl-tegra.c:677:25: expected void volatile [noderef] <asn:2> *addr
> drivers/pinctrl/tegra/pinctrl-tegra.c:677:25: got unsigned int [usertype] *
>
> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
> ---
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Jonathan Hunter <jonathanh@nvidia.com>
> Cc: Dmitry Osipenko <digetx@gmail.com>
> Cc: linux-gpio@vger.kernel.org
> Cc: linux-tegra@vger.kernel.org
> ---
> drivers/pinctrl/tegra/pinctrl-tegra.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pinctrl: tegra: fix missing __iomem in suspend/resume
2019-12-18 11:04 [PATCH] pinctrl: tegra: fix missing __iomem in suspend/resume Ben Dooks (Codethink)
2019-12-18 13:05 ` Dmitry Osipenko
2019-12-19 13:02 ` Thierry Reding
@ 2020-01-06 23:00 ` Linus Walleij
2020-01-07 8:13 ` Ben Dooks
2 siblings, 1 reply; 5+ messages in thread
From: Linus Walleij @ 2020-01-06 23:00 UTC (permalink / raw)
To: Ben Dooks (Codethink)
Cc: Thierry Reding, Jonathan Hunter, Dmitry Osipenko,
open list:GPIO SUBSYSTEM, linux-tegra
On Wed, Dec 18, 2019 at 12:04 PM Ben Dooks (Codethink)
<ben.dooks@codethink.co.uk> wrote:
> The functions should have __iomem on the register pointer
> so add that to silence the following sparse warnings:
>
> drivers/pinctrl/tegra/pinctrl-tegra.c:657:22: warning: incorrect type in assignment (different address spaces)
> drivers/pinctrl/tegra/pinctrl-tegra.c:657:22: expected unsigned int [usertype] *regs
> drivers/pinctrl/tegra/pinctrl-tegra.c:657:22: got void [noderef] <asn:2> *
> drivers/pinctrl/tegra/pinctrl-tegra.c:659:42: warning: incorrect type in argument 1 (different address spaces)
> drivers/pinctrl/tegra/pinctrl-tegra.c:659:42: expected void const volatile [noderef] <asn:2> *addr
> drivers/pinctrl/tegra/pinctrl-tegra.c:659:42: got unsigned int [usertype] *
> drivers/pinctrl/tegra/pinctrl-tegra.c:675:22: warning: incorrect type in assignment (different address spaces)
> drivers/pinctrl/tegra/pinctrl-tegra.c:675:22: expected unsigned int [usertype] *regs
> drivers/pinctrl/tegra/pinctrl-tegra.c:675:22: got void [noderef] <asn:2> *
> drivers/pinctrl/tegra/pinctrl-tegra.c:677:25: warning: incorrect type in argument 2 (different address spaces)
> drivers/pinctrl/tegra/pinctrl-tegra.c:677:25: expected void volatile [noderef] <asn:2> *addr
> drivers/pinctrl/tegra/pinctrl-tegra.c:677:25: got unsigned int [usertype] *
>
> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
> ---
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Jonathan Hunter <jonathanh@nvidia.com>
> Cc: Dmitry Osipenko <digetx@gmail.com>
> Cc: linux-gpio@vger.kernel.org
> Cc: linux-tegra@vger.kernel.org
Patch applied with the ACKs.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-01-07 8:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-18 11:04 [PATCH] pinctrl: tegra: fix missing __iomem in suspend/resume Ben Dooks (Codethink)
2019-12-18 13:05 ` Dmitry Osipenko
2019-12-19 13:02 ` Thierry Reding
2020-01-06 23:00 ` Linus Walleij
2020-01-07 8:13 ` Ben Dooks
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).