From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Lubomir Rintel <lkundrak@v3.sk>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio <linux-gpio@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpio: pxa: Avoid a warning when gpio0 and gpio1 IRQS are not there
Date: Wed, 05 Feb 2020 18:57:00 +0100 [thread overview]
Message-ID: <87ftfo29zn.fsf@belgarion.home> (raw)
In-Reply-To: <CAMpxmJUPcackGYLfX83TT1V9x2=iHgnw3cZ=KufuHn9FeKOn_A@mail.gmail.com> (Bartosz Golaszewski's message of "Tue, 4 Feb 2020 11:13:44 +0100")
Bartosz Golaszewski <bgolaszewski@baylibre.com> writes:
> wt., 28 sty 2020 o 22:08 Lubomir Rintel <lkundrak@v3.sk> napisał(a):
>>
>> Not all platforms use those. Let's use
>> platform_get_irq_byname_optional() instead platform_get_irq_byname() so
>> that we avoid a useless warning:
>>
>> [ 1.359455] pxa-gpio d4019000.gpio: IRQ gpio0 not found
>> [ 1.359583] pxa-gpio d4019000.gpio: IRQ gpio1 not found
>>
>> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Okay, what would have really be nice in the commit message was to state _which_
platform doesn't use these, and still use pxa-gpio as their gpio driver.
Cheers.
--
Robert
PS: And yes, my response is late, but I'm moving house so my ping is huge
lately.
prev parent reply other threads:[~2020-02-05 17:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 21:08 [PATCH] gpio: pxa: Avoid a warning when gpio0 and gpio1 IRQS are not there Lubomir Rintel
2020-02-04 10:13 ` Bartosz Golaszewski
2020-02-05 17:57 ` Robert Jarzmik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftfo29zn.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkundrak@v3.sk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox