From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAD73C6FA8B for ; Thu, 22 Sep 2022 09:17:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230209AbiIVJRh (ORCPT ); Thu, 22 Sep 2022 05:17:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229712AbiIVJRf (ORCPT ); Thu, 22 Sep 2022 05:17:35 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D510CD01F4; Thu, 22 Sep 2022 02:17:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7D13062037; Thu, 22 Sep 2022 09:17:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9523C433D6; Thu, 22 Sep 2022 09:17:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663838252; bh=d1bj7NoeTwC6Lx1X6ziK4AjlLmrJTJF3DowJifqcCQU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RHI5RGFM6qUtx37r6c7rLN6MLed7Ik1JQTz9m3PJofNEzF2DAwU0hcI01f2NUSdSC GvItCD7JOVPSJVDIC3e5kXSNkypHxsukpxraCXkHiBHRXPRTw9MPp3lWYqf7Q5jKqe Ab23otJcEN/ndZh+i+cMF/XeBiAjUda2SXAM1GjDiUjiofNkfkMx9QqKEMq3JUdbQO B3ILg6+kLcd31gfVfLB1P2hnD6z/qXy1UJNpXXZRGbx/KmR3qgzz8Fb+t2t2q4ZNmy YqKYWzT/GAYVgylB4SD/vvFD+qF9kGGKo1G8hfNQ4DyjPdRU+ea3f6Xv0erXy5GRff ENnd409EbgWQA== Received: from 185-176-101-241.host.sccbroadband.ie ([185.176.101.241] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1obIKo-00Br7c-I6; Thu, 22 Sep 2022 10:17:30 +0100 Date: Thu, 22 Sep 2022 10:17:27 +0100 Message-ID: <87illfkbtk.wl-maz@kernel.org> From: Marc Zyngier To: Bartosz Golaszewski Cc: Sasha Levin , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Linus Walleij , linusw@kernel.org, kaloz@openwrt.org, khalasa@piap.pl, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH AUTOSEL 5.4 2/5] gpio: ixp4xx: Make irqchip immutable In-Reply-To: References: <20220921155436.235371-1-sashal@kernel.org> <20220921155436.235371-2-sashal@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.176.101.241 X-SA-Exim-Rcpt-To: brgl@bgdev.pl, sashal@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, linus.walleij@linaro.org, linusw@kernel.org, kaloz@openwrt.org, khalasa@piap.pl, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Bartosz, On Wed, 21 Sep 2022 21:04:27 +0100, Bartosz Golaszewski wrote: > > On Wed, Sep 21, 2022 at 6:57 PM Marc Zyngier wrote: > > > > On 2022-09-21 16:54, Sasha Levin wrote: > > > From: Linus Walleij > > > > > > [ Upstream commit 94e9bc73d85aa6ecfe249e985ff57abe0ab35f34 ] > > > > > > This turns the IXP4xx GPIO irqchip into an immutable > > > irqchip, a bit different from the standard template due > > > to being hierarchical. > > > > > > Tested on the IXP4xx which uses drivers/ata/pata_ixp4xx_cf.c > > > for a rootfs on compact flash with IRQs from this GPIO > > > block to the CF ATA controller. > > > > > > Cc: Marc Zyngier > > > Signed-off-by: Linus Walleij > > > Acked-by: Marc Zyngier > > > Signed-off-by: Bartosz Golaszewski > > > Signed-off-by: Sasha Levin > > > > Why? The required dependencies are only in 5,19, and are > > definitely NOT a stable candidate... > > > > This isn't a fix by any stretch of the imagination. > > > > Hi Marc, > > While I didn't mark it for stable (and it shouldn't go into any branch > earlier than 5.19.x), I did send the patches making the irqchips > immutable to Linus Torvalds as fixes as they technically do *fix* the > warning emitted by gpiolib and make the implementation correct. > > I think these patches should still be part of the v5.19.x stable branch. 5.19, sure. All the dependencies are there, and tightening the driver implementations is a valuable goal. However, targeting all the other stable releases (5.4, 5.10, 5.15) makes little sense. It won't even compile! Do the dependencies need to be backported? I don't think it is worthwhile, as this is a long series containing multiple related changes spread all over the tree. This would defeat the very purpose of a stable tree. M. -- Without deviation from the norm, progress is not possible.