From: Marc Zyngier <maz@kernel.org>
To: Michael Walle <michael@walle.cc>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] genirq: allow irq_set_chip_handler_name_locked() to take a const irq_chip
Date: Mon, 11 Jul 2022 10:11:51 +0100 [thread overview]
Message-ID: <87k08kko88.wl-maz@kernel.org> (raw)
In-Reply-To: <20220706151553.1580790-1-michael@walle.cc>
On Wed, 06 Jul 2022 16:15:52 +0100,
Michael Walle <michael@walle.cc> wrote:
>
> Similar to commit 393e1280f765 ("genirq: Allow irq_chip registration
> functions to take a const irq_chip"), allow the
> irq_set_chip_handler_name_locked() function to take a const irq_chip
> argument.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
> Given this is the correct approach, can this go through the pinctrl tree?
> Of not, do we need an immutable tag?
I'd prefer this sort of change went into the IRQ tree, as it
potentially has a wide ranging effect, and that the rest of these
changes went via the IRQ tree too. It makes it easy to take the branch
down if something goes wrong.
Given that I already do carry a bunch of GPIO related patches, I'm
happy to add that to the mix if Linus ack the second patch.
The change itself looks good to me.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2022-07-11 9:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 15:15 [PATCH 1/2] genirq: allow irq_set_chip_handler_name_locked() to take a const irq_chip Michael Walle
2022-07-06 15:15 ` [PATCH 2/2] pinctrl: ocelot: make irq_chip immutable Michael Walle
2022-07-11 12:13 ` Linus Walleij
2022-07-11 9:11 ` Marc Zyngier [this message]
2022-07-11 12:14 ` [PATCH 1/2] genirq: allow irq_set_chip_handler_name_locked() to take a const irq_chip Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k08kko88.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).