From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [RFC 01/23] gpio/omap: raw read and write endian fix Date: Tue, 19 Nov 2013 10:12:55 -0800 Message-ID: <87mwl0mfa0.fsf@linaro.org> References: <1384560086-11994-1-git-send-email-taras.kondratiuk@linaro.org> <1384560086-11994-2-git-send-email-taras.kondratiuk@linaro.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: (Linus Walleij's message of "Tue, 19 Nov 2013 10:29:02 +0100") Sender: linux-omap-owner@vger.kernel.org To: Linus Walleij Cc: Taras Kondratiuk , ext Tony Lindgren , Javier Martinez Canillas , Linux-OMAP , linaro-networking@linaro.org, Victor Kamensky , Santosh Shilimkar , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-Id: linux-gpio@vger.kernel.org Linus Walleij writes: > On Sat, Nov 16, 2013 at 1:01 AM, Taras Kondratiuk > wrote: > >> From: Victor Kamensky >> >> All OMAP IP blocks expect LE data, but CPU may operate in BE mode. >> Need to use endian neutral functions to read/write h/w registers. >> I.e instead of __raw_read[lw] and __raw_write[lw] functions code >> need to use read[lw]_relaxed and write[lw]_relaxed functions. >> If the first simply reads/writes register, the second will byteswap >> it if host operates in BE mode. >> >> Changes are trivial sed like replacement of __raw_xxx functions >> with xxx_relaxed variant. >> >> Signed-off-by: Victor Kamensky >> Signed-off-by: Taras Kondratiuk > > Since I generally just dislike __raw accessors I went and applied > this. If it collides with any of Tony's fixup work I might need to > take the patch out again, no big deal. > > Some ACKs would be nice, but unless there are major objections > this stays merged. Acked-by: Kevin Hilman