From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5487C07E9D for ; Mon, 26 Sep 2022 09:40:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234745AbiIZJkX (ORCPT ); Mon, 26 Sep 2022 05:40:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230168AbiIZJi5 (ORCPT ); Mon, 26 Sep 2022 05:38:57 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C01B46212 for ; Mon, 26 Sep 2022 02:37:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D83E9B8077E for ; Mon, 26 Sep 2022 09:37:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65A2BC433C1; Mon, 26 Sep 2022 09:37:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664185044; bh=myLg/+yBNo49I0qu9pqWpDHrYtREw45W9UxBPzey06E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YCeDUZgE3LxNP920W1d49rQ9Jsbm1sG292UWj7yEPdF446HWhQGkHSHB3XV13ZjXS prG9Ce4i7Uy8+5dhDPtucolB1jNAloDYcKeFaafV58soPKUH6N1FUXfZEZWQ7VW0rD diVZ8FtmPSz9P66n4+ab0GcKRgr3lA5qI7rx0ogsl6iCWiADovYVM0z1cHcgx/GmSs EjFobt/kyGretdwrFdO1YvAy7mPLTLE1meTDHYZ7O3IL1+stuP2Dji46yj0LVg37Sy USPPvkC99rOXzoVDIpd60CL/hgllqclm0hIhWZeoYPil9MehuqLoKBsH/7ebJtmeSA nmlF46ZTM8wjA== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ockYE-00CcBm-3t; Mon, 26 Sep 2022 10:37:22 +0100 Date: Mon, 26 Sep 2022 10:37:21 +0100 Message-ID: <87sfkeo4ry.wl-maz@kernel.org> From: Marc Zyngier To: Linus Walleij Cc: linux-gpio@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH] gpio: tc3589x: Make irqchip immutable In-Reply-To: <20220926093047.1699027-1-linus.walleij@linaro.org> References: <20220926093047.1699027-1-linus.walleij@linaro.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: linus.walleij@linaro.org, linux-gpio@vger.kernel.org, brgl@bgdev.pl X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, 26 Sep 2022 10:30:47 +0100, Linus Walleij wrote: > > This turns the Toshiba tc3589x gpio irqchip immutable. > > Cc: Marc Zyngier > Signed-off-by: Linus Walleij > --- > drivers/gpio/gpio-tc3589x.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpio-tc3589x.c b/drivers/gpio/gpio-tc3589x.c > index 443fe975bf13..f9edb720710a 100644 > --- a/drivers/gpio/gpio-tc3589x.c > +++ b/drivers/gpio/gpio-tc3589x.c > @@ -244,13 +244,15 @@ static void tc3589x_gpio_irq_unmask(struct irq_data *d) > tc3589x_gpio->regs[REG_DIRECT][regoffset] &= ~mask; > } > > -static struct irq_chip tc3589x_gpio_irq_chip = { > +static const struct irq_chip tc3589x_gpio_irq_chip = { > .name = "tc3589x-gpio", > .irq_bus_lock = tc3589x_gpio_irq_lock, > .irq_bus_sync_unlock = tc3589x_gpio_irq_sync_unlock, > .irq_mask = tc3589x_gpio_irq_mask, > .irq_unmask = tc3589x_gpio_irq_unmask, Don't you need to update these two methods with the callbacks into the gpiolib core code? Thanks, M. -- Without deviation from the norm, progress is not possible.