From: Thomas Gleixner <tglx@linutronix.de>
To: Richard Fitzgerald <rf@opensource.cirrus.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Yan Zhen <yanzhen@vivo.com>
Cc: linus.walleij@linaro.org, linux-sound@vger.kernel.org,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, opensource.kernel@vivo.com
Subject: Re: [PATCH v1] cirrus: Simplify with dev_err_probe()
Date: Wed, 28 Aug 2024 20:12:32 +0200 [thread overview]
Message-ID: <87ttf4bjov.ffs@tglx> (raw)
In-Reply-To: <9b5a3025-3e78-44b9-98f5-c945a6ac48d7@opensource.cirrus.com>
On Wed, Aug 28 2024 at 15:59, Richard Fitzgerald wrote:
> On 28/08/2024 15:47, Thomas Gleixner wrote:
>> On Wed, Aug 28 2024 at 13:27, Charles Keepax wrote:
>>> Since we are doing a respin anyway also the brackets on the if
>>> should be dropped on both of these as well.
>>
>> No. https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#bracket-rules
>
> https://www.kernel.org/doc/html/latest/process/coding-style.html#codingstyle
>
> does not say that. It says:
>
> "Do not unnecessarily use braces where a single statement will do."
>
> Note: single statement, not single line.
>
> coding-style.rst is the coding style. If you disagree with the coding
> style, send a patch to change coding-style.rst.
There will never be an agreement about this, but for code which I
maintain and goes through the tip tree, the single line rule applies
simply because it's my time wasted when I can't parse code fluently.
Thanks,
tglx
prev parent reply other threads:[~2024-08-28 18:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 12:01 [PATCH v1] cirrus: Simplify with dev_err_probe() Yan Zhen
2024-08-28 12:08 ` Richard Fitzgerald
2024-08-28 12:27 ` Charles Keepax
2024-08-28 14:47 ` Thomas Gleixner
2024-08-28 14:59 ` Richard Fitzgerald
2024-08-28 16:11 ` Charles Keepax
2024-08-28 18:12 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttf4bjov.ffs@tglx \
--to=tglx@linutronix.de \
--cc=ckeepax@opensource.cirrus.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
--cc=yanzhen@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).