From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5966C433EF for ; Thu, 7 Jul 2022 13:03:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234977AbiGGNDM (ORCPT ); Thu, 7 Jul 2022 09:03:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234399AbiGGNDL (ORCPT ); Thu, 7 Jul 2022 09:03:11 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD53915A0B for ; Thu, 7 Jul 2022 06:03:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5AFFCB82174 for ; Thu, 7 Jul 2022 13:03:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C963C3411E; Thu, 7 Jul 2022 13:03:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657198988; bh=JvrQgePcTuXPghLJ1pZjiTFoMYlCaBLNdQQR08PnrwY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mG+vIaT0UroIiain+ca1XKfgbsxLHSGz/rPZYS//Q7gsGCaPhpY9SmMIEXXpPNL/6 FbQ5ydYbRrKWC44M8QRH2V5ASYbXAMvHcUaHkW5kjQbXEuaM4+RUoqgfmVxysEBmn3 +HlHJrkzHW+1kvErFAPql6iP10ZT9Pz5NEfHUVBzbCNB1m9Kyw7rgsKq4EoHYngPFz 4ZwkwGEllGeVYSNeO9Qmf6NxFS/Bt0bKgvptGLr8v8jeW1jHekRAsqL1WOjBPgc4Sq 2TFdURjhLW2LIhaO7W5Jmha3URpjHiYuqjSOUgEsysLBlnm2KC+UIbnGSU366odso8 aX+alHmCeaolw== Received: from [185.201.63.253] (helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1o9R9t-005v8C-OG; Thu, 07 Jul 2022 14:03:06 +0100 Date: Thu, 07 Jul 2022 14:03:04 +0100 Message-ID: <87wncpkrcn.wl-maz@kernel.org> From: Marc Zyngier To: kernel test robot , lewis.hanly@microchip.com Cc: linux-gpio@vger.kernel.org, linux-riscv@lists.infradead.org, palmer@dabbelt.com, kbuild-all@lists.01.org, paul.walmsley@sifive.com, conor.dooley@microchip.com, daire.mcnamara@microchip.com Subject: Re: [PATCH 1/1] gpio: mpfs - add polarfire soc gpio support In-Reply-To: <202207071219.0Jw0owWG-lkp@intel.com> References: <20220705134912.2740421-2-lewis.hanly@microchip.com> <202207071219.0Jw0owWG-lkp@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.201.63.253 X-SA-Exim-Rcpt-To: lkp@intel.com, lewis.hanly@microchip.com, linux-gpio@vger.kernel.org, linux-riscv@lists.infradead.org, palmer@dabbelt.com, kbuild-all@lists.01.org, paul.walmsley@sifive.com, conor.dooley@microchip.com, daire.mcnamara@microchip.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, 07 Jul 2022 05:46:44 +0100, kernel test robot wrote: > > Hi, > > I love your patch! Yet something to improve: > > [auto build test ERROR on brgl/gpio/for-next] > [also build test ERROR on linus/master v5.19-rc5 next-20220706] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/lewis-hanly-microchip-com/Add-Polarfire-SoC-GPIO-support/20220705-220421 > base: https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git gpio/for-next > config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220707/202207071219.0Jw0owWG-lkp@intel.com/config) > compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 > reproduce (this is a W=1 build): > # https://github.com/intel-lab-lkp/linux/commit/f1c1cf42734c00cf02babb6220f8b68a62e86d0e > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review lewis-hanly-microchip-com/Add-Polarfire-SoC-GPIO-support/20220705-220421 > git checkout f1c1cf42734c00cf02babb6220f8b68a62e86d0e > # save the config file > mkdir build_dir && cp config build_dir/.config > make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/ > > If you fix the issue, kindly add following tag where applicable > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > drivers/gpio/gpio-mpfs.c: In function 'mpfs_gpio_probe': > >> drivers/gpio/gpio-mpfs.c:290:20: error: 'struct irq_chip' has no member named 'parent_device' > 290 | irq_c->chip->parent_device = dev; > | ^~ > >> drivers/gpio/gpio-mpfs.c:310:23: error: implicit declaration of function 'devm_request_irq'; did you mean 'can_request_irq'? [-Werror=implicit-function-declaration] > 310 | ret = devm_request_irq(&pdev->dev, irq, I missed this in my initial eyeballing of this patch. This should implement a chained interrupt flow, and not request the mux interrupt directly. That's yet another level of brokenness in this driver. M. -- Without deviation from the norm, progress is not possible.