From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89FE8C433F5 for ; Thu, 28 Apr 2022 16:05:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231214AbiD1QJH (ORCPT ); Thu, 28 Apr 2022 12:09:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231436AbiD1QJD (ORCPT ); Thu, 28 Apr 2022 12:09:03 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0780F3FBD8; Thu, 28 Apr 2022 09:05:49 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B0E95B82E55; Thu, 28 Apr 2022 16:05:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 666C2C385BC; Thu, 28 Apr 2022 16:05:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651161946; bh=zt+2RHZTO8PYIBtP/S9mAvPkCgdnEyn8Rsfetb+4I6w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oHkM6bzRpNq4LlUt4QZq4aZObC6h7ok8nKYDPceO+xM1J5OtHlFoXgnOf587gplmw bHVhR75AbiZOKP2c8rnvJH/8uFkDifnYVWIyDgQbTG/dpHMaHLVU2AT2+GLKK+JDgj 1DI+XiNOpxM3AejPNjfkLyU+TWq0L/8lbmSUT6yaY0oYnm7TL5u0Vpl2s9yawMLMGY 7EpdsePBXO3NuhV6BNXG+o3V33Z5kRfEJkNW4MHynCQoi62sZR8xh6JYIGT01YmnEH NlQHsdNAaYoIHdSP1WGZ0zeg0J3d/ZzRjMg8M8XiBd9LTHZHXC+gPt8AL9iwUa7b1W ztqp/bSLUB9Mw== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nk6eF-007ijl-Pw; Thu, 28 Apr 2022 17:05:44 +0100 Date: Thu, 28 Apr 2022 17:05:43 +0100 Message-ID: <87wnf98a7c.wl-maz@kernel.org> From: Marc Zyngier To: Michael Walle Cc: Lars Povlsen , Steen Hegelund , Linus Walleij , UNGLinuxDriver@microchip.com, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pinctrl: microchip-sgpio: make irq_chip immutable In-Reply-To: <20220428111622.1395831-1-michael@walle.cc> References: <20220428111622.1395831-1-michael@walle.cc> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: michael@walle.cc, lars.povlsen@microchip.com, Steen.Hegelund@microchip.com, linus.walleij@linaro.org, UNGLinuxDriver@microchip.com, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, 28 Apr 2022 12:16:22 +0100, Michael Walle wrote: > > Since recently, the kernel is nagging about mutable irq_chips: > > [ 4.967050] gpio gpiochip1: (e2004190.gpio-input): not an immutable chip, please consider fixing it! > > Drop the unneeded copy, flag it as IRQCHIP_IMMUTABLE, add the new > helper functions and call the appropriate gpiolib functions. > > Signed-off-by: Michael Walle FWIW: Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.