From: Marc Zyngier <maz@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Thierry Reding <treding@nvidia.com>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <brgl@bgdev.pl>,
Andy Shevchenko <andy@kernel.org>
Subject: Re: [PATCH v1 1/1] gpiolib: Drop unused domain_ops memeber of GPIO IRQ chip
Date: Sat, 17 Jun 2023 11:23:17 +0100 [thread overview]
Message-ID: <87y1kipeui.wl-maz@kernel.org> (raw)
In-Reply-To: <CACRpkdbPEvVvaehB521gdjkkzh+wFnFxsCNm36PD-hnTb1Na_w@mail.gmail.com>
On Sat, 17 Jun 2023 10:08:10 +0100,
Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Fri, Jun 16, 2023 at 3:53 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
>
> > It seems there is no driver that requires custom IRQ chip
> > domain options. Drop the member and respective code.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> (...)
> > - /* Some drivers provide custom irqdomain ops */
> > gc->irq.domain = irq_domain_create_simple(fwnode,
> > gc->ngpio,
> > gc->irq.first,
> > - gc->irq.domain_ops ?: &gpiochip_domain_ops,
> > + &gpiochip_domain_ops,
>
> We better run this by Marc Zyngier, and Thierry who introduced it.
>
> But some grepping and looking seems to conclude you are righ!
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
No objection from my end. If this is unused, let's kill it.
Acked-by: Marc Zyngier <maz@kernel.org>
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2023-06-17 10:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 13:53 [PATCH v1 1/1] gpiolib: Drop unused domain_ops memeber of GPIO IRQ chip Andy Shevchenko
2023-06-17 9:08 ` Linus Walleij
2023-06-17 10:23 ` Marc Zyngier [this message]
2023-06-19 10:41 ` Andy Shevchenko
2023-06-19 13:01 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1kipeui.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).