[PATCH v1 1/1] gpiolib: Drop unused domain_ops memeber of GPIO IRQ chip

[PATCH v1 1/1] gpiolib: Drop unused domain_ops memeber of GPIO IRQ chip

[Andy Shevchenko]

It seems there is no driver that requires custom IRQ chip
domain options. Drop the member and respective code.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpio/gpiolib.c      | 3 +--
 include/linux/gpio/driver.h | 7 -------
 2 files changed, 1 insertion(+), 9 deletions(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 5fb64c7d7473..4b404beddcf2 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1668,11 +1668,10 @@ static int gpiochip_add_irqchip(struct gpio_chip *gc,
 		if (ret)
 			return ret;
 	} else {
-		/* Some drivers provide custom irqdomain ops */
 		gc->irq.domain = irq_domain_create_simple(fwnode,
 			gc->ngpio,
 			gc->irq.first,
-			gc->irq.domain_ops ?: &gpiochip_domain_ops,
+			&gpiochip_domain_ops,
 			gc);
 		if (!gc->irq.domain)
 			return -EINVAL;
diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
index 5c6db5533be6..6879b5436480 100644
--- a/include/linux/gpio/driver.h
+++ b/include/linux/gpio/driver.h
@@ -61,13 +61,6 @@ struct gpio_irq_chip {
 	 */
 	struct irq_domain *domain;
 
-	/**
-	 * @domain_ops:
-	 *
-	 * Table of interrupt domain operations for this IRQ chip.
-	 */
-	const struct irq_domain_ops *domain_ops;
-
 #ifdef CONFIG_IRQ_DOMAIN_HIERARCHY
 	/**
 	 * @fwnode:
-- 
2.40.0.1.gaa8946217a0b

Re: [PATCH v1 1/1] gpiolib: Drop unused domain_ops memeber of GPIO IRQ chip

[Linus Walleij]

On Fri, Jun 16, 2023 at 3:53 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:

> It seems there is no driver that requires custom IRQ chip
> domain options. Drop the member and respective code.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
(...)
> -               /* Some drivers provide custom irqdomain ops */
>                 gc->irq.domain = irq_domain_create_simple(fwnode,
>                         gc->ngpio,
>                         gc->irq.first,
> -                       gc->irq.domain_ops ?: &gpiochip_domain_ops,
> +                       &gpiochip_domain_ops,

We better run this by Marc Zyngier, and Thierry who introduced it.

But some grepping and looking seems to conclude you are righ!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

Re: [PATCH v1 1/1] gpiolib: Drop unused domain_ops memeber of GPIO IRQ chip

[Marc Zyngier]

On Sat, 17 Jun 2023 10:08:10 +0100,
Linus Walleij <linus.walleij@linaro.org> wrote:
> 
> On Fri, Jun 16, 2023 at 3:53 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> 
> > It seems there is no driver that requires custom IRQ chip
> > domain options. Drop the member and respective code.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> (...)
> > -               /* Some drivers provide custom irqdomain ops */
> >                 gc->irq.domain = irq_domain_create_simple(fwnode,
> >                         gc->ngpio,
> >                         gc->irq.first,
> > -                       gc->irq.domain_ops ?: &gpiochip_domain_ops,
> > +                       &gpiochip_domain_ops,
> 
> We better run this by Marc Zyngier, and Thierry who introduced it.
> 
> But some grepping and looking seems to conclude you are righ!
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

No objection from my end. If this is unused, let's kill it.

Acked-by: Marc Zyngier <maz@kernel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.

Re: [PATCH v1 1/1] gpiolib: Drop unused domain_ops memeber of GPIO IRQ chip

[Andy Shevchenko]

On Sat, Jun 17, 2023 at 11:23:17AM +0100, Marc Zyngier wrote:
> On Sat, 17 Jun 2023 10:08:10 +0100,
> Linus Walleij <linus.walleij@linaro.org> wrote:
> > On Fri, Jun 16, 2023 at 3:53 PM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:

(...)

> > > -               /* Some drivers provide custom irqdomain ops */
> > >                 gc->irq.domain = irq_domain_create_simple(fwnode,
> > >                         gc->ngpio,
> > >                         gc->irq.first,
> > > -                       gc->irq.domain_ops ?: &gpiochip_domain_ops,
> > > +                       &gpiochip_domain_ops,
> > 
> > We better run this by Marc Zyngier, and Thierry who introduced it.
> > 
> > But some grepping and looking seems to conclude you are righ!
> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> No objection from my end. If this is unused, let's kill it.

Grepping by two independent people and so far no complains from CI, I believe
the patch tells truth.

> Acked-by: Marc Zyngier <maz@kernel.org>

Thank you!

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/1] gpiolib: Drop unused domain_ops memeber of GPIO IRQ chip

[Bartosz Golaszewski]

On Fri, Jun 16, 2023 at 3:53 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> It seems there is no driver that requires custom IRQ chip
> domain options. Drop the member and respective code.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---

Applied, thanks!

Bart