From: Michael Walle <michael@walle.cc>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH 3/8] gpio: GPIO_REGMAP: select REGMAP instead of depending on it
Date: Sun, 26 Feb 2023 19:06:01 +0100 [thread overview]
Message-ID: <8846de19ead73575ad4f1f0d9f731405@walle.cc> (raw)
In-Reply-To: <20230226053953.4681-4-rdunlap@infradead.org>
Am 2023-02-26 06:39, schrieb Randy Dunlap:
> REGMAP is a hidden (not user visible) symbol. Users cannot set it
> directly thru "make *config", so drivers should select it instead of
> depending on it if they need it.
>
> Consistently using "select" or "depends on" can also help reduce
> Kconfig circular dependency issues.
>
> Therefore, change the use of "depends on REGMAP" to "select REGMAP".
>
> Fixes: ebe363197e52 ("gpio: add a reusable generic gpio_chip using
> regmap")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Michael Walle <michael@walle.cc>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Bartosz Golaszewski <brgl@bgdev.pl>
> Cc: linux-gpio@vger.kernel.org
Acked-by: Michael Walle <michael@walle.cc>
Thanks,
-michael
next prev parent reply other threads:[~2023-02-26 18:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-26 5:39 [PATCH 0/8] drivers: select REGMAP instead of depending on it Randy Dunlap
2023-02-26 5:39 ` [PATCH 3/8] gpio: GPIO_REGMAP: " Randy Dunlap
2023-02-26 18:06 ` Michael Walle [this message]
2023-03-06 10:17 ` Bartosz Golaszewski
2023-02-27 9:31 ` [PATCH 0/8] drivers: " Hans de Goede
2023-02-27 16:07 ` Randy Dunlap
2023-03-01 12:47 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8846de19ead73575ad4f1f0d9f731405@walle.cc \
--to=michael@walle.cc \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).