From: Markus Elfring <Markus.Elfring@web.de>
To: vulab@iscas.ac.cn, linux-gpio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Linus Walleij <linus.walleij@linaro.org>
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: nomadik: Add error handling for find_nmk_gpio_from_pin
Date: Thu, 20 Feb 2025 13:14:59 +0100 [thread overview]
Message-ID: <899f35b2-f4cb-4bea-bcc7-a805a409f7d7@web.de> (raw)
In-Reply-To: <20250220085001.860-1-vulab@iscas.ac.cn>
…
> To fix this, add error handling to check the return value of
> find_nmk_gpio_from_pin. Log an error message indicating an
> invalid pin offset and return -EINVAL immediately If the function
if the function call?
> fails.
failed?
* You may occasionally put more than 66 characters into text lines
of such a change description.
* How do you think about to append parentheses to function names?
Regards,
Markus
next prev parent reply other threads:[~2025-02-20 12:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 8:50 [PATCH] pinctrl: nomadik: Add error handling for find_nmk_gpio_from_pin Wentao Liang
2025-02-20 12:14 ` Markus Elfring [this message]
2025-02-27 20:23 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=899f35b2-f4cb-4bea-bcc7-a805a409f7d7@web.de \
--to=markus.elfring@web.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).