From: Dmitry Yashin <dmt.yashin@gmail.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Jianqun Xu <jay.xu@rock-chips.com>,
Jonas Karlman <jonas@kwiboo.se>,
devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Dmitry Yashin <dmt.yashin@gmail.com>
Subject: Re: [PATCH v3 2/2] pinctrl: rockchip: add rk3308b SoC support
Date: Wed, 5 Jun 2024 17:20:38 +0500 [thread overview]
Message-ID: <8b2f681c-444a-4201-9004-e12b9482d1a7@gmail.com> (raw)
In-Reply-To: <b5d2d914-0c2b-4cd1-b894-f894a93a54f9@moroto.mountain>
Hi Dan,
On 6/5/24 12:22 PM, Dan Carpenter wrote:
> On Tue, Jun 04, 2024 at 07:10:20PM +0500, Dmitry Yashin wrote:
> Why does this one have a Fixes tag? Isn't this new hardware support?
> Possibly patch 1/2 was not actually a fix but just preparation for this
> patch?
>
> regards,
> dan carpenter
Initial pinctrl support for rk3308 included registers for rk3308b variant,
which didn't work well with some pins of the first SoC and these reg's
were fixed in the patch mentioned in the tag. So I added Fixes tag as this
patch brings back proper setup for rk3308b and 1/2 indeed
is the preparation.
Thank you for taking your time on it. Perhaps I should describe such
moments better next time.
(resend without broken new line sorry)
--
Thanks,
Dmitry
prev parent reply other threads:[~2024-06-05 12:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 14:10 [PATCH v3 0/2] pinctrl: rockchip: add rk3308b SoC support Dmitry Yashin
2024-06-04 14:10 ` [PATCH v3 1/2] pinctrl: rockchip: delay recalced_mask and route_mask init Dmitry Yashin
2024-06-05 7:09 ` Dan Carpenter
2024-06-04 14:10 ` [PATCH v3 2/2] pinctrl: rockchip: add rk3308b SoC support Dmitry Yashin
2024-06-05 7:22 ` Dan Carpenter
2024-06-05 12:06 ` Dmitry Yashin
2024-06-05 12:20 ` Dmitry Yashin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b2f681c-444a-4201-9004-e12b9482d1a7@gmail.com \
--to=dmt.yashin@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jay.xu@rock-chips.com \
--cc=jonas@kwiboo.se \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=luca.ceresoli@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox