From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Tengfei Fan <quic_tengfan@quicinc.com>,
andersson@kernel.org, konrad.dybcio@linaro.org,
linus.walleij@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@quicinc.com
Subject: Re: [PATCH 1/2] dt-bindings: pinctrl: qcom: modify the wrong compatible name
Date: Wed, 24 Jan 2024 09:46:26 +0100 [thread overview]
Message-ID: <8b730cb5-871f-47b8-9abd-d8f39d3b8ec6@linaro.org> (raw)
In-Reply-To: <CAA8EJpqXS97FXoTwiLaSeHHEDOeBFRPRbCNR6WF-ArDm22tu-Q@mail.gmail.com>
On 24/01/2024 09:07, Dmitry Baryshkov wrote:
> On Wed, 24 Jan 2024 at 08:38, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 24/01/2024 03:33, Tengfei Fan wrote:
>>> Use right compatible name "qcom,sm4450-tlmm" instead of
>>> "qcom,sm4450-pinctrl".
>>
>> Why do you claim this one is right and other is wrong? Provide
>> arguments. To me the compatible looks correct.
>
> Yeah, but the driver (and the dtsi) use -tlmm
Are they merged? If so, it would be the argument for the commit msg.
Just provide some rationale why this is done this way, not the other
(fixing driver and DTS).
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-24 8:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 2:33 [PATCH 0/2] dt-bindings: pinctrl: qcom: update SM4450 pinctrl Tengfei Fan
2024-01-24 2:33 ` [PATCH 1/2] dt-bindings: pinctrl: qcom: modify the wrong compatible name Tengfei Fan
2024-01-24 3:33 ` Dmitry Baryshkov
2024-01-25 1:18 ` Tengfei Fan
2024-01-25 1:20 ` Dmitry Baryshkov
2024-01-25 1:35 ` Tengfei Fan
2024-01-24 6:38 ` Krzysztof Kozlowski
2024-01-24 8:07 ` Dmitry Baryshkov
2024-01-24 8:46 ` Krzysztof Kozlowski [this message]
2024-01-25 1:27 ` Tengfei Fan
2024-01-24 2:33 ` [PATCH 2/2] dt-bindings: pinctrl: qcom: consolidate functions Tengfei Fan
2024-01-24 3:34 ` Dmitry Baryshkov
2024-01-25 1:37 ` Tengfei Fan
2024-01-24 3:39 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b730cb5-871f-47b8-9abd-d8f39d3b8ec6@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=kernel@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_tengfan@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).