From: Michael Walle <michael@walle.cc>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Matti Vaittinen <mazziesaccount@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-power <linux-power@fi.rohmeurope.com>
Subject: Re: [PATCH v2 1/3] gpio: regmap: Support few IC specific operations
Date: Fri, 21 May 2021 12:19:29 +0200 [thread overview]
Message-ID: <8c048bda0ace591d7e91c07ed9155338@walle.cc> (raw)
In-Reply-To: <CAHp75VcZwYdA5R=peC+8jHVT6UDsAT9msSs=W6C7rgfyjGPtXA@mail.gmail.com>
Am 2021-05-21 12:09, schrieb Andy Shevchenko:
> On Fri, May 21, 2021 at 12:53 PM Matti Vaittinen
> <matti.vaittinen@fi.rohmeurope.com> wrote:
>> Changelog v2: (based on suggestions by Michael Walle)
>> - drop gpio_regmap_set_drvdata()
>
> But why do we have gpio_regmap_get_drvdata() and why is it different
> now to the new member handling?
Eg. the reg_mask_xlate() callback is just passed a "struct
gpio_regmap*".
If someone needs to access private data there, gpio_regmap_get_drvdata()
is used. At least that was its intention.
Thus I was also suggesting to use "struct gpio_regmap*" in the newer
callbacks.
I don't get what you mean by "different to the new member handling"?
-michael
next prev parent reply other threads:[~2021-05-21 10:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 6:27 [PATCH v2 0/3] gpio: gpio-regmap: Support few custom operations Matti Vaittinen
2021-05-21 6:27 ` [PATCH v2 1/3] gpio: regmap: Support few IC specific operations Matti Vaittinen
2021-05-21 8:04 ` Michael Walle
2021-05-21 10:09 ` Andy Shevchenko
2021-05-21 10:19 ` Michael Walle [this message]
2021-05-21 10:25 ` Vaittinen, Matti
2021-05-21 10:46 ` Michael Walle
2021-05-21 11:36 ` Vaittinen, Matti
2021-05-21 11:19 ` Andy Shevchenko
2021-05-21 11:41 ` Vaittinen, Matti
2021-05-21 10:20 ` Vaittinen, Matti
2021-05-21 6:28 ` [PATCH v2 2/3] gpio: gpio-regmap: Use devm_add_action() Matti Vaittinen
2021-05-21 8:10 ` Michael Walle
2021-05-21 8:38 ` Bjørn Mork
2021-05-21 10:30 ` Vaittinen, Matti
2021-05-21 16:35 ` Bartosz Golaszewski
2021-05-24 5:01 ` Vaittinen, Matti
2021-05-21 10:10 ` Andy Shevchenko
2021-05-21 6:29 ` [PATCH v2 3/3] gpio: bd71815: Use gpio-regmap Matti Vaittinen
2021-05-21 10:12 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c048bda0ace591d7e91c07ed9155338@walle.cc \
--to=michael@walle.cc \
--cc=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-power@fi.rohmeurope.com \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox