From: Krzysztof Kozlowski <krzk@kernel.org>
To: Esteban Blanc <eblanc@baylibre.com>, linus.walleij@linaro.org
Cc: andy.shevchenko@gmail.com, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, jpanis@baylibre.com,
jneanne@baylibre.com, u-kumar1@ti.com
Subject: Re: [PATCH v8] pinctrl: tps6594: Add driver for TPS6594 pinctrl and GPIOs
Date: Fri, 3 Nov 2023 07:53:56 +0100 [thread overview]
Message-ID: <8cefc3d6-5d7b-4695-b1db-143f7124f5fe@kernel.org> (raw)
In-Reply-To: <20231102101357.977886-1-eblanc@baylibre.com>
On 02/11/2023 11:13, Esteban Blanc wrote:
> TI TPS6594 PMIC has 11 GPIOs which can be used
> for different functions.
>
> This patch adds a pinctrl and GPIO drivers in
> order to use those functions.
>
> Signed-off-by: Esteban Blanc <eblanc@baylibre.com>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
...
> +
> +static struct platform_driver tps6594_pinctrl_driver = {
> + .probe = tps6594_pinctrl_probe,
> + .driver = {
> + .name = "tps6594-pinctrl",
> + },
> +};
> +module_platform_driver(tps6594_pinctrl_driver);
> +
> +MODULE_ALIAS("platform:tps6594-pinctrl");
Since kbuild reports build error (which is surprise for v8...), drop
also MODULE_ALIAS and use proper ID table.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-11-03 6:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 10:13 [PATCH v8] pinctrl: tps6594: Add driver for TPS6594 pinctrl and GPIOs Esteban Blanc
2023-11-02 15:58 ` Andy Shevchenko
2023-11-03 4:43 ` kernel test robot
2023-11-14 13:31 ` Linus Walleij
2023-11-03 6:53 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cefc3d6-5d7b-4695-b1db-143f7124f5fe@kernel.org \
--to=krzk@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=eblanc@baylibre.com \
--cc=jneanne@baylibre.com \
--cc=jpanis@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=u-kumar1@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).