From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Johan Hovold <johan@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Johan Hovold <johan+linaro@kernel.org>,
Lee Jones <lee@kernel.org>, Mark Brown <broonie@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Das Srinagesh <quic_gurus@quicinc.com>,
Satya Priya <quic_c_skakit@quicinc.com>,
Stephen Boyd <swboyd@chromium.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 12/13] regulator: add pm8008 pmic regulator driver
Date: Tue, 7 May 2024 20:14:43 +0200 [thread overview]
Message-ID: <8d2ea17c-f91e-4e14-a239-e5e999f6ac50@linaro.org> (raw)
In-Reply-To: <CAHp75VdUFMvkj-r76H7GFZdpcoh_nb8v6CBj4wBHztNhiaWULQ@mail.gmail.com>
On 07/05/2024 19:22, Andy Shevchenko wrote:
> On Tue, May 7, 2024 at 6:44 PM Johan Hovold <johan@kernel.org> wrote:
>> On Mon, May 06, 2024 at 10:09:50PM +0300, Andy Shevchenko wrote:
>>> Mon, May 06, 2024 at 05:08:29PM +0200, Johan Hovold kirjoitti:
>
> ...
>
>>>> [ johan: rework probe to match new binding, amend commit message and
>>>> Kconfig entry]
>>>
>>> Wouldn't be better on one line?
>>
>> Now you're really nit picking. ;) I think I prefer to stay within 72
>> columns.
>
> Not really. The tag block is special and the format is rather one
> entry per line. This might break some scriptings.
>
> ...
I think [] can be wrapped, I saw it at least many times and I use as well...
...
> ...
>
>>>> +MODULE_ALIAS("platform:qcom-pm8008-regulator");
>>>
>>> Use ID table instead.
>>
>> No, the driver is not using an id-table for matching so the alias is
>> needed for module auto-loading.
>
> Then create one. Added Krzysztof for that. (He is working on dropping
> MODULE_ALIAS() in cases like this one)
Yeah, please use ID table, since this is a driver (unless I missed
something). Module alias does not scale, leads to stale and duplicated
entries, so should not be used as substitute of ID table. Alias is
suitable for different cases.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-05-07 18:14 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 15:08 [PATCH 00/13] arm64: dts: qcom: sc8280xp-x13s: enable pm8008 camera pmic Johan Hovold
2024-05-06 15:08 ` [PATCH 01/13] dt-bindings: mfd: pm8008: add reset gpio Johan Hovold
2024-05-07 6:38 ` Krzysztof Kozlowski
2024-05-08 21:39 ` Stephen Boyd
2024-05-27 13:32 ` Linus Walleij
2024-05-06 15:08 ` [PATCH 02/13] mfd: pm8008: fix regmap irq chip initialisation Johan Hovold
2024-05-06 18:56 ` Andy Shevchenko
2024-05-07 15:01 ` Johan Hovold
2024-05-07 17:16 ` Andy Shevchenko
2024-05-09 8:49 ` Johan Hovold
2024-05-09 13:26 ` Andy Shevchenko
2024-05-06 15:08 ` [PATCH 03/13] mfd: pm8008: deassert reset on probe Johan Hovold
2024-05-06 18:57 ` Andy Shevchenko
2024-05-07 15:15 ` Johan Hovold
2024-05-08 16:12 ` Bryan O'Donoghue
2024-05-09 9:31 ` Johan Hovold
2024-05-29 16:17 ` Johan Hovold
2024-05-29 18:52 ` Bryan O'Donoghue
2024-05-27 13:39 ` Linus Walleij
2024-05-06 15:08 ` [PATCH 04/13] mfd: pm8008: mark regmap structures as const Johan Hovold
2024-05-08 17:37 ` Bryan O'Donoghue
2024-05-08 22:03 ` Stephen Boyd
2024-05-06 15:08 ` [PATCH 05/13] mfd: pm8008: use lower case hex notation Johan Hovold
2024-05-08 17:38 ` Bryan O'Donoghue
2024-05-08 22:03 ` Stephen Boyd
2024-05-06 15:08 ` [PATCH 06/13] mfd: pm8008: rename irq chip Johan Hovold
2024-05-08 17:38 ` Bryan O'Donoghue
2024-05-08 22:04 ` Stephen Boyd
2024-05-06 15:08 ` [PATCH 07/13] mfd: pm8008: drop unused driver data Johan Hovold
2024-05-08 17:40 ` Bryan O'Donoghue
2024-05-08 22:05 ` Stephen Boyd
2024-05-06 15:08 ` [PATCH 08/13] dt-bindings: pinctrl: qcom,pmic-gpio: drop pm8008 Johan Hovold
2024-05-07 6:41 ` Krzysztof Kozlowski
2024-05-08 22:06 ` Stephen Boyd
2024-05-06 15:08 ` [PATCH 09/13] pinctrl: qcom: spmi-gpio: drop broken pm8008 support Johan Hovold
2024-05-08 17:43 ` Bryan O'Donoghue
2024-05-08 22:06 ` Stephen Boyd
2024-05-27 13:35 ` Linus Walleij
2024-05-29 16:12 ` Johan Hovold
2024-05-06 15:08 ` [PATCH 10/13] dt-bindings: mfd: pm8008: rework binding Johan Hovold
2024-05-07 6:43 ` Krzysztof Kozlowski
2024-05-07 15:23 ` Johan Hovold
2024-05-08 22:09 ` Stephen Boyd
2024-05-09 6:57 ` Krzysztof Kozlowski
2024-05-06 15:08 ` [PATCH 11/13] mfd: pm8008: rework driver Johan Hovold
2024-05-06 19:18 ` Andy Shevchenko
2024-05-09 9:42 ` Johan Hovold
2024-05-10 13:15 ` Andy Shevchenko
2024-05-22 6:49 ` Johan Hovold
2024-05-22 7:13 ` Andy Shevchenko
2024-05-22 8:00 ` Johan Hovold
2024-05-08 17:56 ` Bryan O'Donoghue
2024-05-06 15:08 ` [PATCH 12/13] regulator: add pm8008 pmic regulator driver Johan Hovold
2024-05-06 19:09 ` Andy Shevchenko
2024-05-07 15:44 ` Johan Hovold
2024-05-07 17:22 ` Andy Shevchenko
2024-05-07 18:14 ` Krzysztof Kozlowski [this message]
2024-05-09 8:57 ` Johan Hovold
2024-05-09 10:48 ` Krzysztof Kozlowski
2024-05-09 12:26 ` Johan Hovold
2024-05-17 9:15 ` Krzysztof Kozlowski
2024-05-08 11:41 ` Mark Brown
2024-05-09 8:53 ` Johan Hovold
2024-05-09 13:24 ` Andy Shevchenko
2024-05-14 13:43 ` Satya Priya Kakitapalli
2024-05-14 22:14 ` Konrad Dybcio
2024-05-29 16:04 ` Johan Hovold
2024-05-14 14:04 ` Satya Priya Kakitapalli
2024-05-14 14:18 ` Andy Shevchenko
2024-05-14 15:04 ` Satya Priya Kakitapalli (Temp)
2024-05-14 16:04 ` Andy Shevchenko
2024-05-07 11:48 ` Konrad Dybcio
2024-05-07 15:52 ` Johan Hovold
2024-05-08 17:55 ` Bryan O'Donoghue
2024-05-08 22:37 ` Stephen Boyd
2024-05-09 9:10 ` Johan Hovold
2024-05-29 15:55 ` Johan Hovold
2024-05-09 12:07 ` Andy Shevchenko
2024-05-09 12:20 ` Johan Hovold
2024-05-06 15:08 ` [PATCH 13/13] arm64: dts: qcom: sc8280xp-x13s: enable pm8008 camera pmic Johan Hovold
2024-05-08 17:53 ` Bryan O'Donoghue
2024-05-06 20:40 ` [PATCH 00/13] " Rob Herring (Arm)
2024-05-09 8:42 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d2ea17c-f91e-4e14-a239-e5e999f6ac50@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andersson@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=johan@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_c_skakit@quicinc.com \
--cc=quic_gurus@quicinc.com \
--cc=robh@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).