linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lijuan Gao <quic_lijuang@quicinc.com>
To: Rob Herring <robh@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	<linux-arm-msm@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<kernel@quicinc.com>
Subject: Re: [PATCH 1/2] dt-bindings: pinctrl: document the QCS615 Top Level Mode Multiplexer
Date: Thu, 12 Sep 2024 10:01:46 +0800	[thread overview]
Message-ID: <8e5364f8-eaa3-4f70-b298-70a21e716f90@quicinc.com> (raw)
In-Reply-To: <20240911151818.GA283533-robh@kernel.org>



在 9/11/2024 11:18 PM, Rob Herring 写道:
> On Tue, Sep 10, 2024 at 06:26:14PM +0800, Lijuan Gao wrote:
>> Document the Top Level Mode Multiplexer on the QCS615 Platform.
>> It concisely explains the pin multiplexing and configuration in
>> the device tree, and includes simple examples of typical device
>> tree snippets, making it easier for designers to configure and
>> manage chip pins.
>>
>> Signed-off-by: Lijuan Gao <quic_lijuang@quicinc.com>
>> ---
>>   .../bindings/pinctrl/qcom,qcs615-tlmm.yaml         | 123 +++++++++++++++++++++
>>   1 file changed, 123 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,qcs615-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,qcs615-tlmm.yaml
>> new file mode 100644
>> index 000000000000..2bfb0a453880
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,qcs615-tlmm.yaml
>> @@ -0,0 +1,123 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/pinctrl/qcom,qcs615-tlmm.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Technologies, Inc. QCS615 TLMM block
>> +
>> +maintainers:
>> +  - Lijuan Gao <quic_lijuang@quicinc.com>
>> +
>> +description:
>> +  Top Level Mode Multiplexer pin controller in Qualcomm QCS615 SoC.
>> +
>> +allOf:
>> +  - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
>> +
>> +properties:
>> +  compatible:
>> +    const: qcom,qcs615-tlmm
>> +
>> +  reg:
>> +    maxItems: 3
>> +
>> +  reg-names:
>> +    items:
>> +      - const: east
>> +      - const: west
>> +      - const: south
>> +
>> +  interrupts:
>> +    maxItems: 1
>> +
>> +  gpio-reserved-ranges:
>> +    minItems: 1
>> +    maxItems: 62
>> +
>> +  gpio-line-names:
>> +    maxItems: 123
>> +
>> +patternProperties:
>> +  "-state$":
>> +    oneOf:
>> +      - $ref: "#/$defs/qcom-qcs615-tlmm-state"
>> +      - patternProperties:
> 
> Needs 'type: object' before patternProperties.
> > Otherwise,
> 
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Well noted.


-- 
Thx and BRs
Lijuan Gao

  reply	other threads:[~2024-09-12  2:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-10 10:26 [PATCH 0/2] dt-bindings: pinctrl: describe qcs615-tlmm Lijuan Gao
2024-09-10 10:26 ` [PATCH 1/2] dt-bindings: pinctrl: document the QCS615 Top Level Mode Multiplexer Lijuan Gao
2024-09-11 15:18   ` Rob Herring
2024-09-12  2:01     ` Lijuan Gao [this message]
2024-09-10 10:26 ` [PATCH 2/2] pinctrl: qcom: add the tlmm driver for QCS615 platform Lijuan Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e5364f8-eaa3-4f70-b298-70a21e716f90@quicinc.com \
    --to=quic_lijuang@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@quicinc.com \
    --cc=krzk+dt@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).