From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01F6DCDB483 for ; Wed, 18 Oct 2023 20:06:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231658AbjJRUG7 (ORCPT ); Wed, 18 Oct 2023 16:06:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230391AbjJRUG6 (ORCPT ); Wed, 18 Oct 2023 16:06:58 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 662A2112 for ; Wed, 18 Oct 2023 13:06:56 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2c503da4fd6so82584671fa.1 for ; Wed, 18 Oct 2023 13:06:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697659614; x=1698264414; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fV7fTkn3aVtTytg7FjK9RSeuS2ZwMLzGixbs5gWSolA=; b=MhqVxXvnxZIYtc18dQccvzFd/4SAmWvq9iXnOtfzH42g5MtrA3i7iw96h4g5w0R8gO +2H//6lG3RxNZ0ECge5KhPXsT9cVFhP7BjIr2NZ68MP29oHX5tdhMz8T4WqrZ6dW2iCL hr9xIOFocT308reggY0Uo6jNkIuXUvveHa8sjIzSTowikV9eZ1RHw02TkEJrF0Ti34cr oDK8o84GPFjnNZrRzSk2y/Tn3nJ3SCpWtJpYuZUeWaJuxHhnygbUJUJ26wiwMvH1gVNt KDTBh+URHftLGqRvGNQaPjI9+6Ag9VPeK+EJepnKMYBd7UR1Fim1gTVVjT/UFzif4Llx qDUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697659614; x=1698264414; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fV7fTkn3aVtTytg7FjK9RSeuS2ZwMLzGixbs5gWSolA=; b=XN0baAH9MeYlfDhX31/mgYXvg8yuOCAxbS0+BuQnGmkGiffnw33psTY5rbRFp0/uUn 0tLdq3xwsSAs243qXgTF1Mi/AD07C6sZeeCgf1CjU0XkVjfn+PxDAL4jJ15o8fP/Ufdz PVHb6wDs1y0qv1YwRHzK9Y8RU+mvEaN7WqKkazttAi32IiE1EdTBvniUTuxgIZDXg1mC Uw/kjaUQwhFjKO3JrNi5iXVawaZA/ZTVjwxBoykKn04iC1xwaYdia3bOVfcjv+zvryWL L6zzJ+DX3Mcih/MvxI6SrJEi4cyyNUsSZSu++vehWN75M4FEJ5LSGXrZzatHstcEozwt BpFQ== X-Gm-Message-State: AOJu0YwUFIVFlIvqRhep5Te1q3U1tfK30VifJglDhJuw/BuPpbJjB0wl sMCw/xHNFKBKn5FtzM4RHQi3wg== X-Google-Smtp-Source: AGHT+IG1Y7dg+9BY88IKn03L6i6fqmO+TD3nURIXN8mg6bV5JruPLssiJqQILJDxYCQmw9MeGFm9rg== X-Received: by 2002:a05:651c:4d2:b0:2c5:2103:604b with SMTP id e18-20020a05651c04d200b002c52103604bmr33279lji.2.1697659614439; Wed, 18 Oct 2023 13:06:54 -0700 (PDT) Received: from [172.30.205.86] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id l13-20020a2e99cd000000b002bcc303bbffsm817654ljj.104.2023.10.18.13.06.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Oct 2023 13:06:54 -0700 (PDT) Message-ID: <8e57d7a7-2441-4056-848d-d8846f45156f@linaro.org> Date: Wed, 18 Oct 2023 22:06:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] dt-bindings: pinctrl: qcom,sa8775p-tlmm: add missing wakeup-parent Content-Language: en-US To: Krzysztof Kozlowski , Bjorn Andersson , Andy Gross , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bartosz Golaszewski , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231018145750.429385-1-krzysztof.kozlowski@linaro.org> <25185346-2d5d-469c-8a88-0f0f9f02a739@linaro.org> <56a8ec24-789f-42ae-88ac-cb35693df390@linaro.org> From: Konrad Dybcio In-Reply-To: <56a8ec24-789f-42ae-88ac-cb35693df390@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 10/18/23 21:23, Krzysztof Kozlowski wrote: > On 18/10/2023 19:44, Konrad Dybcio wrote: >> >> >> On 10/18/23 16:57, Krzysztof Kozlowski wrote: >>> Add missing wakeup-parent property, already used by DTS to indicate that >>> pins are wakeup capable: >>> >>> sa8775p-ride.dtb: pinctrl@f000000: 'wakeup-parent' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+' >>> >>> Signed-off-by: Krzysztof Kozlowski >>> --- >>> Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml >>> index e119a226a4b1..2173c5255638 100644 >>> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml >>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml >>> @@ -28,6 +28,7 @@ properties: >>> gpio-controller: true >>> "#gpio-cells": true >>> gpio-ranges: true >>> + wakeup-parent: true >>> >>> gpio-reserved-ranges: >>> minItems: 1 >> All the properties visiable in this diff sound reasonable to >> put in the common yaml, no? > > Is something missing from common? No, I just forgot how the yaml worked and didn't notice we're essentially status=okaying the properties here.. Konrad