* Re: [PATCH] dt-bindings: pinctrl: qcom,sa8775p-tlmm: add missing wakeup-parent
2023-10-18 14:57 [PATCH] dt-bindings: pinctrl: qcom,sa8775p-tlmm: add missing wakeup-parent Krzysztof Kozlowski
@ 2023-10-18 15:04 ` Bartosz Golaszewski
2023-10-18 17:44 ` Konrad Dybcio
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Bartosz Golaszewski @ 2023-10-18 15:04 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Bjorn Andersson, Andy Gross, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
On Wed, 18 Oct 2023 at 16:57, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> Add missing wakeup-parent property, already used by DTS to indicate that
> pins are wakeup capable:
>
> sa8775p-ride.dtb: pinctrl@f000000: 'wakeup-parent' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
> index e119a226a4b1..2173c5255638 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
> @@ -28,6 +28,7 @@ properties:
> gpio-controller: true
> "#gpio-cells": true
> gpio-ranges: true
> + wakeup-parent: true
>
> gpio-reserved-ranges:
> minItems: 1
> --
> 2.34.1
>
Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] dt-bindings: pinctrl: qcom,sa8775p-tlmm: add missing wakeup-parent
2023-10-18 14:57 [PATCH] dt-bindings: pinctrl: qcom,sa8775p-tlmm: add missing wakeup-parent Krzysztof Kozlowski
2023-10-18 15:04 ` Bartosz Golaszewski
@ 2023-10-18 17:44 ` Konrad Dybcio
2023-10-18 19:23 ` Krzysztof Kozlowski
2023-10-24 18:06 ` Rob Herring
2023-10-26 13:52 ` Linus Walleij
3 siblings, 1 reply; 7+ messages in thread
From: Konrad Dybcio @ 2023-10-18 17:44 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Andy Gross, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bartosz Golaszewski, linux-arm-msm, linux-gpio, devicetree,
linux-kernel
On 10/18/23 16:57, Krzysztof Kozlowski wrote:
> Add missing wakeup-parent property, already used by DTS to indicate that
> pins are wakeup capable:
>
> sa8775p-ride.dtb: pinctrl@f000000: 'wakeup-parent' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
> index e119a226a4b1..2173c5255638 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
> @@ -28,6 +28,7 @@ properties:
> gpio-controller: true
> "#gpio-cells": true
> gpio-ranges: true
> + wakeup-parent: true
>
> gpio-reserved-ranges:
> minItems: 1
All the properties visiable in this diff sound reasonable to
put in the common yaml, no?
Konrad
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: qcom,sa8775p-tlmm: add missing wakeup-parent
2023-10-18 17:44 ` Konrad Dybcio
@ 2023-10-18 19:23 ` Krzysztof Kozlowski
2023-10-18 20:06 ` Konrad Dybcio
0 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-10-18 19:23 UTC (permalink / raw)
To: Konrad Dybcio, Bjorn Andersson, Andy Gross, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bartosz Golaszewski, linux-arm-msm, linux-gpio, devicetree,
linux-kernel
On 18/10/2023 19:44, Konrad Dybcio wrote:
>
>
> On 10/18/23 16:57, Krzysztof Kozlowski wrote:
>> Add missing wakeup-parent property, already used by DTS to indicate that
>> pins are wakeup capable:
>>
>> sa8775p-ride.dtb: pinctrl@f000000: 'wakeup-parent' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+'
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
>> index e119a226a4b1..2173c5255638 100644
>> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
>> @@ -28,6 +28,7 @@ properties:
>> gpio-controller: true
>> "#gpio-cells": true
>> gpio-ranges: true
>> + wakeup-parent: true
>>
>> gpio-reserved-ranges:
>> minItems: 1
> All the properties visiable in this diff sound reasonable to
> put in the common yaml, no?
Is something missing from common?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: qcom,sa8775p-tlmm: add missing wakeup-parent
2023-10-18 19:23 ` Krzysztof Kozlowski
@ 2023-10-18 20:06 ` Konrad Dybcio
0 siblings, 0 replies; 7+ messages in thread
From: Konrad Dybcio @ 2023-10-18 20:06 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Andy Gross, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bartosz Golaszewski, linux-arm-msm, linux-gpio, devicetree,
linux-kernel
On 10/18/23 21:23, Krzysztof Kozlowski wrote:
> On 18/10/2023 19:44, Konrad Dybcio wrote:
>>
>>
>> On 10/18/23 16:57, Krzysztof Kozlowski wrote:
>>> Add missing wakeup-parent property, already used by DTS to indicate that
>>> pins are wakeup capable:
>>>
>>> sa8775p-ride.dtb: pinctrl@f000000: 'wakeup-parent' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+'
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> ---
>>> Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
>>> index e119a226a4b1..2173c5255638 100644
>>> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
>>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
>>> @@ -28,6 +28,7 @@ properties:
>>> gpio-controller: true
>>> "#gpio-cells": true
>>> gpio-ranges: true
>>> + wakeup-parent: true
>>>
>>> gpio-reserved-ranges:
>>> minItems: 1
>> All the properties visiable in this diff sound reasonable to
>> put in the common yaml, no?
>
> Is something missing from common?
No, I just forgot how the yaml worked and didn't notice
we're essentially status=okaying the properties here..
Konrad
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: qcom,sa8775p-tlmm: add missing wakeup-parent
2023-10-18 14:57 [PATCH] dt-bindings: pinctrl: qcom,sa8775p-tlmm: add missing wakeup-parent Krzysztof Kozlowski
2023-10-18 15:04 ` Bartosz Golaszewski
2023-10-18 17:44 ` Konrad Dybcio
@ 2023-10-24 18:06 ` Rob Herring
2023-10-26 13:52 ` Linus Walleij
3 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2023-10-24 18:06 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, linux-arm-msm, Conor Dooley, Bjorn Andersson,
devicetree, linux-gpio, Krzysztof Kozlowski, linux-kernel,
Andy Gross, Konrad Dybcio, Linus Walleij, Bartosz Golaszewski
On Wed, 18 Oct 2023 16:57:50 +0200, Krzysztof Kozlowski wrote:
> Add missing wakeup-parent property, already used by DTS to indicate that
> pins are wakeup capable:
>
> sa8775p-ride.dtb: pinctrl@f000000: 'wakeup-parent' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: qcom,sa8775p-tlmm: add missing wakeup-parent
2023-10-18 14:57 [PATCH] dt-bindings: pinctrl: qcom,sa8775p-tlmm: add missing wakeup-parent Krzysztof Kozlowski
` (2 preceding siblings ...)
2023-10-24 18:06 ` Rob Herring
@ 2023-10-26 13:52 ` Linus Walleij
3 siblings, 0 replies; 7+ messages in thread
From: Linus Walleij @ 2023-10-26 13:52 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Bjorn Andersson, Andy Gross, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski,
linux-arm-msm, linux-gpio, devicetree, linux-kernel
On Wed, Oct 18, 2023 at 4:57 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
> Add missing wakeup-parent property, already used by DTS to indicate that
> pins are wakeup capable:
>
> sa8775p-ride.dtb: pinctrl@f000000: 'wakeup-parent' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 7+ messages in thread