From: Michael Walle <michael@walle.cc>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: horatiu.vultur@microchip.com, UNGLinuxDriver@microchip.com,
andy.shevchenko@gmail.com, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] pinctrl: ocelot: Fix interrupt controller
Date: Tue, 20 Sep 2022 16:25:06 +0200 [thread overview]
Message-ID: <8ec019b32b7221237ccf84fabf07e63d@walle.cc> (raw)
In-Reply-To: <faa173ddc1d55d2e3931246453e5e953@walle.cc>
Am 2022-09-20 14:34, schrieb Michael Walle:
> Am 2022-09-20 14:28, schrieb Linus Walleij:
>> Just checking: since these drivers obviously must pass pass
>> IRQF_SHARED, have you also made sure that each driver also
>> will properly return IRQ_HANDLED if the interrupt was for them
>> (triggered by "their" hardware) but IRQ_NONE if the interrupt was
>> not for them (triggered by something else)?
>
> Thanks, I'll check it.
The gpy driver seems to handle that correctly. The micrel one introduced
a regression some time ago. I've send a fix in the meantime [1], but it
doesn't help for the multiple interrupts here.
-michael
[1]
https://lore.kernel.org/netdev/20220920141619.808117-1-michael@walle.cc/
next prev parent reply other threads:[~2022-09-20 14:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 14:59 [PATCH v3] pinctrl: ocelot: Fix interrupt controller Horatiu Vultur
2022-09-09 15:09 ` Andy Shevchenko
2022-09-15 11:33 ` Horatiu Vultur
2022-09-14 13:02 ` Linus Walleij
2022-09-15 11:22 ` Horatiu Vultur
2022-09-18 18:55 ` Linus Walleij
2022-09-20 12:06 ` Michael Walle
2022-09-20 12:28 ` Linus Walleij
2022-09-20 12:34 ` Michael Walle
2022-09-20 14:25 ` Michael Walle [this message]
2022-09-20 19:30 ` Horatiu Vultur
2022-10-06 11:43 ` Michael Walle
2022-10-07 9:49 ` Horatiu Vultur
2022-10-13 7:30 ` Michael Walle
2022-10-13 14:11 ` Horatiu Vultur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ec019b32b7221237ccf84fabf07e63d@walle.cc \
--to=michael@walle.cc \
--cc=UNGLinuxDriver@microchip.com \
--cc=andy.shevchenko@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).