From mboxrd@z Thu Jan 1 00:00:00 1970 From: Janusz Krzysztofik Subject: Re: [RFC PATCH 3/8] mtd: rawnand: ams-delta: Set port direction once per transfer Date: Fri, 20 Jul 2018 20:12:05 +0200 Message-ID: <90128326.sKM4evrj8F@z50> References: <20180718235710.18242-1-jmkrzyszt@gmail.com> <20180718235710.18242-4-jmkrzyszt@gmail.com> <20180719082318.290abee1@bbrezillon> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20180719082318.290abee1@bbrezillon> Sender: linux-kernel-owner@vger.kernel.org To: Boris Brezillon Cc: Miquel Raynal , Tony Lindgren , Aaro Koskinen , Grygorii Strashko , Santosh Shilimkar , Kevin Hilman , Linus Walleij , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Artem Bityutskiy List-Id: linux-gpio@vger.kernel.org On Thursday, July 19, 2018 8:23:18 AM CEST Boris Brezillon wrote: > On Thu, 19 Jul 2018 01:57:05 +0200 > Janusz Krzysztofik wrote: > > > In its current shape, the driver sets data port direction before each > > byte read/write operation, even during multi-byte transfers. Optimize > > that by setting the port direction only on first byte of each transfer. > > Sounds like premature optimization for something you'll rework when > fully switching to the GPIO consumer API to control the DATA bus. Indeed, this optimization was crucial for getting acceptable performance of data transfers over GPIO. I'm only not sure if there is any action in response to your comment expected on my side, e.g., did you want to say I should modify the patch description, or change the order of patches? Thanks, Janusz