From: Sodagudi Prasad <psodagud@codeaurora.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: bjorn.andersson@linaro.org, linus.walleij@linaro.org,
linux-gpio@vger.kernel.org, sboyd@codeaurora.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: protected pins and debugfs
Date: Tue, 16 Oct 2018 19:00:45 -0700 [thread overview]
Message-ID: <91594b8e6578d542dc7cbebf34458b0c@codeaurora.org> (raw)
In-Reply-To: <5848ff92c1388b7d6904e88b57bbfec8@codeaurora.org>
On 2018-10-10 12:40, Sodagudi Prasad wrote:
> On 2018-10-07 23:04, Stephen Boyd wrote:
>> Quoting Sodagudi Prasad (2018-10-03 05:38:24)
>>>
>>> for (i = 0; i < chip->ngpio; i++, gpio++) {
>>> + label = gpiochip_is_requested(chip, i);
>>> + if (!label)
>>> + continue;
>>> msm_gpio_dbg_show_one(s, NULL, chip, i, gpio);
>>> - seq_puts(s, "\n");
>>> }
>>> }
>>>
>>
>> Does something not work with the following code in
>> msm_gpio_dbg_show_one()?
>>
>>
>> if (!gpiochip_line_is_valid(chip, offset))
>> return;
>
> Hi Stephen,
> I didnt realize that these changes are merged on tip. I was testing on
> 4.14 kernel.
>
> https://lore.kernel.org/patchwork/patch/878107/
> https://lore.kernel.org/patchwork/patch/878106/
> https://lore.kernel.org/patchwork/patch/878109/
Hi Stephen,
After checking this further, adding "gpio-reserved-ranges" in not good
option. Because of the following reasons.
1) These gpio information changes from platform to platform. So need to
maintain reserved-range properly for each platform.
2) Also some of the gpio can be changed to secure/protected gpio
dynamically based on the use case.
It looks adding the "gpio-reserved-ranges" ranges is not good option for
most of the platforms.
Can you please check the initial patch suggested in this thread? Please
let me know if you have any other options for the above points.
-Thanks, Prasad
>
> I will add "gpio-reserved-ranges" to internal platforms and this issue
> should not be observed.
>
> -thanks, Prasad
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum,
Linux Foundation Collaborative Project
next prev parent reply other threads:[~2018-10-17 2:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 12:38 protected pins and debugfs Sodagudi Prasad
2018-10-04 8:34 ` Linus Walleij
2018-10-08 6:04 ` Stephen Boyd
2018-10-10 19:40 ` Sodagudi Prasad
2018-10-17 2:00 ` Sodagudi Prasad [this message]
2018-10-17 7:28 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91594b8e6578d542dc7cbebf34458b0c@codeaurora.org \
--to=psodagud@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).