From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDFB18BE5; Mon, 21 Oct 2024 15:27:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729524428; cv=none; b=FrWzmThjo7ne/edK6Hr1zEx8QDlLJI0/ifDXcIxPH4MDH5dS1eUd9r9+VCndbCt7rfJhvCreopHaKjU4Oa0aI+SmWkAL9OToviIxED2hmbCL1mVkITjr7298VN6lA0/dUJbgtcMaIm/Bbg6aZZZsBAw5/vSFBKaDbw53/omZJa8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729524428; c=relaxed/simple; bh=i0gCLQbSWW2zJuk+L9S/yA68nCNDdhPNcv6ZpU4ITwg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Np7tA/rxpOgXj6+qHufp4XoFnYiZMLbPsbrvSwiNix0q1mpGwfJ6SCZH0c0XUNoaQ8En4fWqMauIG0BTlrXx2eYt7OVCq/5t1wDdUP+c994wHxELhLyNgoWE1CNV5URywSNDVAoxtAlaJKDqy6ja2NwZco7mbZJOp+ho3mTl4xc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mbchp1xY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mbchp1xY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F2B4C4CEC3; Mon, 21 Oct 2024 15:27:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729524428; bh=i0gCLQbSWW2zJuk+L9S/yA68nCNDdhPNcv6ZpU4ITwg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=mbchp1xYDM4vuFZs21olLj3uzkrM18S4eZvtbRt0ExhY/T+dx+nzI85V+eoSu6drd iaSSHxatZ+Cga9xgNjw/AvatYQWvkkGJMTMEzBuN/dez9czYCK01tFerBxo/3k2IbV sEIoO2BlhvSNcdpqyTWqBvnO7j9cN9csApr77Ms5FxSMJ4QQqVhFz0XDMjoSBGcNld o63FO8sSVquvOJD47sW47sP5R3+POtUxKV9bz+x0GKtLO/WWaQWxQf4m+SH7V8kuD1 lSv3VeHgbZsud+BTxld5GePUL+RZJ2PvDtdOj8IJqkZQH3k+uDmRsA+Vb+rHX+KZWj xat3zGlJOJPBQ== Message-ID: <91bcc765-2e56-433d-a629-c5255fc8d256@kernel.org> Date: Mon, 21 Oct 2024 17:27:00 +0200 Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] dt-bindings: pinctrl: Add support for Amlogic A4 SoCs To: neil.armstrong@linaro.org, Jerome Brunet , Xianwei Zhao Cc: Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kevin Hilman , Martin Blumenstingl , Bartosz Golaszewski , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <20241018-a4_pinctrl-v3-0-e76fd1cf01d7@amlogic.com> <20241018-a4_pinctrl-v3-1-e76fd1cf01d7@amlogic.com> <4a79f996-9d82-48b2-8a93-d7917413ed8c@kernel.org> <1jttd9rein.fsf@starbuckisacylon.baylibre.com> <4127b448-a914-4c69-b938-29512995326f@amlogic.com> <1jmsj1rclh.fsf@starbuckisacylon.baylibre.com> <5ad8f396-84a5-486d-b90d-98fbf8882d1b@linaro.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 21/10/2024 12:38, neil.armstrong@linaro.org wrote: >>> ====><================= >>> +/* Standard port */ >>> +#define GPIOB_START 0 >>> +#define GPIOB_NUM 14 >>> + >>> +#define GPIOD_START (GPIOB_START + GPIOB_NUM) >>> +#define GPIOD_NUM 16 >>> + >>> +#define GPIOE_START (GPIOD_START + GPIOD_NUM) >>> +#define GPIOE_NUM 2 >>> + >>> +#define GPIOT_START (GPIOE_START + GPIOE_NUM) >>> +#define GPIOT_NUM 23 >>> + >>> +#define GPIOX_START (GPIOT_START + GPIOT_NUM) >>> +#define GPIOX_NUM 18 >>> + >>> +#define PERIPHS_PIN_NUM (GPIOX_START + GPIOX_NUM) >>> + >>> +/* Aobus port */ >>> +#define GPIOAO_START 0 >>> +#define GPIOAO_NUM 7 >>> + >>> +/* It's a special definition, put at the end, just 1 num */ >>> +#define GPIO_TEST_N (GPIOAO_START + GPIOAO_NUM) >>> +#define AOBUS_PIN_NUM (GPIO_TEST_N + 1) >>> + >>> +#define AMLOGIC_GPIO(port, offset) (port##_START + (offset)) >>> ====><================= >>> >>> is exactly what rob asked for, and you nacked it. >> >> No, this is not what was asked, at least according to my understanding. >> Number of GPIOs is not an ABI. Neither is their relationship, where one >> starts and other ends. > > I confirm this need some work, but it moved the per-pin define to start > and ranges, so what did rob expect ? > >> >> Maybe I missed something, but I could not find any users of these in the >> DTS. Look: >> >> https://lore.kernel.org/all/20241014-a4_pinctrl-v2-3-3e74a65c285e@amlogic.com/ > > So you want consumers before the bindings ? strange argument > >> >> Where is any of above defines? >> >> Maybe they will be visible in the consumer code, but I did not imagine >> such use. You expect: >> reset-gpios = <&ctrl GPIOAO_START 1>??? > > No I expect: > reset-gpios = <&ctrl AMLOGIC_GPIO(B, 0) 1>; > > but the macro should go along the dts like we did for the reset defines, > so perhaps this is the solution ? OK, so I said it was not a binding: https://lore.kernel.org/all/u4afxqc3ludsic4n3hs3r3drg3ftmsbcwfjltic2mb66foo47x@xe57gltl77hq/ and you here confirm, if I understood you correctly, that it goes with the DTS like reset defines (I assume non-ID like defines?), so also not a binding? What are we disagreeing with? Just to recall, Jerome asked whether you have to now use arbitrary numbers in DTS and my answer was: not. It's still the same answer. Best regards, Krzysztof