From: Rojhalat Ibrahim <imr@rtschenk.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Alexandre Courbot <gnurou@gmail.com>,
Alexandre Courbot <acourbot@nvidia.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH v5 2/4] gpiolib: add gpiod_get_array and gpiod_put_array functions
Date: Thu, 05 Mar 2015 12:52:43 +0100 [thread overview]
Message-ID: <9200350.WRsxatTQK5@pcimr> (raw)
In-Reply-To: <CACRpkdZS5N62zoD-zPeYM3KOJp1zUWE8yUGXTpZ4msoAXgVj9Q@mail.gmail.com>
On Thursday 05 March 2015 09:55:09 Linus Walleij wrote:
> On Wed, Feb 11, 2015 at 5:27 PM, Rojhalat Ibrahim <imr@rtschenk.de> wrote:
>
> > Introduce new functions for conveniently obtaining and disposing of an entire
> > array of GPIOs with one function call.
> >
> > Suggested-by: Alexandre Courbot <acourbot@nvidia.com>
> > Signed-off-by: Rojhalat Ibrahim <imr@rtschenk.de>
> > Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
> >
> > ACPI part:
> > Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> > Tested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> >
> > DT part:
> > Tested-by: Rojhalat Ibrahim <imr@rtschenk.de>
> > ---
> > Change log:
> > v5: move the ACPI functions to gpiolib-acpi.c
> > v4: - use shorter names for members of struct gpio_descs
> > - rename lut_gpio_count to platform_gpio_count for clarity
> > - add check for successful memory allocation
> > - use ERR_CAST()
> > v3: - rebase on current linux-gpio devel branch
> > - fix ACPI GPIO counting
> > - allow for zero-sized arrays
> > - make the flags argument mandatory for the new functions
> > - clarify documentation
> > v2: change interface
>
> Patch applied with some fuzzing, check that it ended up correctly
> in my git (or linux-next).
>
Looks good to me.
Thanks.
Rojhalat
prev parent reply other threads:[~2015-03-05 11:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 16:27 [PATCH v5 2/4] gpiolib: add gpiod_get_array and gpiod_put_array functions Rojhalat Ibrahim
2015-03-05 8:55 ` Linus Walleij
2015-03-05 11:52 ` Rojhalat Ibrahim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9200350.WRsxatTQK5@pcimr \
--to=imr@rtschenk.de \
--cc=acourbot@nvidia.com \
--cc=davem@davemloft.net \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).