From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rojhalat Ibrahim <imr@rtschenk.de>
Subject: Re: [PATCH v5 2/4] gpiolib: add gpiod_get_array and gpiod_put_array functions
Date: Thu, 05 Mar 2015 12:52:43 +0100
Message-ID: <9200350.WRsxatTQK5@pcimr>
References: <3417970.NJsESPLFsD@pcimr> <CACRpkdZS5N62zoD-zPeYM3KOJp1zUWE8yUGXTpZ4msoAXgVj9Q@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Return-path: <linux-gpio-owner@vger.kernel.org>
Received: from mail-out.m-online.net ([212.18.0.9]:41826 "EHLO
	mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752592AbbCELwt (ORCPT
	<rfc822;linux-gpio@vger.kernel.org>); Thu, 5 Mar 2015 06:52:49 -0500
In-Reply-To: <CACRpkdZS5N62zoD-zPeYM3KOJp1zUWE8yUGXTpZ4msoAXgVj9Q@mail.gmail.com>
Sender: linux-gpio-owner@vger.kernel.org
List-Id: linux-gpio@vger.kernel.org
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, Alexandre Courbot <gnurou@gmail.com>, Alexandre Courbot <acourbot@nvidia.com>, Mika Westerberg <mika.westerberg@linux.intel.com>, "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>, David Miller <davem@davemloft.net>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>

On Thursday 05 March 2015 09:55:09 Linus Walleij wrote:
> On Wed, Feb 11, 2015 at 5:27 PM, Rojhalat Ibrahim <imr@rtschenk.de> wrote:
> 
> > Introduce new functions for conveniently obtaining and disposing of an entire
> > array of GPIOs with one function call.
> >
> > Suggested-by: Alexandre Courbot <acourbot@nvidia.com>
> > Signed-off-by: Rojhalat Ibrahim <imr@rtschenk.de>
> > Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
> >
> > ACPI part:
> > Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> > Tested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> >
> > DT part:
> > Tested-by: Rojhalat Ibrahim <imr@rtschenk.de>
> > ---
> > Change log:
> >   v5: move the ACPI functions to gpiolib-acpi.c
> >   v4: - use shorter names for members of struct gpio_descs
> >       - rename lut_gpio_count to platform_gpio_count for clarity
> >       - add check for successful memory allocation
> >       - use ERR_CAST()
> >   v3: - rebase on current linux-gpio devel branch
> >       - fix ACPI GPIO counting
> >       - allow for zero-sized arrays
> >       - make the flags argument mandatory for the new functions
> >       - clarify documentation
> >   v2: change interface
> 
> Patch applied with some fuzzing, check that it ended up correctly
> in my git (or linux-next).
> 

Looks good to me.

Thanks.
   Rojhalat