From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FF7FC4332F for ; Fri, 18 Nov 2022 18:15:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232926AbiKRSPT (ORCPT ); Fri, 18 Nov 2022 13:15:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235281AbiKRSPS (ORCPT ); Fri, 18 Nov 2022 13:15:18 -0500 Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3DEA898CF; Fri, 18 Nov 2022 10:15:17 -0800 (PST) Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 2AIIFAMg084079; Fri, 18 Nov 2022 12:15:10 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1668795310; bh=JyQb2Ma01x7fRRs7TlYmPzx1wFI4WbhdeZZCWveBKt8=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=llEI2xMj14C2NWEoiT0IaTVyryh5KtqoBlJuwZ1FX2zsVpyzEhPwwwYfVEL0VlDhK nwzyRcUhIPKW9gdch92GNlFyx+IXR4dqn36qtBbqxsK2Dm6ei/V/diEByavaYhsBO7 t5WO47WiKO5c1n0Gh80vvU8nApYg3zSVhv+Ie7xI= Received: from DLEE107.ent.ti.com (dlee107.ent.ti.com [157.170.170.37]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 2AIIFAPE072009 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 18 Nov 2022 12:15:10 -0600 Received: from DLEE115.ent.ti.com (157.170.170.26) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Fri, 18 Nov 2022 12:15:10 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Fri, 18 Nov 2022 12:15:10 -0600 Received: from [10.250.38.44] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 2AIIF9s3014409; Fri, 18 Nov 2022 12:15:09 -0600 Message-ID: <93242211-95e7-09a0-fced-5ef2deb9fc08@ti.com> Date: Fri, 18 Nov 2022 12:15:09 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v3 4/4] arm64: dts: ti: Add support for J784S4 EVM board Content-Language: en-US To: Nishanth Menon CC: Apurva Nandan , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Linus Walleij , , , , , Hari Nagalla References: <20221116130428.161329-1-a-nandan@ti.com> <20221116130428.161329-5-a-nandan@ti.com> <20221118174754.y37pq77drvla2uxj@tinderbox> <8c123fa2-caab-d2dd-5eb4-688f1c6abb33@ti.com> <20221118180808.wnel7d6gswsnooww@junkman> From: Andrew Davis In-Reply-To: <20221118180808.wnel7d6gswsnooww@junkman> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 11/18/22 12:08 PM, Nishanth Menon wrote: > On 11:56-20221118, Andrew Davis wrote: >> On 11/18/22 11:47 AM, Nishanth Menon wrote: >>> On 11:40-20221118, Andrew Davis wrote: >>>> On 11/16/22 7:04 AM, Apurva Nandan wrote: >>> >>> [...] >>> >>>>> +#include >>>>> +#include >>>>> +#include "k3-j784s4.dtsi" >>>>> + >>>>> +/ { >>>>> + compatible = "ti,j784s4-evm", "ti,j784s4"; >>>>> + model = "Texas Instruments J784S4 EVM"; >>>>> + >>>>> + chosen { >>>>> + stdout-path = "serial2:115200n8"; >>>>> + }; >>>>> + >>>>> + aliases { >>>>> + serial2 = &main_uart8; >>>> >>>> This feels hacky. Your chosen node picks serial2 as that is usually >>>> the one that is wired up on K3 boards. But on this board it is main_uart8. >>>> So why not have this be serial10, then choose >>>> >>>> stdout-path = "serial10:115200n8"; >>>> >>>> Also, I've made comments on previous version of this series, it is >>>> nice to include folks who have commented before in the CC for future >>>> versions, that way our filters don't hide these away and we can more >>>> easily check that our comments have been addressed. >>> >>> Please stick with the standard of serial2 as the linux console standard. >>> We ended up with that to ease up capabilities of various distros to >>> uniformly work across SoC and board variants. >>> >> >> The chosen "stdout-path" is for setting the kernel's default output terminal. >> Distros and other userspaces need to use their own policy mechanisms for >> picking what serial port to run getty on or whatever the issue may be. >> >> Some look at the kernel command line, and our bootloader provides >> that too, so still no reason to fake alias names here. > > > We have had this conversation earlier as well. > > https://lore.kernel.org/linux-arm-kernel/CAK8P3a2VSBvOn1o+q1PYZaQ6LS9U4cz+DZGuDbisHkwNs2dAAw@mail.gmail.com/T/#m4ecb0dc6a78c84631f072faa1b0df0df46333d09 > > This is also the reason why we picked serial2 as linux console as a > standard across the boards based on the ecosystem. > I don't see either of those addressed in that thread, only that the aliases should go in the .dts files and be trimmed, nothing stops us from: chosen { stdout-path = "serial10:115200n8"; }; aliases { serial10 = &main_uart8; }; Andrew