Re: [PATCH 08/14] ASoC: mediatek: mt8196: support I2S in platform driver

[Krzysztof Kozlowski <krzk@kernel.org>]

On 07/03/2025 13:47, Darren.Ye wrote:
> +
> +static int etdm_parse_dt(struct mtk_base_afe *afe)
> +{
> +	int ret;
> +	struct mt8196_afe_private *afe_priv = afe->platform_priv;
> +	struct mtk_afe_i2s_priv *i2sin4_priv = afe_priv->dai_priv[MT8196_DAI_I2S_IN4];
> +	struct mtk_afe_i2s_priv *i2sout4_priv = afe_priv->dai_priv[MT8196_DAI_I2S_OUT4];
> +	unsigned int ch_num_in;
> +	unsigned int ch_num_out;
> +	unsigned int sync_in;
> +	unsigned int sync_out;
> +	unsigned int ip_mode;
> +
> +	/* get etdm ch */
> +	ret = of_property_read_u32(afe->dev->of_node, "mediatek,etdm-out-ch", &ch_num_out);
> +	if (ret) {
> +		dev_info(afe->dev, "%s() failed to read mediatek,etdm-out-ch\n", __func__);
> +		return -EINVAL;
> +	}
> +	i2sout4_priv->ch_num = ch_num_out;
> +	dev_dbg(afe->dev, "%s() mediatek,etdm-out-ch: %d\n", __func__, ch_num_out);
> +
> +	ret = of_property_read_u32(afe->dev->of_node, "mediatek,etdm-in-ch", &ch_num_in);
> +	if (ret) {
> +		dev_info(afe->dev, "%s() failed to read mediatek,etdm-in-ch\n", __func__);
> +		return -EINVAL;
> +	}
> +	i2sin4_priv->ch_num = ch_num_in;
> +	dev_dbg(afe->dev, "%s() mediatek,etdm-in-ch: %d\n", __func__, ch_num_in);
> +
> +	/* get etdm sync */
> +	ret = of_property_read_u32(afe->dev->of_node, "mediatek,etdm-out-sync", &sync_out);
> +	if (ret) {
> +		dev_info(afe->dev, "%s() failed to read mediatek,etdm-out-sync\n", __func__);
> +		return -EINVAL;
> +	}
> +	i2sout4_priv->sync = sync_out;
> +	dev_dbg(afe->dev, "%s() mediatek,etdm-out-sync: %d\n", __func__, sync_out);
> +
> +	ret = of_property_read_u32(afe->dev->of_node, "mediatek,etdm-in-sync", &sync_in);
> +	if (ret) {
> +		dev_info(afe->dev, "%s() failed to read mediatek,etdm-in-sync\n", __func__);
> +		return -EINVAL;
> +	}
> +	i2sin4_priv->sync = sync_in;
> +	dev_dbg(afe->dev, "%s() mediatek,etdm-in-sync: %d\n", __func__, sync_in);
> +
> +	/* get etdm ip mode */
> +	ret = of_property_read_u32(afe->dev->of_node, "mediatek,etdm-ip-mode", &ip_mode);
> +	if (ret) {
> +		dev_info(afe->dev, "%s() failed to read mediatek,etdm-ip-mode\n", __func__);
> +		return -EINVAL;
> +	}
> +	i2sin4_priv->ip_mode = ip_mode;
> +	dev_dbg(afe->dev, "%s() mediatek,etdm-ip-mode: %d\n", __func__, ip_mode);
> +
> +	return 0;
> +}
> +
> +static int mt8196_dai_i2s_get_share(struct mtk_base_afe *afe)
> +{
> +	struct mt8196_afe_private *afe_priv = afe->platform_priv;
> +	const struct device_node *of_node = afe->dev->of_node;
> +	const char *of_str;
> +	const char *property_name;
> +	struct mtk_afe_i2s_priv *i2s_priv;
> +	int i;
> +
> +	for (i = 0; i < DAI_I2S_NUM; i++) {
> +		i2s_priv = afe_priv->dai_priv[mt8196_i2s_priv[i].id];
> +		property_name = mt8196_i2s_priv[i].share_property_name;
> +		if (of_property_read_string(of_node, property_name, &of_str))
> +			continue;
> +		i2s_priv->share_i2s_id = get_i2s_id_by_name(afe, of_str);
> +	}
> +	return 0;
> +}
> +
> +static int mt8196_dai_i2s_set_priv(struct mtk_base_afe *afe)
> +{
> +	int i;
> +	int ret;
> +
> +	for (i = 0; i < DAI_I2S_NUM; i++) {
> +		ret = mt8196_dai_set_priv(afe, mt8196_i2s_priv[i].id,
> +					  sizeof(struct mtk_afe_i2s_priv),
> +					  &mt8196_i2s_priv[i]);
> +		if (ret)
> +			return ret;
> +	}
> +	return 0;
> +}
> +
> +int mt8196_dai_i2s_register(struct mtk_base_afe *afe)
> +{
> +	struct mtk_base_afe_dai *dai;
> +	int ret;
> +
> +	dev_dbg(afe->dev, "%s() successfully start\n", __func__);

Well, no. Tracing is for debugging entry/exit of functions. Say
something useful or just drop such entry/exist success messages.

> +
> +	dai = devm_kzalloc(afe->dev, sizeof(*dai), GFP_KERNEL);
> +	if (!dai)
> +		return -ENOMEM;
> +
> +	list_add(&dai->list, &afe->sub_dais);
> +
> +	dai->dai_drivers = mtk_dai_i2s_driver;
> +	dai->num_dai_drivers = ARRAY_SIZE(mtk_dai_i2s_driver);
> +
> +	dai->controls = mtk_dai_i2s_controls;
> +	dai->num_controls = ARRAY_SIZE(mtk_dai_i2s_controls);
> +	dai->dapm_widgets = mtk_dai_i2s_widgets;
> +	dai->num_dapm_widgets = ARRAY_SIZE(mtk_dai_i2s_widgets);
> +	dai->dapm_routes = mtk_dai_i2s_routes;
> +	dai->num_dapm_routes = ARRAY_SIZE(mtk_dai_i2s_routes);
> +
> +	/* set all dai i2s private data */
> +	ret = mt8196_dai_i2s_set_priv(afe);
> +	if (ret)
> +		return ret;
> +
> +	/* parse share i2s */
> +	ret = mt8196_dai_i2s_get_share(afe);
> +	if (ret)
> +		return ret;
> +
> +	/* for customer to change ch_num & sync & ipmode from dts */
> +	ret = etdm_parse_dt(afe);
> +	if (ret) {
> +		dev_info(afe->dev, "%s() fail to parse dts: %d\n", __func__, ret);

Why do you print errors twice?

> +		return ret;
> +	}
> +
> +	return 0;
> +}


Best regards,
Krzysztof