From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=103.168.172.145 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792602179; b=WSon9Jgnc6zWO7etDv0UzfHlsA8yVOhFzmjomO9CmnbzF0EqXOmVGuFkdTFHooQxxMeq dav9FRaAKXBNfVOmDhHJzntFezg7On9RemZRLeGgMm841LLgpKf4TfnkMf+iyTdhC6cFk 5whIXFMgaeWXaIpXXItrPXBUg0e7C1VK/aJtLxeho6PrDXpntmfHqmK2o2CIDP3wawR5m k8v0r5tdUC4E0C/b5WoC80wr5JhGP2Aq7AYzICxp0PUfJzXezBrJUj/qh05F1MHvhWPy+ bFG1v3ubjLe/EK5/X7nx+Zc01LvBbBqt3grmRZweVor9GJBXhOtUbSHtpPx4ua18jGA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792602179; h=DMARC-Filter:Received:Received:DKIM-Signature:DKIM-Signature: X-DKIM2-Info:DKIM2-Signature:X-DKIM2-Info:Message-Instance: X-ME-Sender:X-ME-Proxy-Cause:X-ME-Proxy:Feedback-ID:Received:X-Mailer: MIME-Version:X-ThreadId:Date:From:To:Cc:Message-Id:In-Reply-To: References:Subject:Content-Type:Content-Transfer-Encoding; bh=TEZyD5pcu62HA6lXMz0SzC2W+CY7uiKBKznI8rJlxsQ=; b=26CMIksDRU5v82aoQHxV6R+sN6fv0gIKs16Tg3EwxF22Y9MwscIykgars4Jrl670s+J6 qdeDWHQGyELTZvfnfEIHerW/VHongxm8hsxslgcomK/cYkZv0NUEs3m+pGoY0ue6PvWvz +Q9EvgLBjreQfi4waaKUoFhTPGDguxj+SDezIJj7abbabHrWqxGkwCT0PFPXU0cwxXLnQ aZ4DcN/UYVLWrt5HYaWOtCr0Pa0Z1bstPo+oMI+CEJ6kmOQvM8XOKRUYQvMgyxAxrRv1W AlcV/F25tLryeCpFMHFbvNKJL+U1rfxznA7Zw0MqjnYYUxBsBFog4CJKPEmfShQYaJA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=arndb.de; spf=pass smtp.mailfrom=arndb.de; dkim=pass header.d=arndb.de header.i=@arndb.de header.a=rsa-sha256 header.s=fm1 header.b=QRY1ZjGB; dkim=pass header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm2 header.b=kG5AVI4X; arc=none smtp.remote-ip=103.168.172.145 Received: from fout-a2-smtp.messagingengine.com (fout-a2-smtp.messagingengine.com [103.168.172.145]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9031E606A31B for ; Wed, 21 Oct 2026 17:02:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 9031E606A31B Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arndb.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=arndb.de header.i=@arndb.de header.a=rsa-sha256 header.s=fm1 header.b=QRY1ZjGB; dkim=pass (2048-bit key, unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm2 header.b=kG5AVI4X Received: from ams-compute-02.internal (ams-compute-02.internal [10.64.2.62]) by mailfout.phl.internal (Postfix) with ESMTP id 6D5D3EC0121 for ; Wed, 21 Oct 2026 13:02:57 -0400 (EDT) Received: from ams-imap-03 ([10.64.2.23]) by ams-compute-02.internal (MEProxy); Wed, 21 Oct 2026 13:02:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1792602174; x=1792688574; bh=TEZyD5pcu62HA6lXMz0SzC2W+CY7uiKBKznI8rJlxsQ=; b= QRY1ZjGBBhV/NY/+vXckqdP9UdbG7ET+EHLz9tErP6Ht/1xX/XhG+5lEdDQHyh7n QqO6RiwQMU76DAM999Jg1m+o4RgSBt3CuK79mu3RlJNmrs/eIIY7E9PyEc3k73zL UqGYL9HqdF2GK9Eqou8u9bYjXTk9EL1Sve1rxOaqJYMkJ6xWSfEO7gmtjs0ScniF WuyQ1gxJ+NPW+glQ9QmPT+qk1da6Rkcew+tE76lRVx2IMjvrOpwn/9wJdFODNiWE kfUQQho9RVGmsDYznSmTpXlrbNGxpOPCfh75U+Wt2he6QC0yWfb29CoV1x1m9YBf I2RI8990ppHYKvGpXywZoA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1792602174; x= 1792688574; bh=TEZyD5pcu62HA6lXMz0SzC2W+CY7uiKBKznI8rJlxsQ=; b=k G5AVI4XTRSGyEJmWN27DMXkCV1dpAXajXKfTvVH/rEHlrO1Q12W0h+MbHFSAy5IG yafOOWJdzwT6zkEZKkG960TJ/dAd4mljkTAdLWOLL1N8QpDUUnde8+OFUOLGqyax i/uhZ+H82618bzRp4SlAg+x98sGxfTWThhDI1Cq+oPn5GY1W9UJJb4E3GN7c4uPj EkTFDBdnSlZzj5hvNZNOIyi3Cgv4Zdpq4xaCNnOyyPIm6xmr2rHxIYmC+Pky+akm BifwkpegJBFRUmTUv5IBMTGHBASHL/swC8CzGZIVKJVgwmW/lIfzjI31khPlV4VE /SjmTd/pkQw722LkSz6gA== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-07; repo=github.com/dkim2wg/interop; date=2026-10-18; sw=lmtpprox; action=sign d=arndb.de a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1792602174; d=arndb.de; mf=PGFybmRAYXJuZGIuZGU+; rt=PGxpbnV4LWdwaW9Admdlci5rZXJuZWwub3JnPg==; s=fm1:rsa-sha256:CDDBpS0XCkrHRP0Q4+PgBn46zjRBsbCSAi6q07KcTNVlLge khqhAhjdzhC3ActPApxuYsn75xKYYYH+n5LtyW7cWOLr11EICJEDzwFQ0658DmLb 9+LT4hdOiDcGe1+qYXO6/bUXppRzN+5svgLIBZ+PNs+0pcTC/RNKvYRqpdCPmGjV +iByE2mxf9FYWOzNqKF8WYUsqPvR6c15GQTl8uGjN1JL/w9slpk+tde/gvMLxvjd 0y03ZWHWEXGF1Uc186RbWA0L4dlIfo1QK3rcnJ2t1PshXdx55t80zHH9+I45VL4B Jwr/c9UDNvzIr3j6l4vw8eRdubaF8oGB6msQI4Q==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-07; repo=github.com/dkim2wg/interop; date=2026-10-18; sw=lmtpprox; action=mi-m=1; hc=12; hn=cc,content-transfer-encoding,content-type,date,feedback-id, from,in-reply-to,message-id,mime-version,references,subject,to; Message-Instance: m=1; h=sha256:0dEGpu+5OC750QFyrTXNnD5XTzn4dE9WmDdkwUY9cCI=:itydhWu1NgktY4WhwToR9q82X6aIYDRQkv5dsPsu+pQ=; X-ME-Sender: X-ME-Proxy-Cause: dmFkZTGKtv/0ANKjDg40Sw8CEUymGqXjjmpaqvC7zvrFp5nBZxkDBqLuiZJ/cE9cGA9KqB i8UHUsXp9uQyFcYOPQFrTLEygjnhao9+CkQTvm2Y4Zca7f49/BI62DJfRoiMbSE6yVxHrT +NPQ5hWi+AZBkWZKElVhjPau6njeHgyuZCDuYdNyRCnHwrCcY2bNaPRsMtcUGZwVLIwX9Q qLwZt1x/1z7gyCeKE3xaQQDFJtnEurEJJKQjw/gD9hQSQZVcX5tknzeULCduJCYwsdwcng kcV1DkjK/KKbIUEb1ulfbHsAhU6MX3zVmwoCsnjPDgeowJbEmQqbSND/m/m+tsKH04IvJJ 90lgFONmIQI+ymK3FiTcvmO4lADoyI82U5SEXAyAWFcb9808iG1uA5eBMdy5vIeJjw18a6 dofU6VCCK6cOe4P3fqC+kiLlyLvaxt0689dN8NsdXuxexi5aef0WR/oXfoBSsDYg8DZ/zY qwJsMmJupxIvIQT9lPgX4tVL73M6qCAFV6sKSGooyxRYR83FEpEAu+rx22iR/FJ0iw5U3l NDcyKy3hBBL+9uOabuCosbuaeREdr3Qv4pMIwmEDKDo20C5E/DoYO2krX/8b2vsS4S3Cq9 mTP8hBdn5unVCSBq6nd6gWEO3+r5h84P466RTvUHQpa/QKFNcDIKMEcG+dvA X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.ams.internal (Postfix, from userid 501) id 9BCC232A0093; Wed, 21 Oct 2026 13:02:52 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 X-ThreadId: AZo3noQSaVtc Date: Wed, 21 Oct 2026 19:02:32 +0200 From: "Arnd Bergmann" To: "Dmitry Torokhov" , "Bartosz Golaszewski" Cc: "Andy Shevchenko" , "Linus Walleij" , linux-input@vger.kernel.org, "open list:GPIO SUBSYSTEM" , linux-kernel@vger.kernel.org, "Hans de Goede" Message-Id: <9496ea3b-563f-4517-86d6-e20694e2ec9b@app.fastmail.com> In-Reply-To: References: <20261021015004.1537738-1-dmitry.torokhov@gmail.com> <20261021015004.1537738-3-dmitry.torokhov@gmail.com> Subject: Re: [PATCH 3/3] Input: soc_button_array - convert to software nodes Content-Type: text/plain Content-Transfer-Encoding: 7bit On Wed, Oct 21, 2026, at 18:56, Dmitry Torokhov wrote: > On Wed, Oct 21, 2026 at 05:11:32AM -0500, Bartosz Golaszewski wrote: >> > >> > - *gpio_ret = desc_to_gpio(desc); >> > + gdev = gpiod_to_gpio_device(desc); >> > + fwnode = dev_fwnode(gpio_device_to_device(gdev)); >> > + if (!fwnode) { >> > + gpiod_put(desc); >> > + return -ENODEV; >> > + } >> > + >> > + *gpio_ref = SOFTWARE_NODE_REFERENCE(fwnode, gpiod_hwgpio(desc), >> > + active_low ? GPIO_ACTIVE_LOW : >> > + GPIO_ACTIVE_HIGH); >> >> Sigh... I hate it and it looks hacky but I also don't have a better idea. :( > > Thanks, that is quite common reaction to the code I write ;) When I looked at this one in the past, the only other idea I had was to completely separate it from the regular gpio_keys driver and just make it a separate input driver. I think that would make this driver a bit cleaner, but it would also require a bit of code duplication and I can't tell if that is worth it. Arnd