From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA646C43217 for ; Wed, 16 Nov 2022 10:47:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231979AbiKPKrl (ORCPT ); Wed, 16 Nov 2022 05:47:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239106AbiKPKrU (ORCPT ); Wed, 16 Nov 2022 05:47:20 -0500 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50A8445EE3 for ; Wed, 16 Nov 2022 02:35:10 -0800 (PST) Received: by mail-wr1-x434.google.com with SMTP id cl5so29173828wrb.9 for ; Wed, 16 Nov 2022 02:35:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:reply-to:organization:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=sQgFoK8cOPk+aS6uvHgGsxqyaP/eeSCg5EmIN7/zyIQ=; b=oSgWTksrFOQyCIHLqT1fD98tKsflrC4rq+dc06OSRC7CEnIttQYkvjcdc+ebABf4Sm TjDupkAZLp/9qwNBxz/zpjab+P2h+MnZ7hZIk/NA3LtTgcoBkPWRVntiHRZ+K4uSg74/ wTSOpg0Mm8xTryJ4ML4Ld5jxZ3fBG6PtPqRhVrplc1NaKxuGlHC7FPaIQOYk8V9YMsSD +SIT2ra6pqrLlkPAk2qp+XmM/l0qf1wsRDiT/sshQn+bWVlO8FZazH1t3E9PCCEi64Yy LrFLB+6vtbuc0FyPvUdLJXEGXV8gtvxdfhyRG4xyRKtwfWZI/SPT6wLtMZH46bI8uTNA mqiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:reply-to:organization:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sQgFoK8cOPk+aS6uvHgGsxqyaP/eeSCg5EmIN7/zyIQ=; b=VEthdaxIsZskaCBUeXRFmYCJPPFJPATTLpIO7To0DE8twA9vat4upBjC33PQlGnQpM qBPWyMujVjkcZ5xsfl568IHZz3hCGiGyC7Fgd0PSLc/J/Q6jCWjsWmxrE12UIy88ciSF bHPJYHaOQrHY9G2K6xlxJzh+ri9B3zJ7x6TWEQT3sX4dH0LhQJpfvM6fhRjJ37D3N3j/ 5ZZjnUrFiOdhuRk/JpioqD+Oe0a7VzWlQKGXrWPdXOW5qqKVLa58eVVKfdidGp+HYytC 3wtnz5qGk2vaz98j5H+SmajVGq8k40uJ7M/NqoYbTAdJaA+EpzTT9EJpH1lZzsmWIfk4 iTkg== X-Gm-Message-State: ANoB5pmubZDl8gibbJG9ew7mEw2Nu+egemBzHV0/rPyl+b9qBxZNpOoa 85UVxZqOECX8W8ZOU8LtFXAgEA== X-Google-Smtp-Source: AA0mqf71a/71TLKyRyM8vG9iLuHPkKm/gjm9e18hX4KS/ptMHJEPv25qtY7A4tiwpbqv5x9+ukzfmA== X-Received: by 2002:a05:6000:1373:b0:236:c206:b2b1 with SMTP id q19-20020a056000137300b00236c206b2b1mr13293273wrz.624.1668594908845; Wed, 16 Nov 2022 02:35:08 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:2a03:71a6:7a9d:9c71? ([2a01:e0a:982:cbb0:2a03:71a6:7a9d:9c71]) by smtp.gmail.com with ESMTPSA id by11-20020a056000098b00b002258235bda3sm14842417wrb.61.2022.11.16.02.35.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Nov 2022 02:35:08 -0800 (PST) Message-ID: <9572fc1b-3b13-bb7b-bfdd-3e06a46dedf0@linaro.org> Date: Wed, 16 Nov 2022 11:35:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH 7/7] pinctrl: qcom: spmi-gpio: add support for pmr735d gpio control Content-Language: en-US To: Konrad Dybcio , Andy Gross , Rob Herring , Krzysztof Kozlowski , Bjorn Andersson , Lee Jones , Linus Walleij , Stephen Boyd Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org References: <20221114-narmstrong-sm8550-upstream-spmi-v1-0-6338a2b4b241@linaro.org> <20221114-narmstrong-sm8550-upstream-spmi-v1-7-6338a2b4b241@linaro.org> <16de0a02-e7d7-87d1-c877-e32de46bfc28@linaro.org> From: Neil Armstrong Organization: Linaro Developer Services Reply-To: neil.armstrong@linaro.org In-Reply-To: <16de0a02-e7d7-87d1-c877-e32de46bfc28@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi, On 16/11/2022 11:22, Konrad Dybcio wrote: > > > On 16/11/2022 11:11, Neil Armstrong wrote: >> Add support for the pmr735d gpio controller providing GPIO control over SPMI. >> >> Signed-off-by: Neil Armstrong >> --- > Any particular reason this could not be a part of the previous patch? I thought it would be cleaner splitting them by family names, but yeah they could be squashed, same for bindings. > > For the addition itself: > Reviewed-by: Konrad Dybcio Thanks! Neil > > Konrad >>   drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 + >>   1 file changed, 1 insertion(+) >> >> diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c >> index f758522d035e..66d6d7ffbd43 100644 >> --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c >> +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c >> @@ -1242,6 +1242,7 @@ static const struct of_device_id pmic_gpio_of_match[] = { >>       { .compatible = "qcom,pmp8074-gpio", .data = (void *) 12 }, >>       { .compatible = "qcom,pmr735a-gpio", .data = (void *) 4 }, >>       { .compatible = "qcom,pmr735b-gpio", .data = (void *) 4 }, >> +    { .compatible = "qcom,pmr735d-gpio", .data = (void *) 2 }, >>       /* pms405 has 12 GPIOs with holes on 1, 9, and 10 */ >>       { .compatible = "qcom,pms405-gpio", .data = (void *) 12 }, >>       /* pmx55 has 11 GPIOs with holes on 3, 7, 10, 11 */ >>