[PATCH 0/7] qcom: add support for SPMI PMICs found on SM8550 platforms

[PATCH 0/7] qcom: add support for SPMI PMICs found on SM8550 platforms

[Neil Armstrong]

The SM8550 based platforms sports a bunch of new PMICs:
- pm8550
- pm8550b
- pm8550ve
- pm8550vs
- pmk8550
- pmr735d
- pm8010

With GPIO support on:
- pm8550
- pm8550b
- pm8550ve
- pm8550vs
- pmk8550
- pmr735d

This documents bindings for those SPMI PMIC and adds compatible in the
PMIC pinctrl driver for GPIO support.

To: Andy Gross <agross@kernel.org>
To: Bjorn Andersson <andersson@kernel.org>
To: Konrad Dybcio <konrad.dybcio@somainline.org>
To: Lee Jones <lee@kernel.org>
To: Rob Herring <robh+dt@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
To: Stephen Boyd <sboyd@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>

---
Neil Armstrong (7):
      dt-bindings: mfd: qcom,spmi-pmic: document pm8550, pm8550b, pm8550ve, pm8550vs & pmk8550
      dt-bindings: mfd: qcom,spmi-pmic: document pm8010
      dt-bindings: mfd: qcom,spmi-pmic: document pmr735d
      dt-bindings: pinctrl: qcom,pmic-gpio: document pm8550, pm8550b, pm8550ve, pm8550vs & pmk8550
      dt-bindings: pinctrl: qcom,pmic-gpio: document pmr735d
      pinctrl: qcom: spmi-gpio: add support for pm8550 gpio control
      pinctrl: qcom: spmi-gpio: add support for pmr735d gpio control

 .../devicetree/bindings/mfd/qcom,spmi-pmic.yaml        |  7 +++++++
 .../devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml    | 18 ++++++++++++++++++
 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c               |  6 ++++++
 3 files changed, 31 insertions(+)
---
base-commit: 3c1f24109dfc4fb1a3730ed237e50183c6bb26b3
change-id: 20221114-narmstrong-sm8550-upstream-spmi-d2c999ec5dc1

Best regards,
-- 
Neil Armstrong <neil.armstrong@linaro.org>

[PATCH 1/7] dt-bindings: mfd: qcom,spmi-pmic: document pm8550, pm8550b, pm8550ve, pm8550vs & pmk8550

[Neil Armstrong]

Document compatible for the pm8550, pm8550b, pm8550ve, pm8550vs & pmk8550 SPMI PMICs

Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
index c01a00128eda..93e76d7f7814 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
@@ -55,6 +55,10 @@ properties:
           - qcom,pm8350
           - qcom,pm8350b
           - qcom,pm8350c
+          - qcom,pm8550
+          - qcom,pm8550b
+          - qcom,pm8550ve
+          - qcom,pm8550vs
           - qcom,pm8841
           - qcom,pm8909
           - qcom,pm8916
@@ -71,6 +75,7 @@ properties:
           - qcom,pmi8998
           - qcom,pmk8002
           - qcom,pmk8350
+          - qcom,pmk8550
           - qcom,pmm8155au
           - qcom,pmp8074
           - qcom,pmr735a

-- 
b4 0.10.1

Re: [PATCH 1/7] dt-bindings: mfd: qcom,spmi-pmic: document pm8550, pm8550b, pm8550ve, pm8550vs & pmk8550

[Krzysztof Kozlowski]

On 16/11/2022 11:11, Neil Armstrong wrote:
> Document compatible for the pm8550, pm8550b, pm8550ve, pm8550vs & pmk8550 SPMI PMICs

Please wrap commit message according to Linux coding style / submission
process:
https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586

> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---

With commit msg fixed:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

[PATCH 2/7] dt-bindings: mfd: qcom,spmi-pmic: document pm8010

[Neil Armstrong]

Document compatible for the pm8010 SPMI PMIC.

Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
index 93e76d7f7814..10a71a130987 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
@@ -44,6 +44,7 @@ properties:
           - qcom,pm8004
           - qcom,pm8005
           - qcom,pm8009
+          - qcom,pm8010
           - qcom,pm8019
           - qcom,pm8028
           - qcom,pm8110

-- 
b4 0.10.1

Re: [PATCH 2/7] dt-bindings: mfd: qcom,spmi-pmic: document pm8010

[Krzysztof Kozlowski]

On 16/11/2022 11:11, Neil Armstrong wrote:
> Document compatible for the pm8010 SPMI PMIC.
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>

I don't get why this is not part of previous. The previous patch already
documents 5 different PMICs in this file. This should be squashed.

Best regards,
Krzysztof

[PATCH 3/7] dt-bindings: mfd: qcom,spmi-pmic: document pmr735d

[Neil Armstrong]

Document compatible for the pmr735d SPMI PMIC.

Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
index 10a71a130987..5d4400ec8f28 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
@@ -81,6 +81,7 @@ properties:
           - qcom,pmp8074
           - qcom,pmr735a
           - qcom,pmr735b
+          - qcom,pmr735d
           - qcom,pms405
           - qcom,pmx55
           - qcom,pmx65

-- 
b4 0.10.1

Re: [PATCH 3/7] dt-bindings: mfd: qcom,spmi-pmic: document pmr735d

[Krzysztof Kozlowski]

On 16/11/2022 11:11, Neil Armstrong wrote:
> Document compatible for the pmr735d SPMI PMIC.
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---

I think this should be squashed.

Best regards,
Krzysztof

Re: [PATCH 3/7] dt-bindings: mfd: qcom,spmi-pmic: document pmr735d

[Neil Armstrong]

Hi,

On 16/11/2022 12:16, Krzysztof Kozlowski wrote:
> On 16/11/2022 11:11, Neil Armstrong wrote:
>> Document compatible for the pmr735d SPMI PMIC.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
> 
> I think this should be squashed.

I'll squash both 2 & 3 into 1, can I keep your Reviewed-by on 1 ?

Thanks,
Neil

> 
> Best regards,
> Krzysztof
> 

Re: [PATCH 3/7] dt-bindings: mfd: qcom,spmi-pmic: document pmr735d

[Krzysztof Kozlowski]

On 17/11/2022 08:42, Neil Armstrong wrote:
> Hi,
> 
> On 16/11/2022 12:16, Krzysztof Kozlowski wrote:
>> On 16/11/2022 11:11, Neil Armstrong wrote:
>>> Document compatible for the pmr735d SPMI PMIC.
>>>
>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>>> ---
>>
>> I think this should be squashed.
> 
> I'll squash both 2 & 3 into 1, can I keep your Reviewed-by on 1 ?

Yes.

Best regards,
Krzysztof

[PATCH 4/7] dt-bindings: pinctrl: qcom,pmic-gpio: document pm8550, pm8550b, pm8550ve, pm8550vs & pmk8550

[Neil Armstrong]

Document compatible, pin count & pin names for pm8550, pm8550b, pm8550ve,
pm8550vs & pmk8550 SPMI GPIO controllers.

Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 .../devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml       | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
index 29dd503f9522..a32e4b4566bb 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
@@ -40,6 +40,10 @@ properties:
           - qcom,pm8350b-gpio
           - qcom,pm8350c-gpio
           - qcom,pm8450-gpio
+          - qcom,pm8550-gpio
+          - qcom,pm8550b-gpio
+          - qcom,pm8550ve-gpio
+          - qcom,pm8550vs-gpio
           - qcom,pm8916-gpio
           - qcom,pm8917-gpio
           - qcom,pm8921-gpio
@@ -52,6 +56,7 @@ properties:
           - qcom,pmi8994-gpio
           - qcom,pmi8998-gpio
           - qcom,pmk8350-gpio
+          - qcom,pmk8550-gpio
           - qcom,pmm8155au-gpio
           - qcom,pmp8074-gpio
           - qcom,pmr735a-gpio
@@ -146,6 +151,8 @@ allOf:
             enum:
               - qcom,pm8018-gpio
               - qcom,pm8019-gpio
+              - qcom,pm8550vs-gpio
+              - qcom,pmk8550-gpio
     then:
       properties:
         gpio-line-names:
@@ -162,6 +169,7 @@ allOf:
             enum:
               - qcom,pm8226-gpio
               - qcom,pm8350b-gpio
+              - qcom,pm8550ve-gpio
               - qcom,pm8950-gpio
     then:
       properties:
@@ -236,6 +244,8 @@ allOf:
               - qcom,pm8038-gpio
               - qcom,pm8150b-gpio
               - qcom,pm8150l-gpio
+              - qcom,pm8550-gpio
+              - qcom,pm8550b-gpio
               - qcom,pmc8180c-gpio
               - qcom,pmp8074-gpio
               - qcom,pms405-gpio
@@ -411,6 +421,10 @@ $defs:
                  - gpio1-gpio8 for pm8350b
                  - gpio1-gpio9 for pm8350c
                  - gpio1-gpio4 for pm8450
+                 - gpio1-gpio12 for pm8550
+                 - gpio1-gpio12 for pm8550b
+                 - gpio1-gpio8 for pm8550ve
+                 - gpio1-gpio6 for pm8550vs
                  - gpio1-gpio38 for pm8917
                  - gpio1-gpio44 for pm8921
                  - gpio1-gpio36 for pm8941
@@ -421,6 +435,7 @@ $defs:
                  - gpio1-gpio2 for pmi8950
                  - gpio1-gpio10 for pmi8994
                  - gpio1-gpio4 for pmk8350
+                 - gpio1-gpio6 for pmk8550
                  - gpio1-gpio10 for pmm8155au
                  - gpio1-gpio12 for pmp8074 (holes on gpio1 and gpio12)
                  - gpio1-gpio4 for pmr735a

-- 
b4 0.10.1

Re: [PATCH 4/7] dt-bindings: pinctrl: qcom,pmic-gpio: document pm8550, pm8550b, pm8550ve, pm8550vs & pmk8550

[Krzysztof Kozlowski]

On 16/11/2022 11:11, Neil Armstrong wrote:
> Document compatible, pin count & pin names for pm8550, pm8550b, pm8550ve,
> pm8550vs & pmk8550 SPMI GPIO controllers.
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

[PATCH 5/7] dt-bindings: pinctrl: qcom,pmic-gpio: document pmr735d

[Neil Armstrong]

Document compatible, pin count & pin names for pmr735d.

Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
index a32e4b4566bb..db505fdeac86 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
@@ -61,6 +61,7 @@ properties:
           - qcom,pmp8074-gpio
           - qcom,pmr735a-gpio
           - qcom,pmr735b-gpio
+          - qcom,pmr735d-gpio
           - qcom,pms405-gpio
           - qcom,pmx55-gpio
           - qcom,pmx65-gpio
@@ -116,6 +117,7 @@ allOf:
             enum:
               - qcom,pm8008-gpio
               - qcom,pmi8950-gpio
+              - qcom,pmr735d-gpio
     then:
       properties:
         gpio-line-names:
@@ -440,6 +442,7 @@ $defs:
                  - gpio1-gpio12 for pmp8074 (holes on gpio1 and gpio12)
                  - gpio1-gpio4 for pmr735a
                  - gpio1-gpio4 for pmr735b
+                 - gpio1-gpio2 for pmr735d
                  - gpio1-gpio12 for pms405 (holes on gpio1, gpio9
                                             and gpio10)
                  - gpio1-gpio11 for pmx55 (holes on gpio3, gpio7, gpio10

-- 
b4 0.10.1

Re: [PATCH 5/7] dt-bindings: pinctrl: qcom,pmic-gpio: document pmr735d

[Krzysztof Kozlowski]

On 16/11/2022 11:11, Neil Armstrong wrote:
> Document compatible, pin count & pin names for pmr735d.
> 

Squash with previous.

Best regards,
Krzysztof

Re: [PATCH 5/7] dt-bindings: pinctrl: qcom,pmic-gpio: document pmr735d

[Neil Armstrong]

On 16/11/2022 12:17, Krzysztof Kozlowski wrote:
> On 16/11/2022 11:11, Neil Armstrong wrote:
>> Document compatible, pin count & pin names for pmr735d.
>>
> 
> Squash with previous.

I'll squash 5 into 4, can I keep your Reviewed-by on 4 ?

Thanks,
Neil

> 
> Best regards,
> Krzysztof
> 

Re: [PATCH 5/7] dt-bindings: pinctrl: qcom,pmic-gpio: document pmr735d

[Krzysztof Kozlowski]

On 17/11/2022 08:42, Neil Armstrong wrote:
> On 16/11/2022 12:17, Krzysztof Kozlowski wrote:
>> On 16/11/2022 11:11, Neil Armstrong wrote:
>>> Document compatible, pin count & pin names for pmr735d.
>>>
>>
>> Squash with previous.
> 
> I'll squash 5 into 4, can I keep your Reviewed-by on 4 ?

Yes.

Best regards,
Krzysztof

[PATCH 6/7] pinctrl: qcom: spmi-gpio: add support for pm8550 gpio control

[Neil Armstrong]

Add support for the pm8550, pm8550b, pm8550ve, pm8550vs & pmk8550 gpio
controllers providing GPIO control over SPMI.

Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
index 89695b5a2ce7..f758522d035e 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
@@ -1221,6 +1221,10 @@ static const struct of_device_id pmic_gpio_of_match[] = {
 	{ .compatible = "qcom,pm8350b-gpio", .data = (void *) 8 },
 	{ .compatible = "qcom,pm8350c-gpio", .data = (void *) 9 },
 	{ .compatible = "qcom,pm8450-gpio", .data = (void *) 4 },
+	{ .compatible = "qcom,pm8550-gpio", .data = (void *) 12 },
+	{ .compatible = "qcom,pm8550b-gpio", .data = (void *) 12 },
+	{ .compatible = "qcom,pm8550ve-gpio", .data = (void *) 8 },
+	{ .compatible = "qcom,pm8550vs-gpio", .data = (void *) 6 },
 	{ .compatible = "qcom,pm8916-gpio", .data = (void *) 4 },
 	{ .compatible = "qcom,pm8941-gpio", .data = (void *) 36 },
 	/* pm8950 has 8 GPIOs with holes on 3 */
@@ -1232,6 +1236,7 @@ static const struct of_device_id pmic_gpio_of_match[] = {
 	{ .compatible = "qcom,pmi8994-gpio", .data = (void *) 10 },
 	{ .compatible = "qcom,pmi8998-gpio", .data = (void *) 14 },
 	{ .compatible = "qcom,pmk8350-gpio", .data = (void *) 4 },
+	{ .compatible = "qcom,pmk8550-gpio", .data = (void *) 6 },
 	{ .compatible = "qcom,pmm8155au-gpio", .data = (void *) 10 },
 	/* pmp8074 has 12 GPIOs with holes on 1 and 12 */
 	{ .compatible = "qcom,pmp8074-gpio", .data = (void *) 12 },

-- 
b4 0.10.1

Re: [PATCH 6/7] pinctrl: qcom: spmi-gpio: add support for pm8550 gpio control

[Konrad Dybcio]

On 16/11/2022 11:11, Neil Armstrong wrote:
> Add support for the pm8550, pm8550b, pm8550ve, pm8550vs & pmk8550 gpio
> controllers providing GPIO control over SPMI.
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>   drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> index 89695b5a2ce7..f758522d035e 100644
> --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> @@ -1221,6 +1221,10 @@ static const struct of_device_id pmic_gpio_of_match[] = {
>   	{ .compatible = "qcom,pm8350b-gpio", .data = (void *) 8 },
>   	{ .compatible = "qcom,pm8350c-gpio", .data = (void *) 9 },
>   	{ .compatible = "qcom,pm8450-gpio", .data = (void *) 4 },
> +	{ .compatible = "qcom,pm8550-gpio", .data = (void *) 12 },
> +	{ .compatible = "qcom,pm8550b-gpio", .data = (void *) 12 },
> +	{ .compatible = "qcom,pm8550ve-gpio", .data = (void *) 8 },
> +	{ .compatible = "qcom,pm8550vs-gpio", .data = (void *) 6 },
>   	{ .compatible = "qcom,pm8916-gpio", .data = (void *) 4 },
>   	{ .compatible = "qcom,pm8941-gpio", .data = (void *) 36 },
>   	/* pm8950 has 8 GPIOs with holes on 3 */
> @@ -1232,6 +1236,7 @@ static const struct of_device_id pmic_gpio_of_match[] = {
>   	{ .compatible = "qcom,pmi8994-gpio", .data = (void *) 10 },
>   	{ .compatible = "qcom,pmi8998-gpio", .data = (void *) 14 },
>   	{ .compatible = "qcom,pmk8350-gpio", .data = (void *) 4 },
> +	{ .compatible = "qcom,pmk8550-gpio", .data = (void *) 6 },
>   	{ .compatible = "qcom,pmm8155au-gpio", .data = (void *) 10 },
>   	/* pmp8074 has 12 GPIOs with holes on 1 and 12 */
>   	{ .compatible = "qcom,pmp8074-gpio", .data = (void *) 12 },
> 

[PATCH 7/7] pinctrl: qcom: spmi-gpio: add support for pmr735d gpio control

[Neil Armstrong]

Add support for the pmr735d gpio controller providing GPIO control over SPMI.

Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
index f758522d035e..66d6d7ffbd43 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
@@ -1242,6 +1242,7 @@ static const struct of_device_id pmic_gpio_of_match[] = {
 	{ .compatible = "qcom,pmp8074-gpio", .data = (void *) 12 },
 	{ .compatible = "qcom,pmr735a-gpio", .data = (void *) 4 },
 	{ .compatible = "qcom,pmr735b-gpio", .data = (void *) 4 },
+	{ .compatible = "qcom,pmr735d-gpio", .data = (void *) 2 },
 	/* pms405 has 12 GPIOs with holes on 1, 9, and 10 */
 	{ .compatible = "qcom,pms405-gpio", .data = (void *) 12 },
 	/* pmx55 has 11 GPIOs with holes on 3, 7, 10, 11 */

-- 
b4 0.10.1

Re: [PATCH 7/7] pinctrl: qcom: spmi-gpio: add support for pmr735d gpio control

[Konrad Dybcio]

On 16/11/2022 11:11, Neil Armstrong wrote:
> Add support for the pmr735d gpio controller providing GPIO control over SPMI.
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
Any particular reason this could not be a part of the previous patch?

For the addition itself:
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>   drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> index f758522d035e..66d6d7ffbd43 100644
> --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> @@ -1242,6 +1242,7 @@ static const struct of_device_id pmic_gpio_of_match[] = {
>   	{ .compatible = "qcom,pmp8074-gpio", .data = (void *) 12 },
>   	{ .compatible = "qcom,pmr735a-gpio", .data = (void *) 4 },
>   	{ .compatible = "qcom,pmr735b-gpio", .data = (void *) 4 },
> +	{ .compatible = "qcom,pmr735d-gpio", .data = (void *) 2 },
>   	/* pms405 has 12 GPIOs with holes on 1, 9, and 10 */
>   	{ .compatible = "qcom,pms405-gpio", .data = (void *) 12 },
>   	/* pmx55 has 11 GPIOs with holes on 3, 7, 10, 11 */
> 

Re: [PATCH 7/7] pinctrl: qcom: spmi-gpio: add support for pmr735d gpio control

[Neil Armstrong]

Hi,

On 16/11/2022 11:22, Konrad Dybcio wrote:
> 
> 
> On 16/11/2022 11:11, Neil Armstrong wrote:
>> Add support for the pmr735d gpio controller providing GPIO control over SPMI.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
> Any particular reason this could not be a part of the previous patch?

I thought it would be cleaner splitting them by family names, but yeah they could be squashed, same for bindings.

> 
> For the addition itself:
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Thanks!
Neil
> 
> Konrad
>>   drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
>> index f758522d035e..66d6d7ffbd43 100644
>> --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
>> +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
>> @@ -1242,6 +1242,7 @@ static const struct of_device_id pmic_gpio_of_match[] = {
>>       { .compatible = "qcom,pmp8074-gpio", .data = (void *) 12 },
>>       { .compatible = "qcom,pmr735a-gpio", .data = (void *) 4 },
>>       { .compatible = "qcom,pmr735b-gpio", .data = (void *) 4 },
>> +    { .compatible = "qcom,pmr735d-gpio", .data = (void *) 2 },
>>       /* pms405 has 12 GPIOs with holes on 1, 9, and 10 */
>>       { .compatible = "qcom,pms405-gpio", .data = (void *) 12 },
>>       /* pmx55 has 11 GPIOs with holes on 3, 7, 10, 11 */
>>