Re: [PATCH v2] microblaze: Switch to standard restart handler

[Michal Simek <monstr@monstr.eu>]

[-- Attachment #1.1: Type: text/plain, Size: 1532 bytes --]

On 23. 08. 19 13:19, Linus Walleij wrote:
> On Fri, Aug 23, 2019 at 12:56 PM Michal Simek <monstr@monstr.eu> wrote:
> 
>>> +void machine_restart(char *cmd)
>>> +{
>>> +     do_kernel_restart(cmd);
>>> +     /* Give the restart hook 1 s to take us down */
>>> +     mdelay(1000);
>>> +     pr_emerg("Reboot failed -- System halted\n");
>>> +     while (1);
>>> +}
>>> +
>>>  /*
>>>   * MMU_init sets up the basic memory mappings for the kernel,
>>>   * including both RAM and possibly some I/O regions,
>>>
>>
>> I will test this for sure. What's the reason to add machine_restart to
>> mm/ folder? You can simply keep it in a location where it was.
> 
> It is because the three calls to machine_restart() were in this
> file and therefore I just put it in proximity.
> 
> I can move it.
> 
>> Do you know why of_find_gpio can failed in connection to gpio-xilinx driver?
> 
> The only reason it'd fail would be if the module is not compiled
> in, or deferred probe happens, but then -EPROBE_DEFER
> would be returned I think.

I have retest it. I have done one dt issue that was the reason why it
didn't work.

Please move that machine_restart() back to reset.c and then I will apply
this patch.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]