RE: [linusw-pinctrl:devel] BUILD SUCCESS WITH WARNING e8b4ff6a856d02ee64a6023edf45e11827badeef

["TY_Chang[張子逸]" <tychang@realtek.com>]

Hi Linus,

Sorry for the delayed response. I was out of the office in the past few weeks.

>
>Tzuyi, can you look at this, I understand some of the warnings but not all, and I need
>HW knowledge to fix the compile warnings:
>
>On Fri, Sep 29, 2023 at 10:04 AM kernel test robot <lkp@intel.com> wrote:
>
>
>> drivers/pinctrl/realtek/pinctrl-rtd.c:180:29: warning: '%s' directive
>> argument is null [-Wformat-overflow=]
>
>I don't understand this at all.
>
>> drivers/pinctrl/realtek/pinctrl-rtd1315e.c:231:35: warning:
>> 'rtd1315e_boot_sel_pins' defined but not used
>> [-Wunused-const-variable=]
>> drivers/pinctrl/realtek/pinctrl-rtd1315e.c:231:35: warning:
>> 'rtd1315e_reset_n_pins' defined but not used
>> [-Wunused-const-variable=]
>> drivers/pinctrl/realtek/pinctrl-rtd1315e.c:231:35: warning:
>> 'rtd1315e_scan_switch_pins' defined but not used
>> [-Wunused-const-variable=]
>> drivers/pinctrl/realtek/pinctrl-rtd1315e.c:231:35: warning:
>> 'rtd1315e_testmode_pins' defined but not used
>> [-Wunused-const-variable=]
>> drivers/pinctrl/realtek/pinctrl-rtd1315e.c:231:35: warning:
>> 'rtd1315e_wd_rset_pins' defined but not used
>> [-Wunused-const-variable=]
>> drivers/pinctrl/realtek/pinctrl-rtd1319d.c:237:35: warning:
>> 'rtd1319d_boot_sel_pins' defined but not used
>> [-Wunused-const-variable=]
>> drivers/pinctrl/realtek/pinctrl-rtd1319d.c:237:35: warning:
>> 'rtd1319d_reset_n_pins' defined but not used
>> [-Wunused-const-variable=]
>> drivers/pinctrl/realtek/pinctrl-rtd1319d.c:237:35: warning:
>> 'rtd1319d_scan_switch_pins' defined but not used
>> [-Wunused-const-variable=]
>> drivers/pinctrl/realtek/pinctrl-rtd1319d.c:237:35: warning:
>> 'rtd1319d_testmode_pins' defined but not used
>> [-Wunused-const-variable=]
>> drivers/pinctrl/realtek/pinctrl-rtd1319d.c:237:35: warning:
>> 'rtd1319d_wd_rset_pins' defined but not used
>> [-Wunused-const-variable=]
>
>These appear because there are for example:
>DECLARE_RTD1315E_PIN(RTD1315E_ISO_BOOT_SEL, boot_sel); But no
>corresponding RTD1315E_GROUP().
>
>Can you make a patch adding the missing groups?
>

Those pins are the actual hardware pins on the chips, but they are not currently in use. I forgot to add the groups for them. I'm sorry about that.
I think the patch you've applied in the following link is also a solution. Thank you.
https://patchwork.ozlabs.org/project/linux-gpio/patch/20231006-fix-realtek-warnings-v1-1-09af253312ba@linaro.org/

Thanks,
Tzuyi Chang