From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45DBCC32751 for ; Wed, 31 Jul 2019 10:24:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 13ADA206A2 for ; Wed, 31 Jul 2019 10:24:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h+yp2QmS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728372AbfGaKYi (ORCPT ); Wed, 31 Jul 2019 06:24:38 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:44785 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728098AbfGaKYh (ORCPT ); Wed, 31 Jul 2019 06:24:37 -0400 Received: by mail-lj1-f195.google.com with SMTP id k18so65021622ljc.11; Wed, 31 Jul 2019 03:24:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4wbFrUhwSZhSBB6U6Ki77cOMzfNvzSyCtvzc41Wmfrs=; b=h+yp2QmSXIM48MQRFzv5zRbSva5VUmYs41Vxw4y54hacTBj+MzM4Z6RbVI496Gfoc/ z0NyNPo768xHwZLwaTTfP0nyy/wj5KOhOzAdGoEhqGScK2WpgM3yYGFsA1Dh0UdZNNWB 1QwIU6BPkukn5okMTIx45bekP0ZSqSNAD3DZuVmDCdfsNs8MAGZSk/Em3ZEYvFDIPUTa 1egvkdfI7YJ+e25A8PMCHvPArKwlOFwUoO15Q2xSTXOvQNz1K6CwOg9eOdyZu+k4cFBU 68Fa75NZz21avrmuwdVJPvi9qZ8mucm4VfxJqcDv6K9lCD8XniZ8F7OIO56AiVt+fION XSNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4wbFrUhwSZhSBB6U6Ki77cOMzfNvzSyCtvzc41Wmfrs=; b=Ow0H6TiimDBMqKA9QPs8WTJylZ6S450fGAo5l+bApunE2jKF3kUtQ39ECcTqPnwKCm 4inND7ltB6jAGVNgIR0smAZzYlvPejE18xUMheSPjBkfQ3moM7z7dkMq33MWVHo+l/oF CMjnE3RYjOoSDjJipRqlRu7zEoEK52QSK58XrrPXENNJ7VTPxn3NG1/S84reBlQM31aj gpqQyWzABNRbzKcsGU5fWpaLAnqyoVUr08mhc7gqQtA8CZz6tsBkF6xqyDuwgb+3tcxm yvvcWA4amGO2Jq5BaxorF3TAvibegM+X2RAmhGcp0/NpIc/BTOa9z1DV0re6ZjIB7bU6 LWPw== X-Gm-Message-State: APjAAAWn1QFteMm/w+A6RUQ7layZh0vFFv+hDBOc2fUPjNSVydTt0/nU QdbM4GorrQJIw68L5sgge958NCke X-Google-Smtp-Source: APXvYqzzbrgS4hOSsnwhVVhLNxPeQJ78gQla7pnQDMATjIRLUYeUKR3EbzlC/Nz1V10dhO0EZUOH1w== X-Received: by 2002:a2e:8ecb:: with SMTP id e11mr5868831ljl.218.1564568674761; Wed, 31 Jul 2019 03:24:34 -0700 (PDT) Received: from [192.168.2.145] (ppp91-78-220-99.pppoe.mtu-net.ru. [91.78.220.99]) by smtp.googlemail.com with ESMTPSA id x137sm11625734lff.23.2019.07.31.03.24.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 Jul 2019 03:24:34 -0700 (PDT) Subject: Re: [PATCH v7 11/20] cpufreq: tegra124: Add suspend and resume support To: Sowjanya Komatineni , thierry.reding@gmail.com, jonathanh@nvidia.com, tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com, linus.walleij@linaro.org, stefan@agner.ch, mark.rutland@arm.com Cc: pdeschrijver@nvidia.com, pgaikwad@nvidia.com, sboyd@kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, jckuo@nvidia.com, josephl@nvidia.com, talho@nvidia.com, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, mperttunen@nvidia.com, spatra@nvidia.com, robh+dt@kernel.org, devicetree@vger.kernel.org References: <1564532424-10449-1-git-send-email-skomatineni@nvidia.com> <1564532424-10449-12-git-send-email-skomatineni@nvidia.com> From: Dmitry Osipenko Message-ID: <98aae4b7-d95a-90ba-0d55-7512b3712f54@gmail.com> Date: Wed, 31 Jul 2019 13:23:37 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <1564532424-10449-12-git-send-email-skomatineni@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org 31.07.2019 3:20, Sowjanya Komatineni пишет: > This patch adds suspend and resume pm ops for cpufreq driver. > > PLLP is the safe clock source for CPU during system suspend and > resume as PLLP rate is below the CPU Fmax at Vmin. > > CPUFreq driver suspend switches the CPU clock source to PLLP and > disables the DFLL clock. > > During system resume, warmboot code powers up the CPU with PLLP > clock source. So CPUFreq driver resume enabled DFLL clock and > switches CPU back to DFLL clock source. > > Signed-off-by: Sowjanya Komatineni > --- > drivers/cpufreq/tegra124-cpufreq.c | 60 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 60 insertions(+) > > diff --git a/drivers/cpufreq/tegra124-cpufreq.c b/drivers/cpufreq/tegra124-cpufreq.c > index 4f0c637b3b49..e979a3370988 100644 > --- a/drivers/cpufreq/tegra124-cpufreq.c > +++ b/drivers/cpufreq/tegra124-cpufreq.c > @@ -6,6 +6,7 @@ > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > #include > +#include > #include > #include > #include > @@ -128,8 +129,67 @@ static int tegra124_cpufreq_probe(struct platform_device *pdev) > return ret; > } > > +static int __maybe_unused tegra124_cpufreq_suspend(struct device *dev) > +{ > + struct tegra124_cpufreq_priv *priv = dev_get_drvdata(dev); > + int err; > + > + /* > + * PLLP rate 408Mhz is below the CPU Fmax at Vmin and is safe to > + * use during suspend and resume. So, switch the CPU clock source > + * to PLLP and disable DFLL. > + */ > + err = clk_set_parent(priv->cpu_clk, priv->pllp_clk); > + if (err < 0) { > + dev_err(dev, "failed to reparent to PLLP: %d\n", err); > + return err; > + } > + > + /* disable DFLL clock */ > + clk_disable_unprepare(priv->dfll_clk); > + > + return 0; > +} > + > +static int __maybe_unused tegra124_cpufreq_resume(struct device *dev) > +{ > + struct tegra124_cpufreq_priv *priv = dev_get_drvdata(dev); > + int err; > + > + /* > + * Warmboot code powers up the CPU with PLLP clock source. > + * Enable DFLL clock and switch CPU clock source back to DFLL. > + */ > + err = clk_prepare_enable(priv->dfll_clk); > + if (err < 0) { > + dev_err(dev, "failed to enable DFLL clock for CPU: %d\n", err); > + goto disable_cpufreq; > + } > + > + err = clk_set_parent(priv->cpu_clk, priv->dfll_clk); > + if (err < 0) { > + dev_err(dev, "failed to reparent to DFLL clock: %d\n", err); > + goto disable_dfll; > + } > + > + return 0; > + > +disable_dfll: > + clk_disable_unprepare(priv->dfll_clk); > +disable_cpufreq: > + disable_cpufreq(); > + > + return err; > +} > + > +static const struct dev_pm_ops tegra124_cpufreq_pm_ops = { > + SET_SYSTEM_SLEEP_PM_OPS(tegra124_cpufreq_suspend, > + tegra124_cpufreq_resume) > +}; > + > static struct platform_driver tegra124_cpufreq_platdrv = { > .driver.name = "cpufreq-tegra124", > + .driver.pm = &tegra124_cpufreq_pm_ops, > .probe = tegra124_cpufreq_probe, > }; > > Looks good, Reviewed-by: Dmitry Osipenko