From: Jia-Ju Bai <baijiaju1990@gmail.com>
To: Shaokun Zhang <zhangshaokun@hisilicon.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH -next] gpio: Remove the unused flags
Date: Wed, 15 Jan 2020 09:34:48 +0800 [thread overview]
Message-ID: <9bb9cc43-444d-3084-4d67-419dde9d67b5@gmail.com> (raw)
In-Reply-To: <1579009062-7154-1-git-send-email-zhangshaokun@hisilicon.com>
On 2020/1/14 21:37, Shaokun Zhang wrote:
> drivers/gpio/gpio-grgpio.c: In function ‘grgpio_remove’:
> drivers/gpio/gpio-grgpio.c:438:16: warning: unused variable ‘flags’ [-Wunused-variable]
> unsigned long flags;
> ^
> Fixes: 25d071b3f6db ("gpio: gpio-grgpio: fix possible sleep-in-atomic-context bugs in grgpio_remove()")
> Cc: Jia-Ju Bai <baijiaju1990@gmail.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
> ---
> drivers/gpio/gpio-grgpio.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-grgpio.c b/drivers/gpio/gpio-grgpio.c
> index 1922adf96fc9..f954359c9544 100644
> --- a/drivers/gpio/gpio-grgpio.c
> +++ b/drivers/gpio/gpio-grgpio.c
> @@ -435,7 +435,6 @@ static int grgpio_probe(struct platform_device *ofdev)
> static int grgpio_remove(struct platform_device *ofdev)
> {
> struct grgpio_priv *priv = platform_get_drvdata(ofdev);
> - unsigned long flags;
> int i;
> int ret = 0;
>
Reviewed-by: Jia-Ju Bai <baijiaju1990@gmail.com>
next prev parent reply other threads:[~2020-01-15 1:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 13:37 [PATCH -next] gpio: Remove the unused flags Shaokun Zhang
2020-01-14 14:10 ` Bartosz Golaszewski
2020-01-15 1:34 ` Jia-Ju Bai [this message]
2020-01-15 10:25 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bb9cc43-444d-3084-4d67-419dde9d67b5@gmail.com \
--to=baijiaju1990@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).