From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EEB0C76191 for ; Sun, 21 Jul 2019 22:09:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 128BD206BF for ; Sun, 21 Jul 2019 22:09:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lnIRZ8TJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726952AbfGUWJO (ORCPT ); Sun, 21 Jul 2019 18:09:14 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:38535 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725989AbfGUWJO (ORCPT ); Sun, 21 Jul 2019 18:09:14 -0400 Received: by mail-lf1-f68.google.com with SMTP id h28so25155561lfj.5; Sun, 21 Jul 2019 15:09:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3rTzL5QATtobDUnSqUYyJdUPDYJjvS1OkcV6MfOW5EQ=; b=lnIRZ8TJc/Z9gKrm686ayagpOlg44fo4607fLcEjbCTkiG+83wQ8GsZDUycQyHwKgt V6tnloqzvwoLBfXH2gGOJg74DZFzA2eU1H1H6nmU7RIq9XIWJqfAOh/Ce4zpd5q0hdVX ErBqRv6t1Y7FhoaEzpmmpapZSQynyp2B0tpdlqPLMDD6k0ZDoN0qF+tPu0ozyN8XxBzR E9UqzrldyrifLTgMC25n0N3uz9UpS43DjGb8rIbpb6fyPQUFFSdalEbzDQSD4PEsalVk g0FZCZjDTgBJph2c7kX3Nxrse8+JG5kB5QOk6McvTbASElOnhc8m5T7SQk94hxKear2S JD0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3rTzL5QATtobDUnSqUYyJdUPDYJjvS1OkcV6MfOW5EQ=; b=B3e9MKug3QM71yoKKZfAnxCkhFuyQ8Nvsl7Mk54zsN6+0y55MAWd1pcFCgWiqxIjD9 pRF/Y7vmOLjksoOLJ6w3AnYRlZ6Yjq4NN7iNxL9iSOAQ5zRdWn8hmJsKtDz5lMbag0MF p47LtdYBCmEnUZinYZEWeZtsKaKx+Aaa9MWARFGVaBbmyos3lBWTuvzGxY8DiJJpjyJD hIbCWoWyVFbQI4/4W/iOeHRR6dCbk0S0aFBk2KpSkhzgCcmsr77Zf3tsFO7f5Vp6aXZE oAm4h44obSHFfqFCyGP9Qkz2XbAXcN5xxo3mZ5j3+2XMw8YMT4n07G4rjmzRnLNH1tsC sboQ== X-Gm-Message-State: APjAAAWK8m9J5unWKiUV/cDW5sH0LXhdwNrffE4+CFyXAyFpkTiNAMs3 DfEDuEXSYxI1K+/dOdRnmSgBZdQ9 X-Google-Smtp-Source: APXvYqwWrH63kDOfQl/lL+jLdHQWBn2t7g5nppBxCuLdr2WXP0tKIoIOlZmXUlpXgPdhDmerlhrhMQ== X-Received: by 2002:ac2:4c84:: with SMTP id d4mr30028072lfl.1.1563746950588; Sun, 21 Jul 2019 15:09:10 -0700 (PDT) Received: from [192.168.2.145] (ppp91-78-220-99.pppoe.mtu-net.ru. [91.78.220.99]) by smtp.googlemail.com with ESMTPSA id z22sm7263982ljz.20.2019.07.21.15.09.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 Jul 2019 15:09:09 -0700 (PDT) Subject: Re: [PATCH V6 02/21] pinctrl: tegra: Add suspend and resume support From: Dmitry Osipenko To: Sowjanya Komatineni , thierry.reding@gmail.com, jonathanh@nvidia.com, tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com, linus.walleij@linaro.org, stefan@agner.ch, mark.rutland@arm.com Cc: pdeschrijver@nvidia.com, pgaikwad@nvidia.com, sboyd@kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, jckuo@nvidia.com, josephl@nvidia.com, talho@nvidia.com, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, mperttunen@nvidia.com, spatra@nvidia.com, robh+dt@kernel.org, devicetree@vger.kernel.org References: <1563738060-30213-1-git-send-email-skomatineni@nvidia.com> <1563738060-30213-3-git-send-email-skomatineni@nvidia.com> Message-ID: <9c844d55-0bc0-471c-6c49-1febe799ebf2@gmail.com> Date: Mon, 22 Jul 2019 01:09:08 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org 22.07.2019 1:03, Dmitry Osipenko пишет: > 21.07.2019 22:40, Sowjanya Komatineni пишет: >> This patch adds support for Tegra pinctrl driver suspend and resume. >> >> During suspend, context of all pinctrl registers are stored and >> on resume they are all restored to have all the pinmux and pad >> configuration for normal operation. >> >> Acked-by: Thierry Reding >> Signed-off-by: Sowjanya Komatineni >> --- >> drivers/pinctrl/tegra/pinctrl-tegra.c | 59 +++++++++++++++++++++++++++++++++++ >> drivers/pinctrl/tegra/pinctrl-tegra.h | 3 ++ >> 2 files changed, 62 insertions(+) >> >> diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegra/pinctrl-tegra.c >> index 186ef98e7b2b..e3a237534281 100644 >> --- a/drivers/pinctrl/tegra/pinctrl-tegra.c >> +++ b/drivers/pinctrl/tegra/pinctrl-tegra.c >> @@ -631,6 +631,58 @@ static void tegra_pinctrl_clear_parked_bits(struct tegra_pmx *pmx) >> } >> } >> >> +static size_t tegra_pinctrl_get_bank_size(struct device *dev, >> + unsigned int bank_id) >> +{ >> + struct platform_device *pdev = to_platform_device(dev); >> + struct resource *res; >> + >> + res = platform_get_resource(pdev, IORESOURCE_MEM, bank_id); >> + >> + return resource_size(res) / 4; >> +} >> + >> +static int tegra_pinctrl_suspend(struct device *dev) >> +{ >> + struct tegra_pmx *pmx = dev_get_drvdata(dev); >> + u32 *backup_regs = pmx->backup_regs; >> + u32 *regs; >> + size_t bank_size; >> + unsigned int i, k; >> + >> + for (i = 0; i < pmx->nbanks; i++) { >> + bank_size = tegra_pinctrl_get_bank_size(dev, i); >> + regs = pmx->regs[i]; >> + for (k = 0; k < bank_size; k++) >> + *backup_regs++ = readl_relaxed(regs++); >> + } >> + >> + return pinctrl_force_sleep(pmx->pctl); >> +} >> + >> +static int tegra_pinctrl_resume(struct device *dev) >> +{ >> + struct tegra_pmx *pmx = dev_get_drvdata(dev); >> + u32 *backup_regs = pmx->backup_regs; >> + u32 *regs; >> + size_t bank_size; >> + unsigned int i, k; >> + >> + for (i = 0; i < pmx->nbanks; i++) { >> + bank_size = tegra_pinctrl_get_bank_size(dev, i); >> + regs = pmx->regs[i]; >> + for (k = 0; k < bank_size; k++) >> + writel_relaxed(*backup_regs++, regs++); >> + } >> + >> + return 0; >> +} >> + >> +const struct dev_pm_ops tegra_pinctrl_pm = { >> + .suspend = &tegra_pinctrl_suspend, >> + .resume = &tegra_pinctrl_resume >> +}; >> + >> static bool gpio_node_has_range(const char *compatible) >> { >> struct device_node *np; >> @@ -655,6 +707,7 @@ int tegra_pinctrl_probe(struct platform_device *pdev, >> int i; >> const char **group_pins; >> int fn, gn, gfn; >> + unsigned long backup_regs_size = 0; >> >> pmx = devm_kzalloc(&pdev->dev, sizeof(*pmx), GFP_KERNEL); >> if (!pmx) >> @@ -707,6 +760,7 @@ int tegra_pinctrl_probe(struct platform_device *pdev, >> res = platform_get_resource(pdev, IORESOURCE_MEM, i); >> if (!res) >> break; >> + backup_regs_size += resource_size(res); >> } >> pmx->nbanks = i; >> >> @@ -715,6 +769,11 @@ int tegra_pinctrl_probe(struct platform_device *pdev, >> if (!pmx->regs) >> return -ENOMEM; >> >> + pmx->backup_regs = devm_kzalloc(&pdev->dev, backup_regs_size, >> + GFP_KERNEL); >> + if (!pmx->backup_regs) >> + return -ENOMEM; >> + >> for (i = 0; i < pmx->nbanks; i++) { >> res = platform_get_resource(pdev, IORESOURCE_MEM, i); >> pmx->regs[i] = devm_ioremap_resource(&pdev->dev, res); >> diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.h b/drivers/pinctrl/tegra/pinctrl-tegra.h >> index 105309774079..0fc82eea9cf1 100644 >> --- a/drivers/pinctrl/tegra/pinctrl-tegra.h >> +++ b/drivers/pinctrl/tegra/pinctrl-tegra.h >> @@ -17,6 +17,7 @@ struct tegra_pmx { >> >> int nbanks; >> void __iomem **regs; >> + u32 *backup_regs; >> }; >> >> enum tegra_pinconf_param { >> @@ -193,6 +194,8 @@ struct tegra_pinctrl_soc_data { >> bool drvtype_in_mux; >> }; >> >> +extern const struct dev_pm_ops tegra_pinctrl_pm; >> + >> int tegra_pinctrl_probe(struct platform_device *pdev, >> const struct tegra_pinctrl_soc_data *soc_data); >> #endif >> > > Reviewed-by: Dmitry Osipenko > BTW, you should remove Thierry's ACK from all patches that were modified if he didn't re-ACK the new version. Also, it looks to me that you're manually adding versioning to the patches because git usually uses lowercase for 'v'. You could use "git format-patch -v6 ..".