From: Krzysztof Kozlowski <krzk@kernel.org>
To: Kaustabh Chakraborty <kauschluss@disroot.org>
Cc: Rob Herring <robh@kernel.org>, Conor Dooley <conor@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Tomasz Figa <tomasz.figa@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>, Lee Jones <lee@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Andi Shyti <andi.shyti@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Jaehoon Chung <jh80.chung@samsung.com>,
Vivek Gautam <gautam.vivek@samsung.com>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Kees Cook <kees@kernel.org>, Tony Luck <tony.luck@intel.com>,
"Guilherme G . Piccoli" <gpiccoli@igalia.com>,
Sergey Lisov <sleirsgoevy@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-serial@vger.kernel.org, linux-phy@lists.infradead.org,
linux-usb@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-i2c@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH 02/33] dt-bindings: clock: add clock definitions for exynos7870 CMU
Date: Mon, 3 Feb 2025 15:01:22 +0100 [thread overview]
Message-ID: <9c8a9dee-92ba-47e4-b16b-ab47727d8057@kernel.org> (raw)
In-Reply-To: <c1249f2f6ac8a2f5a1dcb3bbbba647f9@disroot.org>
On 03/02/2025 13:40, Kaustabh Chakraborty wrote:
> On 2025-02-03 07:54, Krzysztof Kozlowski wrote:
>> On Mon, Feb 03, 2025 at 12:37:58AM +0530, Kaustabh Chakraborty wrote:
>>> From: Sergey Lisov <sleirsgoevy@gmail.com>
>>>
>>> Add unique identifiers for exynos7870 clocks for every bank. It adds all
>>> clocks of CMU_MIF, CMU_DISPAUD, CMU_G3D, CMU_ISP, CMU_MFCMSCL, and
>>> CMU_PERI.
>>>
>>> Signed-off-by: Sergey Lisov <sleirsgoevy@gmail.com>
>>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
>>> ---
>>> include/dt-bindings/clock/exynos7870.h | 324 +++++++++++++++++++++++++
>>> 1 file changed, 324 insertions(+)
>>
>> Look at git log - that's never a separate commit.
>
> Hmm, I see past examples which are mixed.
>
> 2ae5c2c3f8d586b709cf67efe94488be397d7544
> Exynos850 CMU (c. 2021). CMU definitions are in a separate commit.
>
> 591020a516720e9eba1c4b1748cb73b6748e445f
> Exynos7885 CMU (c. 2021). CMU definitions are in a separate commit.
>
Huh, indeed, my mistake.
Let's avoid that pattern, so binding headers are always part of bindings
commit.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-02-03 14:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-02 18:36 [PATCH 00/33] Add support for the Exynos7870 SoC, along with three devices Kaustabh Chakraborty
2025-02-02 18:36 ` [PATCH 01/33] dt-bindings: hwinfo: samsung,exynos-chipid: add exynos7870-chipid compatible Kaustabh Chakraborty
2025-02-03 7:54 ` Krzysztof Kozlowski
2025-02-02 19:03 ` [PATCH 02/34] " Kaustabh Chakraborty
2025-02-03 7:53 ` Krzysztof Kozlowski
2025-02-02 19:04 ` [PATCH 03/34] dt-bindings: clock: add clock definitions for exynos7870 CMU Kaustabh Chakraborty
2025-02-02 19:07 ` [PATCH 02/33] " Kaustabh Chakraborty
2025-02-03 7:54 ` Krzysztof Kozlowski
2025-02-03 12:40 ` Kaustabh Chakraborty
2025-02-03 14:01 ` Krzysztof Kozlowski [this message]
2025-02-02 19:09 ` [PATCH 03/33] dt-bindings: clock: document exynos7870 clock driver CMU bindings Kaustabh Chakraborty
2025-02-03 7:57 ` Krzysztof Kozlowski
2025-02-02 19:13 ` [PATCH 00/33] Add support for the Exynos7870 SoC, along with three devices Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c8a9dee-92ba-47e4-b16b-ab47727d8057@kernel.org \
--to=krzk@kernel.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=airlied@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=andi.shyti@kernel.org \
--cc=broonie@kernel.org \
--cc=conor@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gautam.vivek@samsung.com \
--cc=gpiccoli@igalia.com \
--cc=gregkh@linuxfoundation.org \
--cc=jh80.chung@samsung.com \
--cc=jirislaby@kernel.org \
--cc=kauschluss@disroot.org \
--cc=kees@kernel.org \
--cc=kishon@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=simona@ffwll.ch \
--cc=sleirsgoevy@gmail.com \
--cc=tomasz.figa@gmail.com \
--cc=tony.luck@intel.com \
--cc=tzimmermann@suse.de \
--cc=ulf.hansson@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).