From: Antonio Borneo <antonio.borneo@foss.st.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Conor Dooley <conor@kernel.org>, Rob Herring <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Bartosz Golaszewski <brgl@bgdev.pl>, <linux-gpio@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
Christophe Roullier <christophe.roullier@foss.st.com>,
Fabien Dessenne <fabien.dessenne@foss.st.com>,
Valentin Caron <valentin.caron@foss.st.com>
Subject: Re: [PATCH v3 09/10] dt-bindings: pinctrl: stm32: Support I/O synchronization parameters
Date: Tue, 21 Oct 2025 13:49:35 +0200 [thread overview]
Message-ID: <9dfdf02b7e5a99c515aff3c6528e2d5f70517201.camel@foss.st.com> (raw)
In-Reply-To: <CACRpkdbeaiNGfOFfVfDNZ=u=4yhCykcdSdHUv-td_DVyr3aWaQ@mail.gmail.com>
On Tue, 2025-10-21 at 00:08 +0200, Linus Walleij wrote:
> On Mon, Oct 20, 2025 at 5:09 PM Antonio Borneo
> <antonio.borneo@foss.st.com> wrote:
>
> > pinconf-generic only accepts positive numeric values for
> > both generic and custom properties in struct pinconf_generic_params.
>
> Do you need it to support negative values?
No, the point is not the sign, but the value that has to be numeric. More details below.
> Patches welcome!
>
> > Plus, I haven't found any existing driver that mixes pinconf-generic with
> > custom string values.
>
> Maybe I misunderstand, but pinconf_generic_parse_dt_config()
> looks at pctldev->desc->custom_params and
> pctldev->desc->num_custom_params found in
> struct pinctrl_desc in
> include/linux/pinctrl/pinctrl.h
The issue is that parse_dt_cfg(), called by the above mentioned pinconf_generic_parse_dt_config(), only uses of_property_read_u32() to get the value of the property.
Conor's proposal for replacing my
st,io-sync = <0>;
with
st,io-sync = "pass-through";
doesn't fit in!
For my use case I'm going to extend parse_dt_cfg() with fwnode_property_match_property_string() to extract the index from an array of strings.
Then such index would be used for pinconf_to_config_packed().
Does this approach look reasonable?
I will send out the series shortly, after some test.
Regards,
Antonio
next prev parent reply other threads:[~2025-10-21 11:50 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 14:04 [PATCH v3 00/10] pinctrl: stm32: Support I/O synchronization Antonio Borneo
2025-10-14 14:04 ` [PATCH v3 01/10] pinctrl: pinconf-generic: Add properties 'skew-delay-{in,out}put' Antonio Borneo
2025-10-14 14:04 ` [PATCH v3 02/10] dt-bindings: pincfg-node: " Antonio Borneo
2025-10-14 18:04 ` Conor Dooley
2025-10-14 19:33 ` Linus Walleij
2025-10-14 19:39 ` Conor Dooley
2025-10-15 12:52 ` Antonio Borneo
2025-10-16 22:34 ` Linus Walleij
2025-10-15 16:37 ` Andrew Lunn
2025-10-16 22:41 ` Linus Walleij
2025-10-14 14:04 ` [PATCH v3 03/10] pinctrl: stm32: Rework stm32_pconf_parse_conf() Antonio Borneo
2025-10-14 14:04 ` [PATCH v3 04/10] pinctrl: stm32: Simplify handling of backup pin status Antonio Borneo
2025-10-14 14:04 ` [PATCH v3 05/10] pinctrl: stm32: Drop useless spinlock save and restore Antonio Borneo
2025-10-14 14:04 ` [PATCH v3 06/10] pinctrl: stm32: Avoid keeping a bool value in a u32 variable Antonio Borneo
2025-10-14 14:04 ` [PATCH v3 07/10] pinctrl: stm32: Support I/O synchronization parameters Antonio Borneo
2025-10-14 14:04 ` [PATCH v3 08/10] dt-bindings: pinctrl: stm32: Use properties from pincfg-node.yaml Antonio Borneo
2025-10-14 18:05 ` Conor Dooley
2025-10-14 14:04 ` [PATCH v3 09/10] dt-bindings: pinctrl: stm32: Support I/O synchronization parameters Antonio Borneo
2025-10-14 18:10 ` Conor Dooley
2025-10-15 12:56 ` Antonio Borneo
2025-10-15 14:35 ` Conor Dooley
2025-10-20 15:09 ` Antonio Borneo
2025-10-20 22:08 ` Linus Walleij
2025-10-21 11:49 ` Antonio Borneo [this message]
2025-10-21 12:26 ` Linus Walleij
2025-10-14 14:04 ` [PATCH v3 10/10] arm64: dts: st: Add I/O sync to eth pinctrl in stm32mp25-pinctrl.dtsi Antonio Borneo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9dfdf02b7e5a99c515aff3c6528e2d5f70517201.camel@foss.st.com \
--to=antonio.borneo@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=brgl@bgdev.pl \
--cc=christophe.roullier@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabien.dessenne@foss.st.com \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh@kernel.org \
--cc=valentin.caron@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).