From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Peng Fan <peng.fan@nxp.com>,
"Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Andy Shevchenko <andy@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Stefan Agner <stefan@agner.ch>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
dl-linux-imx <linux-imx@nxp.com>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 5/5] arm64: dts: imx93: update gpio node
Date: Thu, 14 Sep 2023 08:31:54 +0200 [thread overview]
Message-ID: <9fc4817d-00ae-aaf4-bfb6-b24361f55799@linaro.org> (raw)
In-Reply-To: <DU0PR04MB941722CE1A9BF9F87946DE0A88F7A@DU0PR04MB9417.eurprd04.prod.outlook.com>
On 14/09/2023 08:04, Peng Fan wrote:
>> Subject: Re: [PATCH 5/5] arm64: dts: imx93: update gpio node
>>
>> On 14/09/2023 04:21, Peng Fan (OSS) wrote:
>>> From: Peng Fan <peng.fan@nxp.com>
>>>
>>> Per binding doc, i.MX93 GPIO supports two interrupts, and not
>>> compatible with i.MX7ULP. So update the node
>>>
>>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>>> ---
>>> arch/arm64/boot/dts/freescale/imx93.dtsi | 20 ++++++++++++--------
>>> 1 file changed, 12 insertions(+), 8 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi
>>> b/arch/arm64/boot/dts/freescale/imx93.dtsi
>>> index 6f85a05ee7e1..011c34a57c53 100644
>>> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
>>> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
>>> @@ -825,11 +825,12 @@ usdhc3: mmc@428b0000 {
>>> };
>>>
>>> gpio2: gpio@43810080 {
>>> - compatible = "fsl,imx93-gpio", "fsl,imx7ulp-gpio";
>>> + compatible = "fsl,imx93-gpio", "fsl,imx8ulp-gpio";
>>
>> As your driver change points, it is breaking users, so no :(
>
> ok. Although i.MX93 GPIO is not compatible with i.MX7ULP from HW
> perspective, the compatible string should keep as it is now and binding
If it is not compatible, then how could it work before?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-09-14 6:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 2:20 [PATCH 0/5] gpio: update i.MX93/8ULP and support i.MX95 Peng Fan (OSS)
2023-09-14 2:20 ` [PATCH 1/5] dt-bindings: gpio: vf610: correct i.MX8ULP and i.MX93 interrupts Peng Fan (OSS)
2023-09-14 5:47 ` Krzysztof Kozlowski
2023-09-14 15:03 ` Rob Herring
2023-09-14 2:20 ` [PATCH 2/5] dt-bindings: gpio: vf610: add i.MX95 compatible Peng Fan (OSS)
2023-09-14 5:48 ` Krzysztof Kozlowski
2023-09-14 2:20 ` [PATCH 3/5] gpio: vf610: add i.MX8ULP of_device_id entry Peng Fan (OSS)
2023-09-14 5:48 ` Krzysztof Kozlowski
2023-09-14 8:48 ` Linus Walleij
2023-09-14 8:56 ` Krzysztof Kozlowski
2023-09-14 9:08 ` Peng Fan
2023-09-14 9:39 ` Krzysztof Kozlowski
2023-09-14 2:21 ` [PATCH 4/5] arm64: dts: imx8ulp: update gpio node Peng Fan (OSS)
2023-09-14 2:21 ` [PATCH 5/5] arm64: dts: imx93: " Peng Fan (OSS)
2023-09-14 5:48 ` Krzysztof Kozlowski
2023-09-14 6:04 ` Peng Fan
2023-09-14 6:31 ` Krzysztof Kozlowski [this message]
2023-09-14 6:53 ` Peng Fan
2023-09-14 7:11 ` Krzysztof Kozlowski
2023-09-14 7:26 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fc4817d-00ae-aaf4-bfb6-b24361f55799@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andy@kernel.org \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).