Re: [GIT PULL] GPIO bulk changes for v3.14

[Linus Torvalds <torvalds@linux-foundation.org>]

On Tue, Jan 21, 2014 at 12:36 AM, Linus Walleij
<linus.walleij@linaro.org> wrote:
>
> here is the big GPIO pull request for the v3.14 series.

Ugh. It does not compile for me. The problem seems to be that the
gpio-mcp23s08.c driver only compiles in OF environments, but isn't
properly restricted to them:

  drivers/gpio/gpio-mcp23s08.c: In function ‘mcp23s08_irq_setup’:
  drivers/gpio/gpio-mcp23s08.c:482:46: error: ‘struct gpio_chip’ has
no member named ‘of_node’
    mcp->irq_domain = irq_domain_add_linear(chip->of_node, chip->ngpio,

and similar other errors.

Introduced by commit 4e47f91bf741 ("gpio: mcp23s08: Add irq
functionality for i2c chips") as far as I can tell.

>  It's big this time but has been brewing in linux-next for
> some time and it's all good stuff IMO

The fact that it doesn't even compile makes me doubt your statement
that it has been in linux-next. It doesn't even pass a basic
allmodconfig build.

I see that you tried to fix it in commit 01d7004181c8 ("gpio:
mcp23s08: depend on OF_GPIO") but screwed up the order of operations.

I fixed it up properly in the merge, but please try to figure out how
the hell this passed through the cracks.

             Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html