From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [GIT PULL] GPIO bulk changes for v3.14 Date: Tue, 21 Jan 2014 10:11:39 -0800 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-vb0-f52.google.com ([209.85.212.52]:57104 "EHLO mail-vb0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755017AbaAUSLk convert rfc822-to-8bit (ORCPT ); Tue, 21 Jan 2014 13:11:40 -0500 In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Linus Walleij , Lars Poeschel Cc: "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" On Tue, Jan 21, 2014 at 12:36 AM, Linus Walleij wrote: > > here is the big GPIO pull request for the v3.14 series. Ugh. It does not compile for me. The problem seems to be that the gpio-mcp23s08.c driver only compiles in OF environments, but isn't properly restricted to them: drivers/gpio/gpio-mcp23s08.c: In function =E2=80=98mcp23s08_irq_setup= =E2=80=99: drivers/gpio/gpio-mcp23s08.c:482:46: error: =E2=80=98struct gpio_chip= =E2=80=99 has no member named =E2=80=98of_node=E2=80=99 mcp->irq_domain =3D irq_domain_add_linear(chip->of_node, chip->ngpi= o, and similar other errors. Introduced by commit 4e47f91bf741 ("gpio: mcp23s08: Add irq functionality for i2c chips") as far as I can tell. > It's big this time but has been brewing in linux-next for > some time and it's all good stuff IMO The fact that it doesn't even compile makes me doubt your statement that it has been in linux-next. It doesn't even pass a basic allmodconfig build. I see that you tried to fix it in commit 01d7004181c8 ("gpio: mcp23s08: depend on OF_GPIO") but screwed up the order of operations. I fixed it up properly in the merge, but please try to figure out how the hell this passed through the cracks. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html