From: Phil Howard <phil@gadgetoid.com>
To: Stefan Wahren <wahrenst@gmx.net>
Cc: "Chris Morgan" <macroalpha82@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
andy.shevchenko@gmail.com,
"Angelo Compagnucci" <angelo.compagnucci@gmail.com>,
"Sean Young" <sean@mess.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-gpio@vger.kernel.org,
"Vincent Whitchurch" <vincent.whitchurch@axis.com>
Subject: Re: [PATCH V4 2/2] pwm: Add GPIO PWM driver
Date: Wed, 28 Feb 2024 12:43:59 +0000 [thread overview]
Message-ID: <CA+kSVo9HmDvyCCezddJdZFUeJDGP9Lb5oKSMeXmzB78VvcM1NA@mail.gmail.com> (raw)
In-Reply-To: <3e65fd65-ccfc-4a77-8934-52791662bdce@gmx.net>
On Tue, 27 Feb 2024 at 16:59, Stefan Wahren <wahrenst@gmx.net> wrote:
>
> Hi Chris,
>
> Am 27.02.24 um 16:32 schrieb Chris Morgan:
> > I have a series of devices with GPIO controlled force feedback that
> > this driver helps us control better. So I'm looking forward to this,
> > thank you.
> Thanks for testing. I didn't had much time recently and i was fighting
> with hr timer resolution stuff. But will try to send the next version in
> March.
> > Note that when I set the resolution too low (I got confused and set
> > the period to 255) my device locked up hard and only a forced
> > power cycle could bring it back.
> Unfortunately this is a general design issue by driving the GPIO by a
> kernel driver and "expected" behavior. I didn't have a good solution for
> it yet.
>
> What period is too low without limiting other users?
>
> The only idea which comes to my mind is to introduce a kernel parameter
> for this driver to set a lower period limit. This can be provided by
> some administrator or system designer with enough experience. So a
> general user doesn't need to care about it.
This works for me. I also mucked up the period to see what appears to be
a signal in the MHz range, but got a dropped SSH connection for my troubles.
255ns would be ~3.9MHz which is quite spectacularly far outside of the
range I've come to expect from software PWM, but any conservative hard
limit would be trivialised by a faster CPU.
>
> Best regards
>
> > Tested-by: Chris Morgan <macromorgan@hotmail.com>
>
--
Philip Howard
next prev parent reply other threads:[~2024-02-28 12:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-04 22:08 [PATCH V4 0/2] pwm: Add GPIO PWM driver Stefan Wahren
2024-02-04 22:08 ` [PATCH V4 1/2] dt-bindings: pwm: Add pwm-gpio Stefan Wahren
2024-02-04 22:47 ` Linus Walleij
2024-02-05 5:58 ` Dhruva Gole
2024-02-05 7:44 ` Krzysztof Kozlowski
2024-02-05 9:15 ` Uwe Kleine-König
2024-02-05 11:58 ` Stefan Wahren
2024-02-04 22:08 ` [PATCH V4 2/2] pwm: Add GPIO PWM driver Stefan Wahren
2024-02-04 22:50 ` Linus Walleij
2024-02-05 6:11 ` Dhruva Gole
2024-02-05 7:16 ` Stefan Wahren
2024-02-05 10:09 ` Uwe Kleine-König
2024-02-05 12:21 ` Stefan Wahren
2024-02-27 15:32 ` Chris Morgan
2024-02-27 16:59 ` Stefan Wahren
2024-02-28 12:43 ` Phil Howard [this message]
2024-02-29 8:45 ` Sean Young
2024-02-29 8:57 ` Sean Young
2024-02-27 16:41 ` Andy Shevchenko
2024-02-27 20:24 ` Stefan Wahren
2024-02-27 20:47 ` Andy Shevchenko
2024-02-28 18:06 ` Stefan Wahren
2024-02-05 5:55 ` [PATCH V4 0/2] " Dhruva Gole
2024-02-05 7:08 ` Stefan Wahren
2024-02-05 13:06 ` Phil Howard
2024-05-27 8:22 ` Linus Walleij
2024-05-27 8:44 ` Stefan Wahren
2024-05-27 9:56 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+kSVo9HmDvyCCezddJdZFUeJDGP9Lb5oKSMeXmzB78VvcM1NA@mail.gmail.com \
--to=phil@gadgetoid.com \
--cc=andy.shevchenko@gmail.com \
--cc=angelo.compagnucci@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=macroalpha82@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean@mess.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vincent.whitchurch@axis.com \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).