From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Courbot Subject: Re: [PATCH v2] gpio: make of_get_named_gpiod_flags() private Date: Fri, 23 May 2014 12:34:13 +0900 Message-ID: References: <1400306090-4092-1-git-send-email-acourbot@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Linus Walleij Cc: Alexandre Courbot , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-Id: linux-gpio@vger.kernel.org On Wed, May 21, 2014 at 6:16 PM, Linus Walleij wrote: > On Sat, May 17, 2014 at 7:54 AM, Alexandre Courbot wrote: > >> of_get_named_gpiod_flags() is visible and directly usable by GPIO >> consumers, but it really should not as the gpiod interface relies >> on the simpler gpiod_get() to provide properly-configured GPIOs. >> >> of_get_named_gpiod_flags() is just used internally by gpiolib to >> implement gpiod_get(), and by the old of_get_named_gpio_flags() >> function, therefore it makes sense to make it gpiolib-private. >> >> As a side-effect, the unused (and unneeded) of_get_gpiod_flags() >> inline function is also removed, and of_get_named_gpio_flags() is moved >> from a static inline function to a regular one in gpiolib-of.c >> >> This results in all references to gpiod_* functions in of_gpio.h being >> gone, which is the way it should be since this file is part of the old >> integer GPIO interface. >> >> Signed-off-by: Alexandre Courbot >> --- >> Changes since v1: >> - Fixed compilation error when CONFIG_OF_GPIO is not defined >> - Fixed warning due to of_gpio_flags enum not being declared >> in private gpiolib.h header > > Applied this v2 version and pushed for testing, let's hope it flies > properly this time :-D Looks like the world did not break this time. However I noticed that the commit in your tree (and -next) included the changes since v1 in its log. Is it intended?