* [PATCH] gpio: zynq: Fix problem with unbalanced pm_runtime_enable
@ 2015-06-25 8:29 Michal Simek
2015-06-30 13:46 ` Alexandre Courbot
2015-07-16 11:01 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Michal Simek @ 2015-06-25 8:29 UTC (permalink / raw)
To: linux-kernel, monstr
Cc: Sören Brinkmann, Steffen Trumtrar, Linus Walleij,
Peter Crosthwaite, linux-gpio, Rob Herring, Alexandre Courbot,
Josh Cartwright, linux-arm-kernel
Add missing pm_runtime_disabled to remove().
Error log:
root@zynqmp:~# modprobe gpio_zynq
root@zynqmp:~# lsmod
Not tainted
gpio_zynq 7086 0 - Live 0xffffffbffc00a000
root@zynqmp:~# rmmod gpio_zynq
root@zynqmp:~# lsmod
Not tainted
root@zynqmp:~# modprobe gpio_zynq
[ 246.924438] zynq-gpio ff0a0000.gpio: Unbalanced pm_runtime_enable!
root@zynqmp:~# rmmod gpio_zynq
root@zynqmp:~# lsmod
Not tainted
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
drivers/gpio/gpio-zynq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c
index 2e87c4b8da26..a78882389836 100644
--- a/drivers/gpio/gpio-zynq.c
+++ b/drivers/gpio/gpio-zynq.c
@@ -757,6 +757,7 @@ static int zynq_gpio_remove(struct platform_device *pdev)
gpiochip_remove(&gpio->chip);
clk_disable_unprepare(gpio->clk);
device_set_wakeup_capable(&pdev->dev, 0);
+ pm_runtime_disable(&pdev->dev);
return 0;
}
--
2.3.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] gpio: zynq: Fix problem with unbalanced pm_runtime_enable
2015-06-25 8:29 [PATCH] gpio: zynq: Fix problem with unbalanced pm_runtime_enable Michal Simek
@ 2015-06-30 13:46 ` Alexandre Courbot
2015-07-16 11:01 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Courbot @ 2015-06-30 13:46 UTC (permalink / raw)
To: Michal Simek
Cc: Linux Kernel Mailing List, monstr, Sören Brinkmann,
Steffen Trumtrar, Linus Walleij, Peter Crosthwaite,
linux-gpio@vger.kernel.org, Rob Herring, Josh Cartwright,
linux-arm-kernel@lists.infradead.org
On Thu, Jun 25, 2015 at 5:29 PM, Michal Simek <michal.simek@xilinx.com> wrote:
> Add missing pm_runtime_disabled to remove().
>
> Error log:
> root@zynqmp:~# modprobe gpio_zynq
> root@zynqmp:~# lsmod
> Not tainted
> gpio_zynq 7086 0 - Live 0xffffffbffc00a000
> root@zynqmp:~# rmmod gpio_zynq
> root@zynqmp:~# lsmod
> Not tainted
> root@zynqmp:~# modprobe gpio_zynq
> [ 246.924438] zynq-gpio ff0a0000.gpio: Unbalanced pm_runtime_enable!
> root@zynqmp:~# rmmod gpio_zynq
> root@zynqmp:~# lsmod
> Not tainted
Yup, this was missing indeed.
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> drivers/gpio/gpio-zynq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c
> index 2e87c4b8da26..a78882389836 100644
> --- a/drivers/gpio/gpio-zynq.c
> +++ b/drivers/gpio/gpio-zynq.c
> @@ -757,6 +757,7 @@ static int zynq_gpio_remove(struct platform_device *pdev)
> gpiochip_remove(&gpio->chip);
> clk_disable_unprepare(gpio->clk);
> device_set_wakeup_capable(&pdev->dev, 0);
> + pm_runtime_disable(&pdev->dev);
> return 0;
> }
>
> --
> 2.3.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: zynq: Fix problem with unbalanced pm_runtime_enable
2015-06-25 8:29 [PATCH] gpio: zynq: Fix problem with unbalanced pm_runtime_enable Michal Simek
2015-06-30 13:46 ` Alexandre Courbot
@ 2015-07-16 11:01 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2015-07-16 11:01 UTC (permalink / raw)
To: Michal Simek
Cc: linux-kernel@vger.kernel.org, Michal Simek, Sören Brinkmann,
Steffen Trumtrar, Peter Crosthwaite, linux-gpio@vger.kernel.org,
Rob Herring, Alexandre Courbot, Josh Cartwright,
linux-arm-kernel@lists.infradead.org
On Thu, Jun 25, 2015 at 10:29 AM, Michal Simek <michal.simek@xilinx.com> wrote:
> Add missing pm_runtime_disabled to remove().
>
> Error log:
> root@zynqmp:~# modprobe gpio_zynq
> root@zynqmp:~# lsmod
> Not tainted
> gpio_zynq 7086 0 - Live 0xffffffbffc00a000
> root@zynqmp:~# rmmod gpio_zynq
> root@zynqmp:~# lsmod
> Not tainted
> root@zynqmp:~# modprobe gpio_zynq
> [ 246.924438] zynq-gpio ff0a0000.gpio: Unbalanced pm_runtime_enable!
> root@zynqmp:~# rmmod gpio_zynq
> root@zynqmp:~# lsmod
> Not tainted
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Patch applied with Alex' ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-16 11:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-25 8:29 [PATCH] gpio: zynq: Fix problem with unbalanced pm_runtime_enable Michal Simek
2015-06-30 13:46 ` Alexandre Courbot
2015-07-16 11:01 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).